[FIX] website_multi_theme: duplicates creation must be done in correct order - #456
Merged
Merged
Conversation
yelizariev
force-pushed
the
10.0-website_multi_theme-fixes
branch
from
May 1, 2018 20:19
4c02775 to
7c1ee80
Compare
pedrobaeza
reviewed
May 2, 2018
| "website, and disabled otherwise. Usually used to load assets.", | ||
| ) | ||
|
|
||
| view_priority = fields.Integer(related='view_id.priority', store=True) |
yelizariev
force-pushed
the
10.0-website_multi_theme-fixes
branch
from
May 2, 2018 14:28
7c1ee80 to
3ededcd
Compare
pedrobaeza
approved these changes
May 3, 2018
yajo
requested changes
May 14, 2018
| "name": "Website Multi Theme", | ||
| "summary": "Support different theme per website", | ||
| "version": "10.0.1.3.2", | ||
| "version": "10.0.1.3.3", |
Member
There was a problem hiding this comment.
This implies database changes, so bump it to 1.4.0
yajo
approved these changes
May 15, 2018
Member
|
There's a conflicting file. |
yelizariev
force-pushed
the
10.0-website_multi_theme-fixes
branch
from
May 15, 2018 14:52
33d6fe4 to
f87a7e1
Compare
Member
Author
|
squashed and rebased 💚 |
yelizariev
pushed a commit
to yelizariev/website-addons
that referenced
this pull request
May 15, 2018
yelizariev
pushed a commit
to yelizariev/website-addons
that referenced
this pull request
May 15, 2018
yelizariev
pushed a commit
to itpp-labs/website-addons
that referenced
this pull request
May 15, 2018
matteoopenf
pushed a commit
to matteoopenf/website
that referenced
this pull request
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After introducing sub-themes #454, it's essential to be sure that views are copied in a correct order.
Imagine that Theme has two theme-dependencies where one depends (i.e. as in manifest) on another. In that case
website.theme.assetrecords for those theme-dependencies can be created in a random order. It might lead to a mess when we copy firstly view that extends not-copied yet view from another theme-dependency.