Skip to content

[11.0][MIG] website_crm_quick_answer - #473

Closed
wpichler wants to merge 1 commit into
OCA:11.0from
Callino:11.0-ported_website_crm_quick_answer-WP
Closed

[11.0][MIG] website_crm_quick_answer#473
wpichler wants to merge 1 commit into
OCA:11.0from
Callino:11.0-ported_website_crm_quick_answer-WP

Conversation

@wpichler

@wpichler wpichler commented Jun 5, 2018

Copy link
Copy Markdown

No description provided.

@pedrobaeza pedrobaeza added this to the 11.0 milestone Jun 5, 2018
@pedrobaeza

pedrobaeza commented Jun 5, 2018

Copy link
Copy Markdown
Member

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

MeetKD
MeetKD suggested changes Jul 29, 2018
View reviewed changes
Comment thread website_crm_quick_answer/__manifest__.py Outdated
],
'author': 'Tecnativa, '
'Odoo Community Association (OCA)',
'website': 'https://www.tecnativa.com',

@MeetKD MeetKD Jul 29, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

website should be https://github.com/OCA/website and you can also remove th4e encoding from py files.

@wpichler wpichler Oct 8, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed website now

@rafaelbn

rafaelbn commented Oct 7, 2018

Copy link
Copy Markdown
Member

Hello @wpichler !

Are you going to continue with this PR? If not please close this PR.

We need to migrate this module to v11 so if no answer we will do a new PR

You haven't answered to last comments

Thanks a lot!

nikul-serpentcs
nikul-serpentcs reviewed Oct 8, 2018
View reviewed changes

@nikul-serpentcs nikul-serpentcs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve Code

Comment thread website_crm_quick_answer/README.rst Outdated

.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/186/10.0

@nikul-serpentcs nikul-serpentcs Oct 8, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wpichler IMO Change target 11.0

@wpichler wpichler Oct 8, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to create a new runbot target ?

@nikul-serpentcs nikul-serpentcs Oct 8, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only change :target: https://runbot.odoo-community.org/runbot/186/11.0

Comment thread website_crm_quick_answer/data/automation.xml
@@ -0,0 +1,56 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>

@nikul-serpentcs nikul-serpentcs Oct 8, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO <odoo noupdate="1"> and remove this

@wpichler wpichler Oct 8, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@wpichler
wpichler force-pushed the 11.0-ported_website_crm_quick_answer-WP branch 3 times, most recently from 49e7d78 to ccfb7b5 Compare October 8, 2018 09:18
simahawk
simahawk requested changes Oct 8, 2018
View reviewed changes
Comment thread website_crm_quick_answer/README.rst Outdated
@@ -0,0 +1,77 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg

@simahawk simahawk Oct 8, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

png

@simahawk simahawk changed the title [ADD] adds crm_quick_answer ported to v11 [11.0][MIG] website_crm_quick_answer Oct 8, 2018
@wpichler
wpichler force-pushed the 11.0-ported_website_crm_quick_answer-WP branch from ccfb7b5 to c763e49 Compare October 8, 2018 10:25
@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 29, 2018
Closed
38 tasks
@github-actions

github-actions Bot commented Mar 13, 2022

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 13, 2022
@github-actions github-actions Bot closed this Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk requested changes
+2 more reviewers
@nikul-serpentcs nikul-serpentcs nikul-serpentcs left review comments
@MeetKD MeetKD MeetKD requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs review stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

11.0

Development

Successfully merging this pull request may close these issues.

7 participants

@wpichler @pedrobaeza @rafaelbn @simahawk @nikul-serpentcs @MeetKD @gbaumgartner-callino