[11.0][MIG] website_google_tag_manager: Migration to 11.0 - #524
Conversation
* [ADD] New module 'website_google_tag_manager' * [FIX] website_google_tag_manager - Added OCA as author * [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager') * [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
pedrobaeza
left a comment
There was a problem hiding this comment.
Also remove the SVG icon, as it's the standard one.
| _inherit = 'website' | ||
|
|
||
| google_tag_manager_key = fields.Char(u"Google Tag Manager Key") | ||
| has_google_tag_manager = fields.Boolean('Google Tag Manager') |
There was a problem hiding this comment.
Why adding this boolean? Isn't better to simply add the key if present? If not, you should program an onchange that unchecking this field, the field is emptied.
There was a problem hiding this comment.
It could be simpler, as in previous versions there was only the fields to include key_analytics, key_google maps, etc ..., but I have included that field to the same structure of website settings. Right now there isn't any group to include that field.
There was a problem hiding this comment.
But you don't need an extra field for that. Use other structure.
|
Check also Runbot and Travis status |
38ff63c to
32f7e3a
Compare
|
@cristinamartinrod can you attend my comments? |
f103ee8 to
31ec332
Compare
| <xpath expr="//div[@id='google_maps_setting']" position="after"> | ||
| <div class="col-xs-12 col-md-6 o_setting_box" id="google_tag_manager_setting"> | ||
| <!-- <div class="o_setting_left_pane"> | ||
| </div> --> |
| </xpath> | ||
| </template> | ||
|
|
||
| <template id="web_layout" inherit_id="web.layout"> |
There was a problem hiding this comment.
Inherit from website.layout instead. Backend doesn't need this, right?
There was a problem hiding this comment.
This is not for the backend
There was a problem hiding this comment.
Then change it, website.layout is the frontend-only layout.
There was a problem hiding this comment.
But the problem is that this view is for meta-tags, and this show it in web.layout view
| @@ -0,0 +1,5 @@ | |||
| To configure this module, you need to: | |||
|
|
|||
| #. Go to **Website > Configuration >Settings** | |||
743fa72 to
5e8207e
Compare
dec83aa to
7e6bcd2
Compare
|
@pedrobaeza review please :) |
|
@cristinamartinrod The SVG file is still there... |
803a3d0 to
ffb884a
Compare
|
Please squash your fixups and we are ready to merge. |
2f5475c to
4552b8f
Compare
This module allows to configure Google Tag Manager on website.
cc @Tecnativa