Skip to content

Add module website_container_fluid. - #58

Merged
pedrobaeza merged 2 commits into
8.0from
unknown repository
Sep 8, 2015
Merged

Add module website_container_fluid.#58
pedrobaeza merged 2 commits into
8.0from
unknown repository

Conversation

@yajo

@yajo yajo commented Jul 28, 2015

Copy link
Copy Markdown
Member

It lets the web designer choose easily if he wants to use a <div class="container-fluid"> instead of Odoo's default <div class="container"> elements.

Bootstrap relevant docs.

pedrobaeza
pedrobaeza reviewed Jul 29, 2015
View reviewed changes
Comment thread website_container_fluid/README.rst Outdated

@pedrobaeza pedrobaeza Jul 29, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module title missing

@pedrobaeza

pedrobaeza commented Jul 29, 2015

Copy link
Copy Markdown
Member

Can you provide a sample block with this kind of container inserted in one demo page?

@yajo

yajo commented Jul 30, 2015

Copy link
Copy Markdown
Member Author

All done.

dreispt
dreispt reviewed Jul 30, 2015
View reviewed changes
Comment thread website_sale_collapse_categories/static/src/css/website_sale.css Outdated

@dreispt dreispt Jul 30, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

@yajo yajo Jul 30, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, Sass auto-copiler complaining. I should not have committed that. Fixed now.

@pedrobaeza

pedrobaeza commented Aug 1, 2015

Copy link
Copy Markdown
Member

Tried on runbot and everything seems right 👍

Travis error is unrelated.

@LeartS

LeartS commented Aug 14, 2015

Copy link
Copy Markdown

Testing on runbot I get this graphic issue:
ui-problem
Which I do not get on runbot of the 8.0 branch of this repo.

Apart from that, 👍

@yajo

yajo commented Sep 7, 2015

Copy link
Copy Markdown
Member Author

I fixed that glitch, but now I need help with the checks. Seems like some UI tests from upstream module website_sale fail, but I do not understand those tests nor why do they fail. The same did fail before last commit, so I guess it's not related to what @LeartS said.

@pedrobaeza

pedrobaeza commented Sep 7, 2015

Copy link
Copy Markdown
Member

Don't worry about Travis. It's broken for now for this repo. If @LeartS gives their second approval, then I merge.

@dgzurita

dgzurita commented Sep 7, 2015

Copy link
Copy Markdown

👍 very useful

@LeartS

LeartS commented Sep 8, 2015

Copy link
Copy Markdown

👍

pedrobaeza added a commit that referenced this pull request Sep 8, 2015
@pedrobaeza
Merge pull request #58 from grupoesoc/fluid-containers
84ae6c5 
Add module website_container_fluid.
@pedrobaeza
pedrobaeza merged commit 84ae6c5 into OCA:8.0 Sep 8, 2015
@yajo

yajo commented Sep 8, 2015

Copy link
Copy Markdown
Member Author

Thanks!

@yajo
yajo deleted the fluid-containers branch September 8, 2015 11:53
@yajo yajo mentioned this pull request Dec 19, 2016
Merged
bealdav pushed a commit to akretion/website that referenced this pull request Feb 10, 2017
@rafaelbn
Merge pull request OCA#58 from Yajo/megamenu
67d212b 
Add module website_sale_categories_megamenu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yajo @pedrobaeza @LeartS @dgzurita @dreispt