Remove geoalchemy dep

[ocefpaf]

This PR partially addresses #59 (comment)

Note that PR #58 (mentioned in #59) was merged but geoalchemy/geoalchemy#42 was not. It seems that if the path is to remove geoalchemygeoalchemy/geoalchemy#42 will need to be re-written or just closed.

I could not find any other code reference to geoalchemy in master. I am unsure of the status on the multiple branches. BTW that many branches put a really high bar to get third party contributions to the code. I would be nice to reduce the development to master and eliminate the branches to temporary work on active PRs or stable releases.

I could not get the CIs to pass but looking at the history it seems that it is not passing for sometime now.

cc @emiliom and @valentinedwv

xref #59

[emiliom]

A follow-up (two months later ...).

Note that PR #58 (mentioned in #59) was merged but geoalchemy/geoalchemy#42 was not. It seems that if the path is to remove geoalchemygeoalchemy/geoalchemy#42 will need to be re-written or just closed.

I don't see why we need to concern ourselves with anything on the original geoalchemy repo. We set up https://github.com/ODM2/geoalchemy as a deliberate fork with our own tweaks/fixes, not expecting to contribute back to the original repo b/c the repo was/is no longer being actively maintained (development shifted to https://github.com/geoalchemy/geoalchemy2, which is a different beast). Besides, what we're trying to do (at least for now) is remove the geoalchemy dependency ...

[emiliom]

Why is sqlalchemy being removed here? Is it being handled as a requirement/dependency somewhere else?

[ocefpaf]

Probably, but since we do import it directly in odm2api I guess it is better to leave it untouched.
We never know if the other dependencies that brings it will drop it in the future.

[emiliom]

Might as well also remove the commented-out shapely. It's pointless or totally optional w/o geoalchemy.

[ocefpaf]

OK

[emiliom]

@ocefpaf I'll wait to hear back from you on the two line comments I've just made, before trying to merge.

[ocefpaf]

@ocefpaf I'll wait to hear back from you on the two line comments I've just made, before trying to merge.

I addressed both comments in the last commit. Should be OK now. Thanks!

[emiliom]

Great, thanks. Merging now.