Fix person and organization filter for affiliations

[lsetiawan]

Overview

This PR addresses #95. It joins the necessary table to Affiliations table so that filter can actually occur. I have tested it and it seems to work.

[emiliom]

So, a join is necessary, and you can't use the relationships defined in the Affiliations model? eg, OrganizationObj = relationship(Organizations)

[lsetiawan]

@emiliom How do I go about that? Sorry.. not SQLAlchemy pro here 😉

[emiliom]

@emiliom How do I go about that? Sorry.. not SQLAlchemy pro here

Neither am I! But I'd look for similar examples in other query functions.

If it is in fact doable, it seems cleaner to reuse that "predefined" relationship rather than adding explicit joins.

[lsetiawan]

@emiliom Is this what you're looking for? I still have to do the join... Can't find anything that simply filters straight up from relationship.

[lsetiawan]

I got the sample from https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/services/readService.py#L421

[emiliom]

Hmm. That doesn't look better 😞

After looking at what's used in readService.py, I can see that there's some variability, and the two join forms you've used (in the two commits) are what's used. Oh well.

If you've tested this, let's go with it. It would seem cleaner and possibly more efficient (in some cases) to do all the joining in the query statement, but let's not bother.

Thanks.

[emiliom]

Let me know if you've tested this commit, and I'll accept the PR.

[lsetiawan]

This has been tested and good to go with your approval. Thanks!