Website redesign - #348
Merged
Merged
Website redesign#348
Conversation
lisicase
force-pushed
the
lisicase/redesignMerge
branch
from
July 26, 2023 08:21
b360977 to
06c398c
Compare
lisicase
requested review from
ElizabethOkerio,
KenitoInc,
gathogojr,
habbes,
marabooy,
mikepizzo,
paulodero,
wachugamaina,
wandeg and
xuzhg
July 28, 2023 19:47
xuzhg
approved these changes
Jul 29, 2023
marabooy
reviewed
Jul 31, 2023
marabooy
reviewed
Jul 31, 2023
| type="text" | ||
| aria-label="Search" | ||
| class="form-control st-default-search-input" | ||
| class="search-bar-input form-control" |
Member
There was a problem hiding this comment.
Check to see if the swift type works I doubt it would fail with the css change but probably requires some verification would be required as the js provides accessible search through the dynamic widget.
Contributor
Author
There was a problem hiding this comment.
As far as I can tell, the class change doesn't affect the functionality (the scripts appear to reference the main-search-input ID, and the search results seem the same), but if there's something I'm missing, do let me know.
marabooy
approved these changes
Aug 1, 2023
gathogojr
added a commit
that referenced
this pull request
Aug 10, 2023
This reverts commit bb7aee4.
gathogojr
added a commit
that referenced
this pull request
Aug 11, 2023
gathogojr
added a commit
to gathogojr/odataorg.github.io
that referenced
this pull request
Aug 11, 2023
gathogojr
added a commit
to gathogojr/odataorg.github.io
that referenced
this pull request
Sep 11, 2023
gathogojr
added a commit
to gathogojr/odataorg.github.io
that referenced
this pull request
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Design changes have been made in accordance with the wireframes and follow-up discussion during the OData team meeting.
Before & After
Home:
Get Started:
Tools:
Libraries:
Blog:
Ecosystem:
Remaining Work
Remaining tasks (such as those regarding the UI and data storage) detailed in handoff documentation. Of particular note is hooking up the contribution form, which is marked via a TODO in comments in this PR.