Add files only on prod to repo and template to generate sitemap - #358
Merged
gathogojr merged 1 commit intoSep 8, 2023
Conversation
gathogojr
requested review from
ElizabethOkerio,
KenitoInc,
habbes and
marabooy
September 8, 2023 07:33
Contributor
|
Where is the template that generates the two files? Does it need to be added here? or how does it work? |
habbes
approved these changes
Sep 8, 2023
Contributor
Author
The two files sitemap and sitemap.xml in this pull request are actually templates that Jekyll uses to generate _site/sitemap and _site/sitemap.xml that look as follows: <?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd" xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
<url>
<loc>https://www.odata.org/ecosystem/consumers/(unofficial)-SSIS-import-script/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/ADO.NET-Driver/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/Access-Odata/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/BOARD/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/Browsers/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/CS-Connect/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/Client-Libraries/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/DataPublic/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/Database-NET-v3/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<!-- MORE -->
</urlset> |
gathogojr
force-pushed
the
fix/add-files-only-on-prod-to-repo-and-template-to-generate-sitemap
branch
from
September 8, 2023 08:09
9eac2ed to
591453b
Compare
ElizabethOkerio
approved these changes
Sep 8, 2023
marabooy
approved these changes
Sep 8, 2023
KenitoInc
approved these changes
Sep 8, 2023
gathogojr
deleted the
fix/add-files-only-on-prod-to-repo-and-template-to-generate-sitemap
branch
September 8, 2023 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since GitHub actions ZipDeploy deployment method DOES NOT preserve any files on the target directory if they're not in the package being deployed, I identified files present in prod (most likely pushed directly) but not in the GitHub repository and added them to the repository so they'll get packaged and published during deployment.
In addition, since a sitemap.xml file is present on prod and a Jekyll template for generating that file didn't exist in the repo, I added such a template that generates both sitemap and sitemap.xml.
I wouldn't say I understand whether or why both are needed but I noticed that feed and feed.xml as well as blog/feed and blog/feed.xml that do something similar also exist in pairs.
Note: You can run
jekyll buildlocally to see the sitemap file that is generated