Tedefo 4805 efx rules translator by rousso · Pull Request #40 · OP-TED/eforms-core-java

rousso · 2025-12-26T12:36:21Z

No description provided.

- Add EFX_RULES_TRANSLATOR to SdkComponentType enum - Required for Schematron generation from EFX Rules

Copilot

Pull request overview

This pull request adds support for notice type/subtype handling and introduces new component types (EFX_RULES_TRANSLATOR and VALIDATOR_GENERATOR) to the SDK component factory. The primary additions include a new entity class for notice subtypes and a repository to manage them.

Key changes:

Introduces SdkNoticeSubtype entity class to represent notice subtypes from the SDK's notice-types.json file
Adds SdkNoticeTypeRepository to load and manage notice subtype data
Extends component type enumeration to support EFX rules translator and validator generator functionality

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
SdkNoticeSubtype.java	New abstract entity class representing notice subtypes with fields for subTypeId, documentType, and type
SdkNoticeTypeRepository.java	New repository class extending MapFromJson to load notice subtypes from JSON
SdkEntityFactory.java	Adds factory method `getSdkNoticeType` to instantiate SdkNoticeSubtype implementations
SdkComponentType.java	Extends enum with NOTICE_TYPE, EFX_RULES_TRANSLATOR, and VALIDATOR_GENERATOR component types
SdkConstants.java	Adds NOTICE_TYPES_JSON_SUBTYPES_KEY constant for JSON parsing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ariable names

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-26T13:42:45Z

+ public int compareTo(SdkNoticeSubtype o) {
+ return this.subTypeId.compareTo(o.subTypeId);
+ }


The compareTo method can throw a NullPointerException if subTypeId is null. The JsonNode constructor (line 21) uses asText(null) which can return null. Consider adding null safety checks or using Objects.compare with a null-safe comparator, similar to how SdkCodelist handles this (see SdkCodelist.java:67-69).

Copilot · 2025-12-26T13:42:45Z

+ public String getId() {
+ return subTypeId;
+ }


The getId() method returns subTypeId which can be null (set via asText(null) in the JsonNode constructor at line 21). This could cause NullPointerException in callers who expect a non-null value, such as in SdkNoticeTypeRepository.java:26 where it's used as a map key, and in the compareTo method. Consider validating that critical fields like subTypeId are non-null after construction, or document that null is a valid return value.

Copilot · 2025-12-26T13:42:45Z

+ this.subTypeId = json.get("subTypeId").asText(null);
+ this.documentType = json.get("documentType").asText(null);
+ this.type = json.get("type").asText(null);


The JsonNode constructor does not validate that required JSON fields (subTypeId, documentType, type) exist before accessing them. If json.get("subTypeId") returns null, calling asText(null) on it will throw a NullPointerException. Consider adding null checks or using safer accessor methods like json.has("subTypeId") before accessing, consistent with how SdkNode handles optional fields (see SdkNode.java:27).
Suggested change
this.subTypeId = json.get("subTypeId").asText(null);
this.documentType = json.get("documentType").asText(null);
this.type = json.get("type").asText(null);
if (json == null) {
thrownewIllegalArgumentException("json must not be null when creating SdkNoticeSubtype");
}
JsonNodesubTypeIdNode = json.get("subTypeId");
JsonNodedocumentTypeNode = json.get("documentType");
JsonNodetypeNode = json.get("type");
if (subTypeIdNode == null || documentTypeNode == null || typeNode == null) {
thrownewIllegalArgumentException("Missing required fields (subTypeId, documentType, type) in notice subtype JSON: " + json);
}
this.subTypeId = subTypeIdNode.asText(null);
this.documentType = documentTypeNode.asText(null);
this.type = typeNode.asText(null);

bertrand-lorentz · 2026-01-05T10:23:58Z

Is this ready for review ? I'm not indicated as a reviewer.

bertrand-lorentz

Can go as-is, but please have a look at my comments on the enum value, and the missing update of README files.

bertrand-lorentz · 2026-01-06T15:52:04Z

Similar classes in this folder are described in the README file in the folder. So this new class should also be described in this README, for consistency.

@copilot please address this remark by adding an adequate reference to this class in the respected README file.

bertrand-lorentz · 2026-01-06T15:52:29Z

Similar classes in this folder are described in the README file in the folder. So this new class should also be described in this README, for consistency.

@copilot please address this remark by adding an adequate reference to this class in the respected README file.

bertrand-lorentz · 2026-01-06T16:03:01Z

 */
 public enum SdkComponentType {
- FIELD, NODE, CODELIST, EFX_EXPRESSION_TRANSLATOR, EFX_TEMPLATE_TRANSLATOR, SYMBOL_RESOLVER, SCRIPT_GENERATOR, MARKUP_GENERATOR;
+ FIELD, NODE, CODELIST, NOTICE_TYPE, EFX_EXPRESSION_TRANSLATOR, EFX_TEMPLATE_TRANSLATOR, EFX_RULES_TRANSLATOR,


The value name "NOTICE_TYPE" is inconsistent with the corresponding class SdkNoticeSubtype, but it corresponds to the folder named "notice-types" in the SDK.
So I'm not sure which is the best name here.

I am not sure either... We will have a name finalisation debate before we release the SDK. The subtypes are a common naming problem but there are others like for example the fact that we interchangeably use the terms "string" and "text" in the grammar. We will deal with any such remaining naming issues when all else i ready.

Copilot · 2026-01-06T17:04:20Z

@rousso I've opened a new pull request, #41, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-06T17:04:33Z

@rousso I've opened a new pull request, #42, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Add SdkNoticeTypeRepository reference to README Co-authored-by: rousso <91379+rousso@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rousso <91379+rousso@users.noreply.github.com>

* Initial plan * Add SdkNoticeSubtype reference to entity README Co-authored-by: rousso <91379+rousso@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rousso <91379+rousso@users.noreply.github.com>

rousso added 3 commits November 12, 2025 02:49

Add EFX Rules translator component type
5e3f420
- Add EFX_RULES_TRANSLATOR to SdkComponentType enum - Required for Schematron generation from EFX Rules

Added SDK notice subtype entity and repository
c724b0b

Refactor: Rename VALIDATOR_MARKUP_GENERATOR to VALIDATOR_GENERATOR
0331b91

rousso requested a review from Copilot December 26, 2025 12:36

Copilotstarted reviewing on behalf of rousso December 26, 2025 12:36 View session

CopilotAI reviewed Dec 26, 2025
View reviewed changes

Comment threadsrc/main/java/eu/europa/ted/eforms/sdk/entity/SdkNoticeSubtype.java
Comment threadsrc/main/java/eu/europa/ted/eforms/sdk/entity/SdkNoticeSubtype.java Outdated
Comment threadsrc/main/java/eu/europa/ted/eforms/sdk/entity/SdkNoticeSubtype.java Outdated

rousso self-assigned this Dec 26, 2025

Refactor: Update SdkNoticeSubtype and SdkField
7d77eff

rousso requested a review from Copilot December 26, 2025 13:18

Copilotstarted reviewing on behalf of rousso December 26, 2025 13:18 View session

CopilotAI reviewed Dec 26, 2025
View reviewed changes

Comment threadsrc/main/java/eu/europa/ted/eforms/sdk/repository/SdkNoticeTypeRepository.java Outdated
Comment threadsrc/main/java/eu/europa/ted/eforms/sdk/entity/SdkEntityFactory.java Outdated
Comment threadsrc/main/java/eu/europa/ted/eforms/sdk/repository/SdkNoticeTypeRepository.java Outdated

Refactor: Rename getSdkNoticeType to getSdkNoticeSubtype and update v…
dd51af2
…ariable names

rousso requested a review from Copilot December 26, 2025 13:40

Copilotstarted reviewing on behalf of rousso December 26, 2025 13:40 View session

CopilotAI reviewed Dec 26, 2025
View reviewed changes

rousso requested a review from bertrand-lorentz January 6, 2026 15:35

bertrand-lorentz approved these changes Jan 6, 2026
View reviewed changes

CopilotAI mentioned this pull request Jan 6, 2026
Add SdkNoticeTypeRepository to README documentation #41
Merged

CopilotAI mentioned this pull request Jan 6, 2026
Add SdkNoticeSubtype to entity package README #42
Merged

CopilotAIand others added 2 commits January 6, 2026 19:33

bertrand-lorentz merged commit 860c50e into developFeb 2, 2026
5 checks passed

bertrand-lorentz deleted the TEDEFO-4805-efx-rules-translator branch February 2, 2026 08:39

-this.subTypeId = json.get("subTypeId").asText(null);
-this.documentType = json.get("documentType").asText(null);
-this.type = json.get("type").asText(null);
+if (json == null) {
+thrownewIllegalArgumentException("json must not be null when creating SdkNoticeSubtype");
+ }
+JsonNodesubTypeIdNode = json.get("subTypeId");
+JsonNodedocumentTypeNode = json.get("documentType");
+JsonNodetypeNode = json.get("type");
+if (subTypeIdNode == null || documentTypeNode == null || typeNode == null) {
+thrownewIllegalArgumentException("Missing required fields (subTypeId, documentType, type) in notice subtype JSON: " + json);
+ }
+this.subTypeId = subTypeIdNode.asText(null);
+this.documentType = documentTypeNode.asText(null);
+this.type = typeNode.asText(null);

Uh oh!

Conversation

rousso commented Dec 26, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

CopilotAIDec 26, 2025

Choose a reason for hiding this comment

Uh oh!

CopilotAIDec 26, 2025

Choose a reason for hiding this comment

Uh oh!

CopilotAIDec 26, 2025

Choose a reason for hiding this comment

Uh oh!

bertrand-lorentz commented Jan 5, 2026

Uh oh!

bertrand-lorentz left a comment

Choose a reason for hiding this comment

Uh oh!

bertrand-lorentzJan 6, 2026

Choose a reason for hiding this comment

Uh oh!

roussoJan 6, 2026

Choose a reason for hiding this comment

Uh oh!

bertrand-lorentzJan 6, 2026

Choose a reason for hiding this comment

Uh oh!

roussoJan 6, 2026

Choose a reason for hiding this comment

Uh oh!

bertrand-lorentzJan 6, 2026

Choose a reason for hiding this comment

Uh oh!

roussoJan 6, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAI commented Jan 6, 2026

Uh oh!

CopilotAI commented Jan 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants