Skip to content

ci(sonarcloud): make SonarCloud scan conditional on SONAR_TOKEN - #5

Merged
gkostkowski merged 1 commit into
OP-TED:developfrom
meaningfy-ws:ci/optional-sonarcloud
Mar 5, 2026
Merged

ci(sonarcloud): make SonarCloud scan conditional on SONAR_TOKEN#5
gkostkowski merged 1 commit into
OP-TED:developfrom
meaningfy-ws:ci/optional-sonarcloud

Conversation

@twicechild

@twicechildtwicechild commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Makes the SonarCloud scan step optional by guarding it with env.SONAR_TOKEN != ''
  • Hoists SONAR_TOKEN from step-level to job-level env so it can be tested in if: conditions (GitHub Actions does not allow secrets.* in if: expressions)
  • When the secret is not configured (e.g. in forks), the step is cleanly skipped instead of failing

This follows the same pattern used in entity-resolution-spec.

gkostkowski
gkostkowski approved these changes Mar 5, 2026
View reviewed changes

@gkostkowskigkostkowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@twicechildtwicechild mentioned this pull request Mar 5, 2026
Merged
@twicechild
twicechildforce-pushed the ci/optional-sonarcloud branch from f655dd5 to 1c1b673CompareMarch 5, 2026 10:33
@gkostkowski
gkostkowski merged commit 8f23d40 into OP-TED:developMar 5, 2026
1 check passed
@twicechild
twicechild deleted the ci/optional-sonarcloud branch March 26, 2026 12:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkostkowskigkostkowskigkostkowski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twicechild@gkostkowski