Conversation
Member
There was a problem hiding this comment.
I think "are all the arguments either :class:Dats accessed through the identity map, or :class:Global?"
Member
Author
|
I've made the changes suggested by @wence. |
Member
|
Looks good to me now. |
Member
Author
|
In order to avoid further embarrassment, I have deferred to the buildbot's judgment on whether this branch actually works: http://buildbot-ocean.ese.ic.ac.uk:8080/builders/pyop2-testing/builds/213 It seems to pass again. |
Member
Author
|
Buildbot pass after fixing d/o_nz mix up: http://buildbot-ocean.ese.ic.ac.uk:8080/builders/pyop2-testing/builds/214 |
Member
|
Excellent. I think now we're good to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought there might have been a few missing docstrings so I started to go through them. This pull request adds the ones I think are missing from base and runtime_base - if some of the docs are overzealous/incorrect, please point it out :-)