Uh oh!
There was an error while loading. Please reload this page.
Fixed XSS vulns in deserialization testfiles - #6
Open
Mike-Ki wants to merge 3 commits into
Open
Conversation
These test cases are intended for deserialization coverage, not XSS. Escaping prevents them from being potentially incorrectly flagged as XSS vulns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains two commits addressing XSS issues in the deserialization test suite.
Commit 1: Fix XSS vulns in deserialization testfiles
Fixes 11 reflected XSS vulnerabilities in deserialization test cases where
user-controlled input was rendered unescaped in the response.
Commit 2: Escape non-vuln cases to prevent false XSS hits
The remaining non-vulnerable deserialization test cases were escaping output
to ensure they are not incorrectly flagged as XSS vulnerabilities. These
cases are intended for deserialization coverage only.
PoCs
BenchmarkTest00079.py
BenchmarkTest00269.py
BenchmarkTest00270.py
BenchmarkTest00271.py
BenchmarkTest00434.py
BenchmarkTest00435.py
BenchmarkTest00827.py
BenchmarkTest00828.py
BenchmarkTest00904.py
BenchmarkTest00994.py
BenchmarkTest00998.py