fix(x402): default 402 challenge resource.url to https on public hosts - #751

Closed
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme
Closed

fix(x402): default 402 challenge resource.url to https on public hosts#751
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme

Conversation

@bussyjd

Copy link
Copy Markdown
Contributor

Summary

What changed: buildResourceURL (the 402 challenge resource.url builder in the verifier's ForwardAuth path) now uses the same scheme resolution as resolveSiteURL: default https, downgrade to http only for hosts the stack serves locally over plain HTTP (obol.stack, loopback, *.localhost/*.local); an explicit https signal (direct TLS or X-Forwarded-Proto: https) still wins for any host. The resolution is extracted into a shared resolveScheme so challenge URLs and 402-page links can never disagree again.

Why it matters: behind a TLS-terminating tunnel the ForwardAuth hop sees plaintext, so the scheme keyed off X-Forwarded-Proto alone renders http:// resource URLs whenever a route lacks the X-Forwarded-Proto: https RequestHeaderModifier. The controller's host-bound so-<name>-host routes carry that filter, but the shared-origin so-<name> routes do not — and being more path-specific for /services/<name>, they win the match even on dedicated-hostname origins. Observed live: 5 of 8 host-bound offers advertised http:// resources in their 402 challenges on https endpoints — a scheme mismatch visible to strict x402 v2 clients and discovery crawlers.

This is the verifier-side half of the correctness gap discussed in #679. It deliberately does NOT force X-Forwarded-Proto: https on shared-origin routes: those also serve genuine local plaintext traffic on obol.stack, where claiming https would be wrong in the other direction.

Risk level: low

Base branch: main

Scope

  • Code

Validation

Unit tests:

go build ./... && go test ./internal/x402/ -count=1 — ok
New TestBuildResourceURL_Scheme: public host no-XFP -> https; public host
XFP=http (tunnel case) -> https; forwarded host honored; obol.stack/localhost
stay http; explicit XFP=https on local host honored; X-Forwarded-Uri preserved.

Live evidence (v0.13.0 deployment behind a Cloudflare tunnel): all 8 host-bound offers' /services/<name> challenges advertised http:// or https:// depending solely on whether a hand-authored route with the header filter happened to match; with trusted forwarded headers (the operator-side workaround) all emit https and a real x402 payment settled end-to-end ($0.01 USDC on Base, exact ledger delta). This patch makes the correct scheme the default with no per-route filters or Traefik trust configuration required.

Refs #679

https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk

buildResourceURL keyed the scheme off X-Forwarded-Proto alone, so behind
a TLS-terminating tunnel (edge https -> plaintext to Traefik -> verifier)
any route without an explicit X-Forwarded-Proto:https RequestHeaderModifier
produced http:// resource URLs in 402 challenges. The controller's
host-bound so-<name>-host routes carry that filter but the shared-origin
so-<name> routes do not — and being more path-specific for
/services/<name>, they win the match even on dedicated-hostname origins,
so challenges on those origins advertised http:// resources on an https
endpoint (strict v2 payment clients and discovery crawlers see a
scheme mismatch; observed live on 5 of 8 host-bound offers, #679).
resolveSiteURL already solved exactly this for 402-page links: default
https, downgrade only for hosts the stack serves locally over plain HTTP
(obol.stack, loopback, *.localhost/*.local), explicit signals always win.
Extract that resolution into resolveScheme and use it in both places, so
challenge resource URLs and page links can never disagree again.
Refs #679
Claude-Session: https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk
@bussyjd
bussyjd requested a review from OisinKyneJuly 15, 2026 13:28
@bussyjdbussyjd mentioned this pull request Jul 15, 2026
6 tasks
@bussyjdbussyjd mentioned this pull request Jul 20, 2026
@bussyjd

Copy link
Copy Markdown
ContributorAuthor

Subsumed by #800 (integration/v0.14.0-rc1) — this change is already folded into rc1 (0 commits not in rc1 by patch-id) and ships in the v0.14.0-rc1 pre-release. Closing to avoid an individual merge forcing an rc1 rebase; the branch is retained.

https://claude.ai/code/session_01PnhCQLz7CHuDBUhWd5xF8v

@bussyjdbussyjd closed this Jul 27, 2026
@bussyjdbussyjd mentioned this pull request Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bussyjd@OisinKyne
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(x402): default 402 challenge resource.url to https on public hosts - #751

Closed
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme
Closed

fix(x402): default 402 challenge resource.url to https on public hosts#751
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme

Conversation

@bussyjd

Copy link
Copy Markdown
Contributor

Summary

What changed: buildResourceURL (the 402 challenge resource.url builder in the verifier's ForwardAuth path) now uses the same scheme resolution as resolveSiteURL: default https, downgrade to http only for hosts the stack serves locally over plain HTTP (obol.stack, loopback, *.localhost/*.local); an explicit https signal (direct TLS or X-Forwarded-Proto: https) still wins for any host. The resolution is extracted into a shared resolveScheme so challenge URLs and 402-page links can never disagree again.

Why it matters: behind a TLS-terminating tunnel the ForwardAuth hop sees plaintext, so the scheme keyed off X-Forwarded-Proto alone renders http:// resource URLs whenever a route lacks the X-Forwarded-Proto: https RequestHeaderModifier. The controller's host-bound so-<name>-host routes carry that filter, but the shared-origin so-<name> routes do not — and being more path-specific for /services/<name>, they win the match even on dedicated-hostname origins. Observed live: 5 of 8 host-bound offers advertised http:// resources in their 402 challenges on https endpoints — a scheme mismatch visible to strict x402 v2 clients and discovery crawlers.

This is the verifier-side half of the correctness gap discussed in #679. It deliberately does NOT force X-Forwarded-Proto: https on shared-origin routes: those also serve genuine local plaintext traffic on obol.stack, where claiming https would be wrong in the other direction.

Risk level: low

Base branch: main

Scope

  • Code

Validation

Unit tests:

go build ./... && go test ./internal/x402/ -count=1 — ok
New TestBuildResourceURL_Scheme: public host no-XFP -> https; public host
XFP=http (tunnel case) -> https; forwarded host honored; obol.stack/localhost
stay http; explicit XFP=https on local host honored; X-Forwarded-Uri preserved.

Live evidence (v0.13.0 deployment behind a Cloudflare tunnel): all 8 host-bound offers' /services/<name> challenges advertised http:// or https:// depending solely on whether a hand-authored route with the header filter happened to match; with trusted forwarded headers (the operator-side workaround) all emit https and a real x402 payment settled end-to-end ($0.01 USDC on Base, exact ledger delta). This patch makes the correct scheme the default with no per-route filters or Traefik trust configuration required.

Refs #679

https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk

buildResourceURL keyed the scheme off X-Forwarded-Proto alone, so behind
a TLS-terminating tunnel (edge https -> plaintext to Traefik -> verifier)
any route without an explicit X-Forwarded-Proto:https RequestHeaderModifier
produced http:// resource URLs in 402 challenges. The controller's
host-bound so-<name>-host routes carry that filter but the shared-origin
so-<name> routes do not — and being more path-specific for
/services/<name>, they win the match even on dedicated-hostname origins,
so challenges on those origins advertised http:// resources on an https
endpoint (strict v2 payment clients and discovery crawlers see a
scheme mismatch; observed live on 5 of 8 host-bound offers, #679).
resolveSiteURL already solved exactly this for 402-page links: default
https, downgrade only for hosts the stack serves locally over plain HTTP
(obol.stack, loopback, *.localhost/*.local), explicit signals always win.
Extract that resolution into resolveScheme and use it in both places, so
challenge resource URLs and page links can never disagree again.
Refs #679
Claude-Session: https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk
@bussyjd
bussyjd requested a review from OisinKyneJuly 15, 2026 13:28
@bussyjdbussyjd mentioned this pull request Jul 15, 2026
6 tasks
@bussyjdbussyjd mentioned this pull request Jul 20, 2026
@bussyjd

Copy link
Copy Markdown
ContributorAuthor

Subsumed by #800 (integration/v0.14.0-rc1) — this change is already folded into rc1 (0 commits not in rc1 by patch-id) and ships in the v0.14.0-rc1 pre-release. Closing to avoid an individual merge forcing an rc1 rebase; the branch is retained.

https://claude.ai/code/session_01PnhCQLz7CHuDBUhWd5xF8v

@bussyjdbussyjd closed this Jul 27, 2026
@bussyjdbussyjd mentioned this pull request Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bussyjd@OisinKyne
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(x402): default 402 challenge resource.url to https on public hosts - #751

Closed
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme
Closed

fix(x402): default 402 challenge resource.url to https on public hosts#751
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme

Conversation

@bussyjd

Copy link
Copy Markdown
Contributor

Summary

What changed: buildResourceURL (the 402 challenge resource.url builder in the verifier's ForwardAuth path) now uses the same scheme resolution as resolveSiteURL: default https, downgrade to http only for hosts the stack serves locally over plain HTTP (obol.stack, loopback, *.localhost/*.local); an explicit https signal (direct TLS or X-Forwarded-Proto: https) still wins for any host. The resolution is extracted into a shared resolveScheme so challenge URLs and 402-page links can never disagree again.

Why it matters: behind a TLS-terminating tunnel the ForwardAuth hop sees plaintext, so the scheme keyed off X-Forwarded-Proto alone renders http:// resource URLs whenever a route lacks the X-Forwarded-Proto: https RequestHeaderModifier. The controller's host-bound so-<name>-host routes carry that filter, but the shared-origin so-<name> routes do not — and being more path-specific for /services/<name>, they win the match even on dedicated-hostname origins. Observed live: 5 of 8 host-bound offers advertised http:// resources in their 402 challenges on https endpoints — a scheme mismatch visible to strict x402 v2 clients and discovery crawlers.

This is the verifier-side half of the correctness gap discussed in #679. It deliberately does NOT force X-Forwarded-Proto: https on shared-origin routes: those also serve genuine local plaintext traffic on obol.stack, where claiming https would be wrong in the other direction.

Risk level: low

Base branch: main

Scope

  • Code

Validation

Unit tests:

go build ./... && go test ./internal/x402/ -count=1 — ok
New TestBuildResourceURL_Scheme: public host no-XFP -> https; public host
XFP=http (tunnel case) -> https; forwarded host honored; obol.stack/localhost
stay http; explicit XFP=https on local host honored; X-Forwarded-Uri preserved.

Live evidence (v0.13.0 deployment behind a Cloudflare tunnel): all 8 host-bound offers' /services/<name> challenges advertised http:// or https:// depending solely on whether a hand-authored route with the header filter happened to match; with trusted forwarded headers (the operator-side workaround) all emit https and a real x402 payment settled end-to-end ($0.01 USDC on Base, exact ledger delta). This patch makes the correct scheme the default with no per-route filters or Traefik trust configuration required.

Refs #679

https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk

buildResourceURL keyed the scheme off X-Forwarded-Proto alone, so behind
a TLS-terminating tunnel (edge https -> plaintext to Traefik -> verifier)
any route without an explicit X-Forwarded-Proto:https RequestHeaderModifier
produced http:// resource URLs in 402 challenges. The controller's
host-bound so-<name>-host routes carry that filter but the shared-origin
so-<name> routes do not — and being more path-specific for
/services/<name>, they win the match even on dedicated-hostname origins,
so challenges on those origins advertised http:// resources on an https
endpoint (strict v2 payment clients and discovery crawlers see a
scheme mismatch; observed live on 5 of 8 host-bound offers, #679).
resolveSiteURL already solved exactly this for 402-page links: default
https, downgrade only for hosts the stack serves locally over plain HTTP
(obol.stack, loopback, *.localhost/*.local), explicit signals always win.
Extract that resolution into resolveScheme and use it in both places, so
challenge resource URLs and page links can never disagree again.
Refs #679
Claude-Session: https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk
@bussyjd
bussyjd requested a review from OisinKyneJuly 15, 2026 13:28
@bussyjdbussyjd mentioned this pull request Jul 15, 2026
6 tasks
@bussyjdbussyjd mentioned this pull request Jul 20, 2026
@bussyjd

Copy link
Copy Markdown
ContributorAuthor

Subsumed by #800 (integration/v0.14.0-rc1) — this change is already folded into rc1 (0 commits not in rc1 by patch-id) and ships in the v0.14.0-rc1 pre-release. Closing to avoid an individual merge forcing an rc1 rebase; the branch is retained.

https://claude.ai/code/session_01PnhCQLz7CHuDBUhWd5xF8v

@bussyjdbussyjd closed this Jul 27, 2026
@bussyjdbussyjd mentioned this pull request Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bussyjd@OisinKyne
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(x402): default 402 challenge resource.url to https on public hosts - #751

Closed
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme
Closed

fix(x402): default 402 challenge resource.url to https on public hosts#751
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme

Conversation

@bussyjd

Copy link
Copy Markdown
Contributor

Summary

What changed: buildResourceURL (the 402 challenge resource.url builder in the verifier's ForwardAuth path) now uses the same scheme resolution as resolveSiteURL: default https, downgrade to http only for hosts the stack serves locally over plain HTTP (obol.stack, loopback, *.localhost/*.local); an explicit https signal (direct TLS or X-Forwarded-Proto: https) still wins for any host. The resolution is extracted into a shared resolveScheme so challenge URLs and 402-page links can never disagree again.

Why it matters: behind a TLS-terminating tunnel the ForwardAuth hop sees plaintext, so the scheme keyed off X-Forwarded-Proto alone renders http:// resource URLs whenever a route lacks the X-Forwarded-Proto: https RequestHeaderModifier. The controller's host-bound so-<name>-host routes carry that filter, but the shared-origin so-<name> routes do not — and being more path-specific for /services/<name>, they win the match even on dedicated-hostname origins. Observed live: 5 of 8 host-bound offers advertised http:// resources in their 402 challenges on https endpoints — a scheme mismatch visible to strict x402 v2 clients and discovery crawlers.

This is the verifier-side half of the correctness gap discussed in #679. It deliberately does NOT force X-Forwarded-Proto: https on shared-origin routes: those also serve genuine local plaintext traffic on obol.stack, where claiming https would be wrong in the other direction.

Risk level: low

Base branch: main

Scope

  • Code

Validation

Unit tests:

go build ./... && go test ./internal/x402/ -count=1 — ok
New TestBuildResourceURL_Scheme: public host no-XFP -> https; public host
XFP=http (tunnel case) -> https; forwarded host honored; obol.stack/localhost
stay http; explicit XFP=https on local host honored; X-Forwarded-Uri preserved.

Live evidence (v0.13.0 deployment behind a Cloudflare tunnel): all 8 host-bound offers' /services/<name> challenges advertised http:// or https:// depending solely on whether a hand-authored route with the header filter happened to match; with trusted forwarded headers (the operator-side workaround) all emit https and a real x402 payment settled end-to-end ($0.01 USDC on Base, exact ledger delta). This patch makes the correct scheme the default with no per-route filters or Traefik trust configuration required.

Refs #679

https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk

buildResourceURL keyed the scheme off X-Forwarded-Proto alone, so behind
a TLS-terminating tunnel (edge https -> plaintext to Traefik -> verifier)
any route without an explicit X-Forwarded-Proto:https RequestHeaderModifier
produced http:// resource URLs in 402 challenges. The controller's
host-bound so-<name>-host routes carry that filter but the shared-origin
so-<name> routes do not — and being more path-specific for
/services/<name>, they win the match even on dedicated-hostname origins,
so challenges on those origins advertised http:// resources on an https
endpoint (strict v2 payment clients and discovery crawlers see a
scheme mismatch; observed live on 5 of 8 host-bound offers, #679).
resolveSiteURL already solved exactly this for 402-page links: default
https, downgrade only for hosts the stack serves locally over plain HTTP
(obol.stack, loopback, *.localhost/*.local), explicit signals always win.
Extract that resolution into resolveScheme and use it in both places, so
challenge resource URLs and page links can never disagree again.
Refs #679
Claude-Session: https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk
@bussyjd
bussyjd requested a review from OisinKyneJuly 15, 2026 13:28
@bussyjdbussyjd mentioned this pull request Jul 15, 2026
6 tasks
@bussyjdbussyjd mentioned this pull request Jul 20, 2026
@bussyjd

Copy link
Copy Markdown
ContributorAuthor

Subsumed by #800 (integration/v0.14.0-rc1) — this change is already folded into rc1 (0 commits not in rc1 by patch-id) and ships in the v0.14.0-rc1 pre-release. Closing to avoid an individual merge forcing an rc1 rebase; the branch is retained.

https://claude.ai/code/session_01PnhCQLz7CHuDBUhWd5xF8v

@bussyjdbussyjd closed this Jul 27, 2026
@bussyjdbussyjd mentioned this pull request Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bussyjd@OisinKyne
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(x402): default 402 challenge resource.url to https on public hosts - #751

Closed
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme
Closed

fix(x402): default 402 challenge resource.url to https on public hosts#751
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme

Conversation

@bussyjd

Copy link
Copy Markdown
Contributor

Summary

What changed: buildResourceURL (the 402 challenge resource.url builder in the verifier's ForwardAuth path) now uses the same scheme resolution as resolveSiteURL: default https, downgrade to http only for hosts the stack serves locally over plain HTTP (obol.stack, loopback, *.localhost/*.local); an explicit https signal (direct TLS or X-Forwarded-Proto: https) still wins for any host. The resolution is extracted into a shared resolveScheme so challenge URLs and 402-page links can never disagree again.

Why it matters: behind a TLS-terminating tunnel the ForwardAuth hop sees plaintext, so the scheme keyed off X-Forwarded-Proto alone renders http:// resource URLs whenever a route lacks the X-Forwarded-Proto: https RequestHeaderModifier. The controller's host-bound so-<name>-host routes carry that filter, but the shared-origin so-<name> routes do not — and being more path-specific for /services/<name>, they win the match even on dedicated-hostname origins. Observed live: 5 of 8 host-bound offers advertised http:// resources in their 402 challenges on https endpoints — a scheme mismatch visible to strict x402 v2 clients and discovery crawlers.

This is the verifier-side half of the correctness gap discussed in #679. It deliberately does NOT force X-Forwarded-Proto: https on shared-origin routes: those also serve genuine local plaintext traffic on obol.stack, where claiming https would be wrong in the other direction.

Risk level: low

Base branch: main

Scope

  • Code

Validation

Unit tests:

go build ./... && go test ./internal/x402/ -count=1 — ok
New TestBuildResourceURL_Scheme: public host no-XFP -> https; public host
XFP=http (tunnel case) -> https; forwarded host honored; obol.stack/localhost
stay http; explicit XFP=https on local host honored; X-Forwarded-Uri preserved.

Live evidence (v0.13.0 deployment behind a Cloudflare tunnel): all 8 host-bound offers' /services/<name> challenges advertised http:// or https:// depending solely on whether a hand-authored route with the header filter happened to match; with trusted forwarded headers (the operator-side workaround) all emit https and a real x402 payment settled end-to-end ($0.01 USDC on Base, exact ledger delta). This patch makes the correct scheme the default with no per-route filters or Traefik trust configuration required.

Refs #679

https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk

buildResourceURL keyed the scheme off X-Forwarded-Proto alone, so behind
a TLS-terminating tunnel (edge https -> plaintext to Traefik -> verifier)
any route without an explicit X-Forwarded-Proto:https RequestHeaderModifier
produced http:// resource URLs in 402 challenges. The controller's
host-bound so-<name>-host routes carry that filter but the shared-origin
so-<name> routes do not — and being more path-specific for
/services/<name>, they win the match even on dedicated-hostname origins,
so challenges on those origins advertised http:// resources on an https
endpoint (strict v2 payment clients and discovery crawlers see a
scheme mismatch; observed live on 5 of 8 host-bound offers, #679).
resolveSiteURL already solved exactly this for 402-page links: default
https, downgrade only for hosts the stack serves locally over plain HTTP
(obol.stack, loopback, *.localhost/*.local), explicit signals always win.
Extract that resolution into resolveScheme and use it in both places, so
challenge resource URLs and page links can never disagree again.
Refs #679
Claude-Session: https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk
@bussyjd
bussyjd requested a review from OisinKyneJuly 15, 2026 13:28
@bussyjdbussyjd mentioned this pull request Jul 15, 2026
6 tasks
@bussyjdbussyjd mentioned this pull request Jul 20, 2026
@bussyjd

Copy link
Copy Markdown
ContributorAuthor

Subsumed by #800 (integration/v0.14.0-rc1) — this change is already folded into rc1 (0 commits not in rc1 by patch-id) and ships in the v0.14.0-rc1 pre-release. Closing to avoid an individual merge forcing an rc1 rebase; the branch is retained.

https://claude.ai/code/session_01PnhCQLz7CHuDBUhWd5xF8v

@bussyjdbussyjd closed this Jul 27, 2026
@bussyjdbussyjd mentioned this pull request Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bussyjd@OisinKyne
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(x402): default 402 challenge resource.url to https on public hosts - #751

Closed
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme
Closed

fix(x402): default 402 challenge resource.url to https on public hosts#751
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme

Conversation

@bussyjd

Copy link
Copy Markdown
Contributor

Summary

What changed: buildResourceURL (the 402 challenge resource.url builder in the verifier's ForwardAuth path) now uses the same scheme resolution as resolveSiteURL: default https, downgrade to http only for hosts the stack serves locally over plain HTTP (obol.stack, loopback, *.localhost/*.local); an explicit https signal (direct TLS or X-Forwarded-Proto: https) still wins for any host. The resolution is extracted into a shared resolveScheme so challenge URLs and 402-page links can never disagree again.

Why it matters: behind a TLS-terminating tunnel the ForwardAuth hop sees plaintext, so the scheme keyed off X-Forwarded-Proto alone renders http:// resource URLs whenever a route lacks the X-Forwarded-Proto: https RequestHeaderModifier. The controller's host-bound so-<name>-host routes carry that filter, but the shared-origin so-<name> routes do not — and being more path-specific for /services/<name>, they win the match even on dedicated-hostname origins. Observed live: 5 of 8 host-bound offers advertised http:// resources in their 402 challenges on https endpoints — a scheme mismatch visible to strict x402 v2 clients and discovery crawlers.

This is the verifier-side half of the correctness gap discussed in #679. It deliberately does NOT force X-Forwarded-Proto: https on shared-origin routes: those also serve genuine local plaintext traffic on obol.stack, where claiming https would be wrong in the other direction.

Risk level: low

Base branch: main

Scope

  • Code

Validation

Unit tests:

go build ./... && go test ./internal/x402/ -count=1 — ok
New TestBuildResourceURL_Scheme: public host no-XFP -> https; public host
XFP=http (tunnel case) -> https; forwarded host honored; obol.stack/localhost
stay http; explicit XFP=https on local host honored; X-Forwarded-Uri preserved.

Live evidence (v0.13.0 deployment behind a Cloudflare tunnel): all 8 host-bound offers' /services/<name> challenges advertised http:// or https:// depending solely on whether a hand-authored route with the header filter happened to match; with trusted forwarded headers (the operator-side workaround) all emit https and a real x402 payment settled end-to-end ($0.01 USDC on Base, exact ledger delta). This patch makes the correct scheme the default with no per-route filters or Traefik trust configuration required.

Refs #679

https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk

buildResourceURL keyed the scheme off X-Forwarded-Proto alone, so behind
a TLS-terminating tunnel (edge https -> plaintext to Traefik -> verifier)
any route without an explicit X-Forwarded-Proto:https RequestHeaderModifier
produced http:// resource URLs in 402 challenges. The controller's
host-bound so-<name>-host routes carry that filter but the shared-origin
so-<name> routes do not — and being more path-specific for
/services/<name>, they win the match even on dedicated-hostname origins,
so challenges on those origins advertised http:// resources on an https
endpoint (strict v2 payment clients and discovery crawlers see a
scheme mismatch; observed live on 5 of 8 host-bound offers, #679).
resolveSiteURL already solved exactly this for 402-page links: default
https, downgrade only for hosts the stack serves locally over plain HTTP
(obol.stack, loopback, *.localhost/*.local), explicit signals always win.
Extract that resolution into resolveScheme and use it in both places, so
challenge resource URLs and page links can never disagree again.
Refs #679
Claude-Session: https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk
@bussyjd
bussyjd requested a review from OisinKyneJuly 15, 2026 13:28
@bussyjdbussyjd mentioned this pull request Jul 15, 2026
6 tasks
@bussyjdbussyjd mentioned this pull request Jul 20, 2026
@bussyjd

Copy link
Copy Markdown
ContributorAuthor

Subsumed by #800 (integration/v0.14.0-rc1) — this change is already folded into rc1 (0 commits not in rc1 by patch-id) and ships in the v0.14.0-rc1 pre-release. Closing to avoid an individual merge forcing an rc1 rebase; the branch is retained.

https://claude.ai/code/session_01PnhCQLz7CHuDBUhWd5xF8v

@bussyjdbussyjd closed this Jul 27, 2026
@bussyjdbussyjd mentioned this pull request Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bussyjd@OisinKyne
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(x402): default 402 challenge resource.url to https on public hosts - #751

Closed
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme
Closed

fix(x402): default 402 challenge resource.url to https on public hosts#751
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme

Conversation

@bussyjd

Copy link
Copy Markdown
Contributor

Summary

What changed: buildResourceURL (the 402 challenge resource.url builder in the verifier's ForwardAuth path) now uses the same scheme resolution as resolveSiteURL: default https, downgrade to http only for hosts the stack serves locally over plain HTTP (obol.stack, loopback, *.localhost/*.local); an explicit https signal (direct TLS or X-Forwarded-Proto: https) still wins for any host. The resolution is extracted into a shared resolveScheme so challenge URLs and 402-page links can never disagree again.

Why it matters: behind a TLS-terminating tunnel the ForwardAuth hop sees plaintext, so the scheme keyed off X-Forwarded-Proto alone renders http:// resource URLs whenever a route lacks the X-Forwarded-Proto: https RequestHeaderModifier. The controller's host-bound so-<name>-host routes carry that filter, but the shared-origin so-<name> routes do not — and being more path-specific for /services/<name>, they win the match even on dedicated-hostname origins. Observed live: 5 of 8 host-bound offers advertised http:// resources in their 402 challenges on https endpoints — a scheme mismatch visible to strict x402 v2 clients and discovery crawlers.

This is the verifier-side half of the correctness gap discussed in #679. It deliberately does NOT force X-Forwarded-Proto: https on shared-origin routes: those also serve genuine local plaintext traffic on obol.stack, where claiming https would be wrong in the other direction.

Risk level: low

Base branch: main

Scope

  • Code

Validation

Unit tests:

go build ./... && go test ./internal/x402/ -count=1 — ok
New TestBuildResourceURL_Scheme: public host no-XFP -> https; public host
XFP=http (tunnel case) -> https; forwarded host honored; obol.stack/localhost
stay http; explicit XFP=https on local host honored; X-Forwarded-Uri preserved.

Live evidence (v0.13.0 deployment behind a Cloudflare tunnel): all 8 host-bound offers' /services/<name> challenges advertised http:// or https:// depending solely on whether a hand-authored route with the header filter happened to match; with trusted forwarded headers (the operator-side workaround) all emit https and a real x402 payment settled end-to-end ($0.01 USDC on Base, exact ledger delta). This patch makes the correct scheme the default with no per-route filters or Traefik trust configuration required.

Refs #679

https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk

buildResourceURL keyed the scheme off X-Forwarded-Proto alone, so behind
a TLS-terminating tunnel (edge https -> plaintext to Traefik -> verifier)
any route without an explicit X-Forwarded-Proto:https RequestHeaderModifier
produced http:// resource URLs in 402 challenges. The controller's
host-bound so-<name>-host routes carry that filter but the shared-origin
so-<name> routes do not — and being more path-specific for
/services/<name>, they win the match even on dedicated-hostname origins,
so challenges on those origins advertised http:// resources on an https
endpoint (strict v2 payment clients and discovery crawlers see a
scheme mismatch; observed live on 5 of 8 host-bound offers, #679).
resolveSiteURL already solved exactly this for 402-page links: default
https, downgrade only for hosts the stack serves locally over plain HTTP
(obol.stack, loopback, *.localhost/*.local), explicit signals always win.
Extract that resolution into resolveScheme and use it in both places, so
challenge resource URLs and page links can never disagree again.
Refs #679
Claude-Session: https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk
@bussyjd
bussyjd requested a review from OisinKyneJuly 15, 2026 13:28
@bussyjdbussyjd mentioned this pull request Jul 15, 2026
6 tasks
@bussyjdbussyjd mentioned this pull request Jul 20, 2026
@bussyjd

Copy link
Copy Markdown
ContributorAuthor

Subsumed by #800 (integration/v0.14.0-rc1) — this change is already folded into rc1 (0 commits not in rc1 by patch-id) and ships in the v0.14.0-rc1 pre-release. Closing to avoid an individual merge forcing an rc1 rebase; the branch is retained.

https://claude.ai/code/session_01PnhCQLz7CHuDBUhWd5xF8v

@bussyjdbussyjd closed this Jul 27, 2026
@bussyjdbussyjd mentioned this pull request Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bussyjd@OisinKyne
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(x402): default 402 challenge resource.url to https on public hosts - #751

Closed
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme
Closed

fix(x402): default 402 challenge resource.url to https on public hosts#751
bussyjd wants to merge 1 commit into
mainfrom
fix/x402-challenge-url-scheme

Conversation

@bussyjd

Copy link
Copy Markdown
Contributor

Summary

What changed: buildResourceURL (the 402 challenge resource.url builder in the verifier's ForwardAuth path) now uses the same scheme resolution as resolveSiteURL: default https, downgrade to http only for hosts the stack serves locally over plain HTTP (obol.stack, loopback, *.localhost/*.local); an explicit https signal (direct TLS or X-Forwarded-Proto: https) still wins for any host. The resolution is extracted into a shared resolveScheme so challenge URLs and 402-page links can never disagree again.

Why it matters: behind a TLS-terminating tunnel the ForwardAuth hop sees plaintext, so the scheme keyed off X-Forwarded-Proto alone renders http:// resource URLs whenever a route lacks the X-Forwarded-Proto: https RequestHeaderModifier. The controller's host-bound so-<name>-host routes carry that filter, but the shared-origin so-<name> routes do not — and being more path-specific for /services/<name>, they win the match even on dedicated-hostname origins. Observed live: 5 of 8 host-bound offers advertised http:// resources in their 402 challenges on https endpoints — a scheme mismatch visible to strict x402 v2 clients and discovery crawlers.

This is the verifier-side half of the correctness gap discussed in #679. It deliberately does NOT force X-Forwarded-Proto: https on shared-origin routes: those also serve genuine local plaintext traffic on obol.stack, where claiming https would be wrong in the other direction.

Risk level: low

Base branch: main

Scope

  • Code

Validation

Unit tests:

go build ./... && go test ./internal/x402/ -count=1 — ok
New TestBuildResourceURL_Scheme: public host no-XFP -> https; public host
XFP=http (tunnel case) -> https; forwarded host honored; obol.stack/localhost
stay http; explicit XFP=https on local host honored; X-Forwarded-Uri preserved.

Live evidence (v0.13.0 deployment behind a Cloudflare tunnel): all 8 host-bound offers' /services/<name> challenges advertised http:// or https:// depending solely on whether a hand-authored route with the header filter happened to match; with trusted forwarded headers (the operator-side workaround) all emit https and a real x402 payment settled end-to-end ($0.01 USDC on Base, exact ledger delta). This patch makes the correct scheme the default with no per-route filters or Traefik trust configuration required.

Refs #679

https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk

buildResourceURL keyed the scheme off X-Forwarded-Proto alone, so behind
a TLS-terminating tunnel (edge https -> plaintext to Traefik -> verifier)
any route without an explicit X-Forwarded-Proto:https RequestHeaderModifier
produced http:// resource URLs in 402 challenges. The controller's
host-bound so-<name>-host routes carry that filter but the shared-origin
so-<name> routes do not — and being more path-specific for
/services/<name>, they win the match even on dedicated-hostname origins,
so challenges on those origins advertised http:// resources on an https
endpoint (strict v2 payment clients and discovery crawlers see a
scheme mismatch; observed live on 5 of 8 host-bound offers, #679).
resolveSiteURL already solved exactly this for 402-page links: default
https, downgrade only for hosts the stack serves locally over plain HTTP
(obol.stack, loopback, *.localhost/*.local), explicit signals always win.
Extract that resolution into resolveScheme and use it in both places, so
challenge resource URLs and page links can never disagree again.
Refs #679
Claude-Session: https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk
@bussyjd
bussyjd requested a review from OisinKyneJuly 15, 2026 13:28
@bussyjdbussyjd mentioned this pull request Jul 15, 2026
6 tasks
@bussyjdbussyjd mentioned this pull request Jul 20, 2026
@bussyjd

Copy link
Copy Markdown
ContributorAuthor

Subsumed by #800 (integration/v0.14.0-rc1) — this change is already folded into rc1 (0 commits not in rc1 by patch-id) and ships in the v0.14.0-rc1 pre-release. Closing to avoid an individual merge forcing an rc1 rebase; the branch is retained.

https://claude.ai/code/session_01PnhCQLz7CHuDBUhWd5xF8v

@bussyjdbussyjd closed this Jul 27, 2026
@bussyjdbussyjd mentioned this pull request Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bussyjd@OisinKyne