Uh oh!
There was an error while loading. Please reload this page.
Implicit conversions - #4
Merged
Merged
Conversation
…gling ptr, reject throws/async inits, validate generic reqs, preserve toType optionals, use allowMissing=false Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/7c4497a9-233d-4f7b-ba21-fb1616a43c6b Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
…k keeping NSString alive Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/8c169c2f-6d75-44d8-b9e1-4080d4638457 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/c83eb791-79bd-401b-a010-d30571a4655a Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
…fix salvage crash Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/17e202b5-2f54-436e-a047-ca10d725541d Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
…y matchTypes path Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/b378e1c3-cd36-44bd-b8bf-fc05e94a257c Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
…o primary matchTypes path" This reverts commit 23b91b0.
…() block in repairFailures() Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/d283ea56-dce6-40ba-8907-9149e4ad7499 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
…ype key) Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/30a70497-c47f-4dfc-bb05-80fab8316772 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
…er-fromType key)" This reverts commit c296b8b.
Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/387847ae-7823-45c1-983d-4efaeac343cb Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
… generic inits at build time Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/99d17287-ef42-4036-bfd4-16b73a2694b8 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
Remove the byNominal/fallback candidate-list cache and
getImplicitConversionInits() entirely. Instead, memoize the final
result of getImplicitConversion() on the toType nominal, keyed by
the canonical fromType (before optional stripping).
- NominalTypeDecl now has a single ImplicitConversionResultCache
(DenseMap<CanType, pair<ConstructorDecl*, CanType>>) with
getCachedImplicitConversion() / setCachedImplicitConversion().
- getImplicitConversion() does a direct member scan on cache miss
and stores {ctor, resolvedToType} (or {nullptr, {}} for no match).
allCandidates collected during scan replaces the old
getImplicitConversionInits() call in the duplicate warning.
Net: -39 lines across 3 files.
Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/df4d4444-d566-4dd7-9a39-c48bba2c138a
Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>…etection, locatorOK reorder, boundForward optional priority, Darwin import, remove UserInaccessible Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/d2fa92ba-cc8e-4c69-b716-2f74f61fcfee Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
…es; restore UserInaccessible on @implicit Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/9a4a4c15-192b-4db5-90b5-0ebe0cbb0386 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/9a4a4c15-192b-4db5-90b5-0ebe0cbb0386 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
…itConversion Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/57c597dd-a81c-473c-a582-6edf57a1a9ea Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/a43a250e-350c-4586-9013-7135c15549f2 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
…etImplicitConversion" This reverts commit f14be45.
…ect/swift into implicit-conversions
…r constrained extensions Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/f72a2d80-733b-4928-a666-4e11e952ab9b Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
… causing coerceToType abort Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/0b4510eb-6b0b-424d-a750-68e921513d95 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/49fb7ecd-d22b-4328-b44e-e21aac54e660 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/f6d9fb7d-d744-448a-abd6-ef8127f40260 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/f6d9fb7d-d744-448a-abd6-ef8127f40260 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/f6d9fb7d-d744-448a-abd6-ef8127f40260 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/f6d9fb7d-d744-448a-abd6-ef8127f40260 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/f6d9fb7d-d744-448a-abd6-ef8127f40260 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ObservedObject/swift/sessions/7e94912e-5605-47a0-9497-bcf4d9055294 Co-authored-by: johnno1962 <1786033+johnno1962@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.