Backend refactor qt - #5
Conversation
There was a problem hiding this comment.
This is going to be subtle to get right because some versions of pyqt do not user super and some do. This will probably need some conditional logic based on pyqt version.
There was a problem hiding this comment.
Ahh, thanks for the heads-up. I think see the problem. It works fine so long as we don't extend WindowQt5 and then super will break... just found the perfect solution to this, just returned to the article I began reading the other day, and they have the solution.
https://rhettinger.wordpress.com/2011/05/26/super-considered-super/ (see How to Incorporate a Non-cooperative Class). As far as I can see, we can apply the adapter pattern directly in qt_compat.py.
Anyway, will look into this deeper once we have the main MEP27 branch merged and turn our focus onto the individual backends.
P.S. Sorry for the delay, turning email notifications off for PRs where I haven't had a mention seems to also not email about me about PRs...
Vetter checks for python and IPython
620efb9 to
d842ee8Compared842ee8 to
f857f7bComparee7290fe to
64f0c61Compare
No description provided.