Uh oh!
There was an error while loading. Please reload this page.
Fix convertToSingleHost to use execFile - #516
Open
Zheng (zhngx1) wants to merge 2 commits into
Open
Conversation
Darren Miller (millerds)
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the
convertToSingleHost.jsconversion script against command injection and updates dependencies to resolvenpm auditvulnerabilities.Changes
childProcess.exec(shell string) withchildProcess.execFile(process.execPath, ...)when invokingoffice-addin-manifest modify. The manifest CLI is now resolved viarequire.resolve("office-addin-manifest/cli.js")and arguments are passed as an array withshell: false, so the project name and app ID are no longer interpolated into a shell command line.