Uh oh!
There was an error while loading. Please reload this page.
issue #580 : support for configured TLS and cipherSuites - #628
issue #580 : support for configured TLS and cipherSuites#628Krishnadas Menon (pheenomenon) wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@## master #628 +/- ##
============================================
+ Coverage 10.43% 10.43% +<.01% - Complexity 0 471 +471
============================================
Files 550 550 Lines 20436 20444 +8 Branches 2626 2084 -542 ============================================
+ Hits 2132 2134 +2 - Misses 18151 18155 +4 - Partials 153 155 +2
Continue to review full report at Codecov.
|
Krishnadas Menon (pheenomenon)
commented
Aug 21, 2017
André (@serious6)Vladislav Bauer (@vbauer) wondering if you had some feedback on this fix. |
97461d9 to
de58c02CompareKrishnadas Menon (pheenomenon)
commented
Aug 22, 2017
André (@serious6)Vladislav Bauer (@vbauer)Victor Boctor (@vboctor) I have squashed the separate checkins to a single one. Please let me know if you recommend anything more on this. |
Krishnadas Menon (pheenomenon)
commented
Aug 30, 2017
Hello experts, André (@serious6)Vladislav Bauer (@vbauer)Victor Boctor (@vboctor) any inputs here will be appreciated. |
Krishnadas Menon (pheenomenon)
commented
Sep 5, 2017
Hello experts, André (@serious6)Vladislav Bauer (@vbauer)Victor Boctor (@vboctor) any inputs on when you guys plan to release the latest build. |
2 similar comments
Krishnadas Menon (pheenomenon)
commented
Sep 6, 2017
Hello experts, André (@serious6)Vladislav Bauer (@vbauer)Victor Boctor (@vboctor) any inputs on when you guys plan to release the latest build. |
Krishnadas Menon (pheenomenon)
commented
Sep 7, 2017
Hello experts, André (@serious6)Vladislav Bauer (@vbauer)Victor Boctor (@vboctor) any inputs on when you guys plan to release the latest build. |
Kenton Gray (kentongray)
commented
Nov 10, 2017
so sad having such great prs go unnoticed, can you please allow a 3rd party maintainer |
This fix is for #580
This PR has fix as per #2 below.
Few options to fix this are:
1] stop setting ConnectionManager and set useSystemProperties() while building HttpClients, in which case HttpClientBuilder will invoke the code to read systemProperties.
reuseStrategyCopy = new SSLConnectionSocketFactory((SSLSocketFactory)SSLSocketFactory.getDefault(), keepAliveStrategyCopy, targetAuthStrategyCopy, (HostnameVerifier)proxyAuthStrategyCopy);
2] Another approach is to update EwsSSLProtocolSocketFactory.build() to support the call to SSLConnectionSocketFactory constructor using SSL protocol and cipherSuite.