Skip to content

feat: Add favicon to website - #139

Open
Joshua-Nweze wants to merge 17 commits into
One-Language:mainfrom
Joshua-Nweze:Add_favicon
Open

feat: Add favicon to website#139
Joshua-Nweze wants to merge 17 commits into
One-Language:mainfrom
Joshua-Nweze:Add_favicon

Conversation

@Joshua-Nweze

@Joshua-NwezeJoshua-Nweze commented Oct 27, 2022

Copy link
Copy Markdown

No description provided.

jbampton
jbampton requested changes Oct 28, 2022
View reviewed changes

@jbamptonjbampton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://favicon.io/

https://www.favicon-generator.org/

@jbamptonjbampton self-assigned this Oct 28, 2022
@jbamptonjbampton added enhancement New feature or request good first issue Good for newcomers labels Oct 28, 2022
@Joshua-Nweze

Joshua-Nweze commented Oct 28, 2022 via email

Copy link
Copy Markdown
Author

jbampton
jbampton requested changes Oct 28, 2022
View reviewed changes

@jbamptonjbampton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a link in the HTML head to the web app manifest

https://stackoverflow.com/questions/62122552/do-i-need-to-place-the-manifest-json-file-at-the-root-of-my-webserver#62122707

jbampton
jbampton reviewed Oct 28, 2022
View reviewed changes
Comment threadassets/images/site.webmanifest Outdated
Joshua-Nweze
Joshua-Nweze commented Oct 28, 2022
View reviewed changes

@Joshua-NwezeJoshua-Nweze left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous and updated codes are the same

jbampton
jbampton reviewed Oct 28, 2022
View reviewed changes
Comment threadassets/images/site.webmanifest Outdated
jbampton
jbampton requested changes Oct 28, 2022
View reviewed changes

@jbamptonjbampton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file "src" paths in the site.webmanifest are wrong.

Perhaps we need relative links.

You should be testing all this work on your local machine.

jbampton
jbampton requested changes Oct 31, 2022
View reviewed changes

@jbamptonjbampton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint / Run pre-commit (pull_request) Failing after 9s

jbampton
jbampton reviewed Feb 7, 2023
View reviewed changes
Comment threadindex.html
jbampton
jbampton reviewed Jun 21, 2023
View reviewed changes

@jbamptonjbampton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the favicons could be better ?

We have some new one

@jbampton

jbampton commented Jun 21, 2023

Copy link
Copy Markdown
Member

One Language Logo Square

@BaseMax

BaseMax commented Oct 18, 2023

Copy link
Copy Markdown
Member

cc @jbampton

@BaseMax

BaseMax commented Jan 15, 2024

Copy link
Copy Markdown
Member

merge or close?

@BaseMax

BaseMax commented Aug 15, 2024

Copy link
Copy Markdown
Member

?

@BaseMax

BaseMax commented Dec 16, 2024

Copy link
Copy Markdown
Member

update

@BaseMax

BaseMax commented Jan 20, 2025

Copy link
Copy Markdown
Member

This branch is out-of-date with the base branch
Merge the latest changes from main into this branch.
This merge commit will be associated with MaxBaseCode@Gmail.Com.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbamptonjbamptonjbampton requested changes
@BaseMaxBaseMaxAwaiting requested review from BaseMaxBaseMax is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@jbamptonjbampton

Labels

enhancementNew feature or requestgood first issueGood for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Joshua-Nweze@jbampton@BaseMax