fix '$env:TEMP' path resolving issue

[Artem (GreatTeacherBasshead)]

$env:TEMP can be resolved to DOS-style path like 'C:\Users\ARZZ~1.BOK\AppData\Local\Temp', and then after Join-Path the resulting literal path is invalid.
If you Test-Path $script:location_modules, you get false in this case.
It causes that remove-item in line 334 fails the installation.

[Craig D Wilhite (cwilhit)]

I am unable to repro this. I tested by joining a DOS-style path with another path, and Test-Path is able to correctly detect whether the path exists or not.

[Artem (GreatTeacherBasshead)]

Ok... My bad. Test-Path works, but Remove-Item does not:

[Craig D Wilhite (cwilhit)]

What version of Windows and PowerShell are you using? I can't get this to repro (follwed the instructions above).

[Artem (GreatTeacherBasshead)]

I have it both on Windows Server 2016 and 2019.
Windows PowerShell 5.1

I think the problem is in the user name. Try to test it for a user, who has a dot in the name, like I showed.

[Steve Brown (shoddyguard)]

FYI I'm experiencing the $env:TEMP bug as noted in #71
I believe Artem (@GreatTeacherBasshead) is correct as my user account also has a . in it.