Skip to content

Fix broken failure telemetry: restore Clipper.logger assignment#657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eric Chen (wikirby) merged 1 commit into from
May 12, 2026
Merged

Fix broken failure telemetry: restore Clipper.logger assignment #657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/scripts/extensions/extensionBase.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import {Constants} from "../constants";
import {StringUtils} from "../stringUtils";
import {UrlUtils} from "../urlUtils";

import {Clipper} from "../clipperUI/frontEndGlobals";
import {TooltipType} from "../clipperUI/tooltipType";

import {SmartValue} from "../communicator/smartValue";
Expand DownExpand Up@@ -48,6 +49,9 @@ export abstract class ExtensionBase<TWorker extends ExtensionWorkerBase<TTab, TT

this.workers = [];
this.logger = new WorkerPassthroughLogger(this.workers);
// Module-level callers (Log.ErrorUtils.sendFailureLogRequest, userDataBoundaryHelper)
// reach for this static slot since they have no `this` to hold a logger on.
Clipper.logger = this.logger;
ExtensionBase.extensionId = StringUtils.generateGuid();

this.clipperData = clipperData;
Expand Down
Loading