Uh oh!
There was an error while loading. Please reload this page.
Dev pnn pr - #340
Open
BakerMara wants to merge 9 commits into
Open
Conversation
| pnn_train_eval.py \ | ||
| --data_dir $DATA_DIR \ | ||
| --persistent_path $PERSISTENT_PATH \ | ||
| --table_size_array "43, 98, 121, 41, 219, 112, 79, 68, 91, 5, 26, 36, 70, 1447, 554, 157461, 117683, 305, 17, 11878, 629, 4, 39504, 5128, 156729, 3175, 27, 11070, 149083, 11, 4542, 1996, 4, 154737, 17, 16, 52989, 81, 40882" \ |
Contributor
There was a problem hiding this comment.
| pnn_train_eval.py \ | ||
| --data_dir $DATA_DIR \ | ||
| --persistent_path $PERSISTENT_PATH \ | ||
| --table_size_array "43, 98, 121, 41, 219, 112, 79, 68, 91, 5, 26, 36, 70, 1447, 554, 157461, 117683, 305, 17, 11878, 629, 4, 39504, 5128, 156729, 3175, 27, 11070, 149083, 11, 4542, 1996, 4, 154737, 17, 16, 52989, 81, 40882" \ |
| return self.one_embedding.forward(ids) | ||
| class DenseLayer(nn.Module): |
| one_embedding_store_type="cached_host_mem", | ||
| cache_memory_budget_mb=8192, | ||
| interaction_type="dot", | ||
| interaction_itself=False, |
| self.input_dim = embedding_vec_size * self.fields | ||
| if self.use_inner: | ||
| self.input_dim += sum(range(self.fields)) | ||
| self.inner_product_layer = InnerProductLayer( |
Contributor
There was a problem hiding this comment.
similar with
https://github.com/Oneflow-Inc/models/blob/main/RecommenderSystems/dlrm/dlrm_train_eval.py#L236
output_concat = None
ShawnXuan
requested changes
May 30, 2022
| I = self.inner_product_layer(E) | ||
| if self.use_outter: | ||
| O = self.outter_product_layer( | ||
| E.reshape(self.fields, -1, 1, self.embedding_vec_size) |
Contributor
There was a problem hiding this comment.
what is the purpose of reshape here???
ContributorAuthor
There was a problem hiding this comment.
E的形状本来是（b, fields, embedding_vec_size）, reshape之后是（fields， b, 1, embedding_vec_size）。为了传入opnn网络进行训练。
ShawnXuan
requested changes
May 30, 2022
ShawnXuan
left a comment
Contributor
There was a problem hiding this comment.
suggest to keep IPNN only currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.