Uh oh!
There was an error while loading. Please reload this page.
fix(types): make RetrievalResult.score Optional[float] to match API null return - #27
Merged
Merged
Conversation
…ull return The agentic retrieval route now returns null for score when no real score is available (navigation-only chunks). Previously the SDK model declared score as float which would fail Pydantic validation on null. score: float → Optional[float] = None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the Python SDK's
RetrievalResultmodel with the updated API contract.Background
The API's agentic retrieval route (
/v1/retrieval/query) now returnsnullforscoreon chunks that were found only through KG navigation (no BM25 discovery score available). Previously the API hardcoded1.0as a placeholder, which was misleading.Change
Nonemeans 'no score available'. Consumers should treat it as unranked rather than assuming high relevance.Testing
pytest tests/test_retrieval.py✅nulland numeric values from the API response