Skip to content

test: pin the TypeScript test runner instead of downloading it at runtime #805

Description

@appergb

Audit finding

check:hotkey-side-modifiers runs npx tsx ..., but tsx is not a direct devDependency and no local binary exists after npm ci. The check therefore downloads the current registry version during execution, bypassing the project lockfile and making offline/CI runs non-reproducible. The tsx entry currently visible in package-lock.json is only Vite optional peer metadata, not an installed dependency.

Acceptance criteria

  • Add tsx as a pinned/locked devDependency and invoke the local npm-script binary.
  • The check works after a clean npm ci with network disabled for the test command.
  • Existing frontend tests/build pass.
  • No product/UI behavior change.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Medium prioritybugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions