Skip to content

fix(updater): revert signing pubkey to 1DEAA803 to repair auto-update - #705

Merged
appergb merged 1 commit into
betafrom
fix/updater-revert-signing-key
Jun 17, 2026
Merged

fix(updater): revert signing pubkey to 1DEAA803 to repair auto-update#705
appergb merged 1 commit into
betafrom
fix/updater-revert-signing-key

Conversation

@appergb

@appergbappergb commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

User description

Problem

Desktop and Android auto-update are broken on all platforms: "click update → download finishes → never installs."

The download is a plain HTTP GET (always succeeds). The signature is verified inside install() against the app's embedded updater pubkey. Since aaf4ccc the embedded desktop pubkey is 6F4B5994…, but:

  • shipped 1.3.8 stable users (the live base) embed/trust 1DEAA803…;
  • the CI signing key produces 1DEAA803…-signed artifacts;
  • android/updater.rs already hardcodes 1DEAA803….

So any installed app verifying against 1DEAA803 rejects a 6F4B5994-signed package → install fails after a successful download. (Conversely, Android signs-with vs verifies-against were mismatched, so Android updates failed outright.)

Fix

Revert the desktop updater pubkey in tauri.conf.json to 1DEAA803…, so desktop + Android + the CI signing secret all agree on one key. One line, no logic change.

- "pubkey": "…6F4B5994F33394A9…"+ "pubkey": "…1DEAA803564C323F…"

Verification

  • Decoded keyIDs: tauri.conf.json and android/updater.rs now both = 1DEAA803564C323F.
  • Signed a probe file with the CI signing key → signature keyID = 1DEAA803564C323F (matches).
  • No remaining 6F4B5994 references in the repo.

Compatibility

  • 1.3.8 stable users (embed 1DEAA803) → can now verify & install the next release.
  • Users currently on a 6F4B5994-embedded build (recent betas) must reinstall once to re-align — unavoidable across any key change; Tauri trusts a single embedded key.

Base: beta.


PR Type

Bug fix


Description

  • Revert updater pubkey to 1DEAA803

  • Fixes broken auto-update on desktop and Android


File Walkthrough

Relevant files
Bug fix
tauri.conf.json
Revert updater pubkey

openless-all/app/src-tauri/tauri.conf.json

  • Reverted updater pubkey from 6F4B5994 to 1DEAA803 to match CI signing
    key and Android updater
+1/-1

Auto-update was broken on every platform: builds since aaf4ccc embed pubkey
6F4B5994, but shipped 1.3.8 stable users trust 1DEAA803 and CI now signs with
1DEAA803 again. A key the installed app doesn't trust => download succeeds,
install() signature verification fails => "downloads but never updates".
Revert the desktop updater pubkey to 1DEAA803 so it matches both the CI
signing key and android/updater.rs (which already hardcodes 1DEAA803). This
also repairs Android auto-update, which was signing-vs-verifying mismatched.
One line, no logic change.
@github-actions

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@appergb
appergb merged commit 6c99ddf into betaJun 17, 2026
5 checks passed
appergb added a commit that referenced this pull request Jun 19, 2026
合并 #704(安卓应用内自动更新 + JNI 修复)并把 PC updater 修复同步到安卓:①安卓公钥回退 6F4B5994→1DEAA803(同步#705)②installError 安装失败兜底+去 throw(同步#708)③还原被自动合并误删的桌面 logClientError。桌面机制零变更。CI 全绿 + @claude 审核通过。取代 #704#694 安卓部分。
@appergb
appergb deleted the fix/updater-revert-signing-key branch September 9, 2026 05:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@appergb