Uh oh!
There was an error while loading. Please reload this page.
Conversation
jimschubert
approved these changes
May 12, 2018
| <module>samples/client/petstore/groovy</module> | ||
| <module>samples/client/petstore/rust</module> | ||
| <module>samples/client/petstore/perl</module> | ||
| <!--<module>samples/client/petstore/perl</module>--> |
Member
There was a problem hiding this comment.
Should this pom match the circlci poms? The go client is commented there and perl is commented here.
MemberAuthor
There was a problem hiding this comment.
Good question but they should not be the same as different CIs should test different clients/servers.
wing328
commented
May 12, 2018
MemberAuthor
The issues reported by CircleCI will be handled in another PR. |
wing328 pushed a commit
that referenced
this pull request
May 28, 2018
* Make SwaggerCodeGen serialize subclasses properly (PHNX-859) (#1) Motivation ---- Previously, when serializing as subclass of a property, generated swagger clients would only serialize properties of the parent class causing some values to not be pass through Modifications ---- Before serializing attributes of a given type, we check to see if there is a specific type to be serialized so that we don't miss any properties. * Fix improper whitespace in mustache template (PHNX-859) (#2) Motivation ---- OpenAPI Generator upstream requested whitespace fixes (from tabs to 4 spaces) Modifications ---- Fixed whitespace
4 tasks
wing328 pushed a commit
that referenced
this pull request
Aug 27, 2018
* Kotlin Spring initial bootstrap * Basic configuration construction for Kotlin Spring * Wired up with comand line client * Initial kotlin spring boot application generated using gradle kotlin-dsl * Added basic support for generating models * Basic controllers generated without endpoints generated * Basic spring boot app generated with models and controllers * Added fix for type mapping in AbstractKotlinCodegen. Originally it was mapping list o kotlin.Array instead of kotlin.collections.List * Fixed return type mapping * Sorted bash springboot petstore generator script * Implemented toVarName in AbstractKotlinCodegen to better handle some edgecases * Checking for reserved words or numerical starting class names in AbstractKotlinCodegen * Implemented toOperationId in AbstractKotlinCodegen * Fixed types that were not correctly being mapped to primitives (byte / arrayOf / mapOf) * Escaping dollar symbols in function names * Added support for outter enum classes * Added basic support for generating services * Removed option for generated config package. Added option to enable/disable generated global exception handler * Added configuration option to generate gradle. Generated maven pom.xml file as default * Fixed up bash scripts for generating test sample code * Added configurable option for Swagger Annotations * Added configurable option for generating service interfaces and service implementations * Added README generation * Enable optional bean validation * Added kotlin spring sample to CircleCI pom.xml * Removed kotlin spring boot from .gitignore * Minor fixes from PR comments for user submission (#1) * Minor fixes from PR comments for user submission * Puts braces around conditional block bodies with one-liner bodies. * Modifies README.mustache to use artifact id and version supplied by user (or default configuration) * Targets templates under resource directory explicitly to prevent the need to rebuild for evaluation of template-only changes. * [kotlin-spring] Remove comments referencing sbt in bash scripts * List of changes based upon code review: * Additional comments around how we set the title based off the open api spec * Fixed missing `beanValidationCore` template * Put the lambdas into the lambda object as other generators do (Ktor, C#, cpp) * Bump swagger-annotations version to latest pre-2.0 version (1.5.21) * Set kotlin version to 1.2.60 * Updated README to set port based on template * Added more additional properties to build bash scripts * Removed `defaultBasePath.mustache` in place of using {{contextPath}} directly * Log warning for when `serviceImplementation` is set t o true * Updated samples * Generating ConstraintViolation Exception Handler, as Springboot doesnt correctly catch the error and return bad request. Handling other exceptions a litle better * Small fix for date time mappings (plus sample re-gen) * Minor fix in README template, where port was using wrong variable * Fix missing jackson-dataformat-xml dependency * Fix build - needed to re-run kotlin-server-petstore.sh * Fixes after merge with master * Revert "Small fix for date time mappings (plus sample re-gen)" This reverts commit 4152dc78b4813da71c675272ca90fb31a333aea1. * Moved type mappings to Kotlin Spring generator * Regenerated samples * Regenerated samples
wing328 pushed a commit
that referenced
this pull request
Jan 25, 2019
Bring my fork up to date with base
A-Joshi referenced
this pull request
in ihsmarkitoss/openapi-generator
Feb 27, 2019
* Kotlin Spring initial bootstrap * Basic configuration construction for Kotlin Spring * Wired up with comand line client * Initial kotlin spring boot application generated using gradle kotlin-dsl * Added basic support for generating models * Basic controllers generated without endpoints generated * Basic spring boot app generated with models and controllers * Added fix for type mapping in AbstractKotlinCodegen. Originally it was mapping list o kotlin.Array instead of kotlin.collections.List * Fixed return type mapping * Sorted bash springboot petstore generator script * Implemented toVarName in AbstractKotlinCodegen to better handle some edgecases * Checking for reserved words or numerical starting class names in AbstractKotlinCodegen * Implemented toOperationId in AbstractKotlinCodegen * Fixed types that were not correctly being mapped to primitives (byte / arrayOf / mapOf) * Escaping dollar symbols in function names * Added support for outter enum classes * Added basic support for generating services * Removed option for generated config package. Added option to enable/disable generated global exception handler * Added configuration option to generate gradle. Generated maven pom.xml file as default * Fixed up bash scripts for generating test sample code * Added configurable option for Swagger Annotations * Added configurable option for generating service interfaces and service implementations * Added README generation * Enable optional bean validation * Added kotlin spring sample to CircleCI pom.xml * Removed kotlin spring boot from .gitignore * Minor fixes from PR comments for user submission (#1) * Minor fixes from PR comments for user submission * Puts braces around conditional block bodies with one-liner bodies. * Modifies README.mustache to use artifact id and version supplied by user (or default configuration) * Targets templates under resource directory explicitly to prevent the need to rebuild for evaluation of template-only changes. * [kotlin-spring] Remove comments referencing sbt in bash scripts * List of changes based upon code review: * Additional comments around how we set the title based off the open api spec * Fixed missing `beanValidationCore` template * Put the lambdas into the lambda object as other generators do (Ktor, C#, cpp) * Bump swagger-annotations version to latest pre-2.0 version (1.5.21) * Set kotlin version to 1.2.60 * Updated README to set port based on template * Added more additional properties to build bash scripts * Removed `defaultBasePath.mustache` in place of using {{contextPath}} directly * Log warning for when `serviceImplementation` is set t o true * Updated samples * Generating ConstraintViolation Exception Handler, as Springboot doesnt correctly catch the error and return bad request. Handling other exceptions a litle better * Small fix for date time mappings (plus sample re-gen) * Minor fix in README template, where port was using wrong variable * Fix missing jackson-dataformat-xml dependency * Fix build - needed to re-run kotlin-server-petstore.sh * Fixes after merge with master * Revert "Small fix for date time mappings (plus sample re-gen)" This reverts commit 4152dc78b4813da71c675272ca90fb31a333aea1. * Moved type mappings to Kotlin Spring generator * Regenerated samples * Regenerated samples
turkeylurkey pushed a commit
to turkeylurkey/openapi-generator
that referenced
this pull request
Nov 14, 2019
* Create JavaMicroprofile generator * Add ApiException and ApiExeptionMapper * Add documentation for running the generator * Update README * Capitalize P in MicroProfile * Clean up generated model for microprofile rest client * Revert change in AbstractJavaCodegen and move the action into JavaMicroprofile * Remove non-cxf templates in JavaMicroprofile and rename cxf to mp" * Remove mp/server files * Update pom.xml to have MpRestClient dependencies * Generate tests using smallrye implementation * Change JavaMicroprofile.java to JavaMicroprofileCodegen.java * Add test for JavaMicroprofileCodegen * Add scripts to generate petstore sample * Add README * Revert "Add scripts to generate petstore sample" This reverts commit 25ee496. * Revert "Add README" This reverts commit 067b2a8. * Revert "Revert "Add scripts to generate petstore sample"" This reverts commit 5a36390. * Add README * Move templates out of mp/ directory * Remove CXF references * Remove unnecessary templates * Fix compilation errors * Add missing jsonb dependency * Add license header to code templates * Increase copyright year to 2019 * Remove TODO comments and commented out code * Add more javadocs to the model templates * Fix issues with generated code * Revert README back to master's README * Add documentation for java microprofile client generator * Add MicroProfile Rest Client to list of clients in README * Remove smartbear copyright from java files * Add disableMultipart option * Fix licenseInfo * Rename JavaMicroprofileCodegen to JavaMicroprofileRestClientCodegen * Rename sample scripts to java-microprofile-rest-client * Adjust test comments * Better spacing between members for generated models * Update getHelp() method * Update javadoc for tests
5 tasks
5 tasks
6 tasks
wing328 pushed a commit
that referenced
this pull request
Sep 28, 2020
Thecrazyskull pushed a commit
to Thecrazyskull/openapi-generator
that referenced
this pull request
Nov 13, 2020
Upgrade to kotlin 1.4 & bug fixes for kotlin MPP
Thecrazyskull pushed a commit
to Thecrazyskull/openapi-generator
that referenced
this pull request
Nov 13, 2020
Merge from Egeniq repository
christiancompton pushed a commit
to christiancompton/openapi-generator
that referenced
this pull request
Apr 27, 2021
6 tasks
wing328 pushed a commit
that referenced
this pull request
Jan 2, 2022
Sync with latest openapi master
hanakslr pushed a commit
to hanakslr/openapi-generator
that referenced
this pull request
May 27, 2022
This was referenced Dec 8, 2022
nilskuhn pushed a commit
to nilskuhn/openapi-generator
that referenced
this pull request
Apr 6, 2023
5 tasks
6 tasks
fire pushed a commit
to V-Sekai/openapi-generator
that referenced
this pull request
Jun 25, 2024
fix. Default string values now with "quotes"
5 tasks
6 tasks
wing328 pushed a commit
that referenced
this pull request
Dec 17, 2025
wing328 pushed a commit
that referenced
this pull request
Jan 27, 2026
…streaming (#22673) * Update isomorphic-fetch file to allow for response streaming (#1) * Update samples/openapi3/client/petstore/typescript/builds/inversify/http/http.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update samples/client/echo_api/typescript/build/http/http.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update samples/openapi3/client/petstore/typescript/builds/object_params/http/http.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * update samples * fix tests --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Open
5 tasks
fstotz added a commit
to fstotz/openapi-generator
that referenced
this pull request
Aug 25, 2026
- Change form parameter null guard to apply to ALL optional params,
not just non-nullable optional params
- Old guard: {{^required}}{{^isNullable}}if(...!= null){{/isNullable}}{{/required}}
- New guard: {{^required}}if(...!= null){{/required}}
- Fixes optional nullable form params being encoded to empty string
instead of being omitted from form body
- Applied to both built_value and json_serializable serialize templates
- Applied to both multipart and non-multipart form encoding
- Regenerate all 8 Dart Dio samples
Before fix:
Optional nullable param with null value → encoded to '' → map gets
'field': '' instead of omitting the field
After fix:
Optional nullable param with null value → guarded by if check →
stays null in map → removeNullParametersExcept removes it → field omitted
Fixes P2 Issue OpenAPITools#1: optional nullable form parameters now correctly
omitted from form body when null, instead of sent as empty fields.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master.Description of the PR
Various fixes reported by the CI.