Uh oh!
There was an error while loading. Please reload this page.
[Java][Spring] fix imports for nullable helpers - #10234
Merged
Merged
Conversation
borsch
commented
Aug 23, 2021
MemberAuthor
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01) @wing328 |
agilob
commented
Aug 23, 2021
Contributor
This PR is too long to unroll, new import will be redundant in most cases as examples show so it must be added conditionally. Functional change and updated examples are in one commit, so it's even super hard to find where the fix is. |
borschforce-pushed
the
fix-nullable-arrays-imports
branch
from
August 24, 2021 09:08
300d641 to
4ebcd43Compareartemitin
commented
Sep 1, 2021
Contributor
@borsch any update on this? |
wing328
commented
Sep 2, 2021
Member
CircleCI failure not related to this change. |
wing328
commented
Sep 2, 2021
Member
@artemitin just merged the PR. Can you please pull the latest master to give it another try? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #10213
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x