[dart-dio-next] Fix oneOf handling in dart by jgoyvaerts · Pull Request #10313 · OpenAPITools/openapi-generator

jgoyvaerts · 2021-09-02T11:33:58Z

Currently oneOf is not handled correctly in dart, this PR fixes that. It contains a commit from #6914 as well as an extra commit added to handle the single oneOf case as a nullable type.

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

agilob · 2021-09-02T12:08:19Z

 if (exts != null && exts.containsKey("x-one-of-name")) {
 return (String) exts.get("x-one-of-name");
 }
+ if (names.size() == 1) return names.get(0);


if (names.size() == 1) { return names.get(0); }

can you add a test for it please?

Sure, can you point me in the right direction where you would want this test, or a similar test I can start from? The project is kinda big and hard to find the right place

Probably in DefaultCodegenTest

Why is this branch needed? I think this may break other generators.
We should be able to extract the single name in the dart generator.

Please elaborate on why this change in the default codegen is needed as this will likely impact other generators as well.

It's my bad, will update it

agilob · 2021-09-02T12:08:43Z

 @Override
 public String getSchemaType(Schema p) {
+ if (p instanceof ComposedSchema) {
+ ComposedSchema cs = (ComposedSchema) p;


use spaces to format indents

pls add descriptive unit tests for null handling and size = 0, size = 1 and size > 1

kuhnroyal · 2021-09-02T13:42:22Z

+ if (cs.getOneOf() != null) {
+ List<Schema> schemas = ModelUtils.getInterfaces(cs);
+ if(schemas.size() != 1) {
+ return "dynamic";


We should go with Object or Object? for all new code, depending on if it is nullable/required.

josh-burton · 2021-09-02T17:51:53Z

Can you generate the samples as well?

wing328 · 2021-09-25T06:20:24Z

Can you generate the samples as well?

Looks like there's no change in the samples as Dart is using the simple petstore.yaml. There's another spec that covers a lot more test cases: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml

zakton5 · 2022-02-06T18:33:24Z

@wing328 Just curious, why does this one keep getting delayed?

agilob · 2022-02-06T20:24:19Z

not enough green ticks to merge it

akhan5 · 2022-09-05T06:22:03Z

@wing328, @agilob can this PR gets merged this week.

I tried to use a workaround for oneOf types "--type-mappings myOneOfRequestType=dynamic" but got compile time errors related to dynamic datatype in "dart-dio" generated code.

ahmednfwela · 2022-09-05T07:02:34Z

wouldn't it be better to merge this PR instead ? #12295

akhan5 · 2022-09-05T07:24:25Z

@ahmednfwela, is it #12295 going to be released in milestone 6.1.0?
Currently, I am stuck on oneOf types.

ahmednfwela · 2022-09-05T07:25:30Z

@akhan5 it is ready for merge, hope it will be out in 6.1.0

kuhnroyal · 2022-09-06T21:38:19Z

I think we can close this one?

jgoyvaerts · 2021-09-02T11:33:58Z

Currently oneOf is not handled correctly in dart, this PR fixes that. It contains a commit from #6914 as well as an extra commit added to handle the single oneOf case as a nullable type.

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

agilob · 2021-09-02T12:08:19Z

 if (exts != null && exts.containsKey("x-one-of-name")) {
 return (String) exts.get("x-one-of-name");
 }
+ if (names.size() == 1) return names.get(0);


if (names.size() == 1) { return names.get(0); }

can you add a test for it please?

Sure, can you point me in the right direction where you would want this test, or a similar test I can start from? The project is kinda big and hard to find the right place

Probably in DefaultCodegenTest

Why is this branch needed? I think this may break other generators.
We should be able to extract the single name in the dart generator.

Please elaborate on why this change in the default codegen is needed as this will likely impact other generators as well.

It's my bad, will update it

agilob · 2021-09-02T12:08:43Z

 @Override
 public String getSchemaType(Schema p) {
+ if (p instanceof ComposedSchema) {
+ ComposedSchema cs = (ComposedSchema) p;


use spaces to format indents

pls add descriptive unit tests for null handling and size = 0, size = 1 and size > 1

kuhnroyal · 2021-09-02T13:42:22Z

+ if (cs.getOneOf() != null) {
+ List<Schema> schemas = ModelUtils.getInterfaces(cs);
+ if(schemas.size() != 1) {
+ return "dynamic";


We should go with Object or Object? for all new code, depending on if it is nullable/required.

josh-burton · 2021-09-02T17:51:53Z

Can you generate the samples as well?

wing328 · 2021-09-25T06:20:24Z

Can you generate the samples as well?

Looks like there's no change in the samples as Dart is using the simple petstore.yaml. There's another spec that covers a lot more test cases: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml

zakton5 · 2022-02-06T18:33:24Z

@wing328 Just curious, why does this one keep getting delayed?

agilob · 2022-02-06T20:24:19Z

not enough green ticks to merge it

akhan5 · 2022-09-05T06:22:03Z

@wing328, @agilob can this PR gets merged this week.

I tried to use a workaround for oneOf types "--type-mappings myOneOfRequestType=dynamic" but got compile time errors related to dynamic datatype in "dart-dio" generated code.

ahmednfwela · 2022-09-05T07:02:34Z

wouldn't it be better to merge this PR instead ? #12295

akhan5 · 2022-09-05T07:24:25Z

@ahmednfwela, is it #12295 going to be released in milestone 6.1.0?
Currently, I am stuck on oneOf types.

ahmednfwela · 2022-09-05T07:25:30Z

@akhan5 it is ready for merge, hope it will be out in 6.1.0

kuhnroyal · 2022-09-06T21:38:19Z

I think we can close this one?

jgoyvaerts · 2021-09-02T11:33:58Z

Currently oneOf is not handled correctly in dart, this PR fixes that. It contains a commit from #6914 as well as an extra commit added to handle the single oneOf case as a nullable type.

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

agilob · 2021-09-02T12:08:19Z

 if (exts != null && exts.containsKey("x-one-of-name")) {
 return (String) exts.get("x-one-of-name");
 }
+ if (names.size() == 1) return names.get(0);


if (names.size() == 1) { return names.get(0); }

can you add a test for it please?

Sure, can you point me in the right direction where you would want this test, or a similar test I can start from? The project is kinda big and hard to find the right place

Probably in DefaultCodegenTest

Why is this branch needed? I think this may break other generators.
We should be able to extract the single name in the dart generator.

Please elaborate on why this change in the default codegen is needed as this will likely impact other generators as well.

It's my bad, will update it

agilob · 2021-09-02T12:08:43Z

 @Override
 public String getSchemaType(Schema p) {
+ if (p instanceof ComposedSchema) {
+ ComposedSchema cs = (ComposedSchema) p;


use spaces to format indents

pls add descriptive unit tests for null handling and size = 0, size = 1 and size > 1

kuhnroyal · 2021-09-02T13:42:22Z

+ if (cs.getOneOf() != null) {
+ List<Schema> schemas = ModelUtils.getInterfaces(cs);
+ if(schemas.size() != 1) {
+ return "dynamic";


We should go with Object or Object? for all new code, depending on if it is nullable/required.

josh-burton · 2021-09-02T17:51:53Z

Can you generate the samples as well?

wing328 · 2021-09-25T06:20:24Z

Can you generate the samples as well?

Looks like there's no change in the samples as Dart is using the simple petstore.yaml. There's another spec that covers a lot more test cases: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml

zakton5 · 2022-02-06T18:33:24Z

@wing328 Just curious, why does this one keep getting delayed?

agilob · 2022-02-06T20:24:19Z

not enough green ticks to merge it

akhan5 · 2022-09-05T06:22:03Z

@wing328, @agilob can this PR gets merged this week.

I tried to use a workaround for oneOf types "--type-mappings myOneOfRequestType=dynamic" but got compile time errors related to dynamic datatype in "dart-dio" generated code.

ahmednfwela · 2022-09-05T07:02:34Z

wouldn't it be better to merge this PR instead ? #12295

akhan5 · 2022-09-05T07:24:25Z

@ahmednfwela, is it #12295 going to be released in milestone 6.1.0?
Currently, I am stuck on oneOf types.

ahmednfwela · 2022-09-05T07:25:30Z

@akhan5 it is ready for merge, hope it will be out in 6.1.0

kuhnroyal · 2022-09-06T21:38:19Z

I think we can close this one?

jgoyvaerts · 2021-09-02T11:33:58Z

Currently oneOf is not handled correctly in dart, this PR fixes that. It contains a commit from #6914 as well as an extra commit added to handle the single oneOf case as a nullable type.

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

agilob · 2021-09-02T12:08:19Z

 if (exts != null && exts.containsKey("x-one-of-name")) {
 return (String) exts.get("x-one-of-name");
 }
+ if (names.size() == 1) return names.get(0);


if (names.size() == 1) { return names.get(0); }

can you add a test for it please?

Sure, can you point me in the right direction where you would want this test, or a similar test I can start from? The project is kinda big and hard to find the right place

Probably in DefaultCodegenTest

Why is this branch needed? I think this may break other generators.
We should be able to extract the single name in the dart generator.

Please elaborate on why this change in the default codegen is needed as this will likely impact other generators as well.

It's my bad, will update it

agilob · 2021-09-02T12:08:43Z

 @Override
 public String getSchemaType(Schema p) {
+ if (p instanceof ComposedSchema) {
+ ComposedSchema cs = (ComposedSchema) p;


use spaces to format indents

pls add descriptive unit tests for null handling and size = 0, size = 1 and size > 1

kuhnroyal · 2021-09-02T13:42:22Z

+ if (cs.getOneOf() != null) {
+ List<Schema> schemas = ModelUtils.getInterfaces(cs);
+ if(schemas.size() != 1) {
+ return "dynamic";


We should go with Object or Object? for all new code, depending on if it is nullable/required.

josh-burton · 2021-09-02T17:51:53Z

Can you generate the samples as well?

wing328 · 2021-09-25T06:20:24Z

Can you generate the samples as well?

Looks like there's no change in the samples as Dart is using the simple petstore.yaml. There's another spec that covers a lot more test cases: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml

zakton5 · 2022-02-06T18:33:24Z

@wing328 Just curious, why does this one keep getting delayed?

agilob · 2022-02-06T20:24:19Z

not enough green ticks to merge it

akhan5 · 2022-09-05T06:22:03Z

@wing328, @agilob can this PR gets merged this week.

I tried to use a workaround for oneOf types "--type-mappings myOneOfRequestType=dynamic" but got compile time errors related to dynamic datatype in "dart-dio" generated code.

ahmednfwela · 2022-09-05T07:02:34Z

wouldn't it be better to merge this PR instead ? #12295

akhan5 · 2022-09-05T07:24:25Z

@ahmednfwela, is it #12295 going to be released in milestone 6.1.0?
Currently, I am stuck on oneOf types.

ahmednfwela · 2022-09-05T07:25:30Z

@akhan5 it is ready for merge, hope it will be out in 6.1.0

kuhnroyal · 2022-09-06T21:38:19Z

I think we can close this one?

jgoyvaerts · 2021-09-02T11:33:58Z

Currently oneOf is not handled correctly in dart, this PR fixes that. It contains a commit from #6914 as well as an extra commit added to handle the single oneOf case as a nullable type.

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

agilob · 2021-09-02T12:08:19Z

 if (exts != null && exts.containsKey("x-one-of-name")) {
 return (String) exts.get("x-one-of-name");
 }
+ if (names.size() == 1) return names.get(0);


if (names.size() == 1) { return names.get(0); }

can you add a test for it please?

Sure, can you point me in the right direction where you would want this test, or a similar test I can start from? The project is kinda big and hard to find the right place

Probably in DefaultCodegenTest

Why is this branch needed? I think this may break other generators.
We should be able to extract the single name in the dart generator.

Please elaborate on why this change in the default codegen is needed as this will likely impact other generators as well.

It's my bad, will update it

agilob · 2021-09-02T12:08:43Z

 @Override
 public String getSchemaType(Schema p) {
+ if (p instanceof ComposedSchema) {
+ ComposedSchema cs = (ComposedSchema) p;


use spaces to format indents

pls add descriptive unit tests for null handling and size = 0, size = 1 and size > 1

kuhnroyal · 2021-09-02T13:42:22Z

+ if (cs.getOneOf() != null) {
+ List<Schema> schemas = ModelUtils.getInterfaces(cs);
+ if(schemas.size() != 1) {
+ return "dynamic";


We should go with Object or Object? for all new code, depending on if it is nullable/required.

josh-burton · 2021-09-02T17:51:53Z

Can you generate the samples as well?

wing328 · 2021-09-25T06:20:24Z

Can you generate the samples as well?

Looks like there's no change in the samples as Dart is using the simple petstore.yaml. There's another spec that covers a lot more test cases: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml

zakton5 · 2022-02-06T18:33:24Z

@wing328 Just curious, why does this one keep getting delayed?

agilob · 2022-02-06T20:24:19Z

not enough green ticks to merge it

akhan5 · 2022-09-05T06:22:03Z

@wing328, @agilob can this PR gets merged this week.

I tried to use a workaround for oneOf types "--type-mappings myOneOfRequestType=dynamic" but got compile time errors related to dynamic datatype in "dart-dio" generated code.

ahmednfwela · 2022-09-05T07:02:34Z

wouldn't it be better to merge this PR instead ? #12295

akhan5 · 2022-09-05T07:24:25Z

@ahmednfwela, is it #12295 going to be released in milestone 6.1.0?
Currently, I am stuck on oneOf types.

ahmednfwela · 2022-09-05T07:25:30Z

@akhan5 it is ready for merge, hope it will be out in 6.1.0

kuhnroyal · 2022-09-06T21:38:19Z

I think we can close this one?

jgoyvaerts · 2021-09-02T11:33:58Z

Currently oneOf is not handled correctly in dart, this PR fixes that. It contains a commit from #6914 as well as an extra commit added to handle the single oneOf case as a nullable type.

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

agilob · 2021-09-02T12:08:19Z

 if (exts != null && exts.containsKey("x-one-of-name")) {
 return (String) exts.get("x-one-of-name");
 }
+ if (names.size() == 1) return names.get(0);


if (names.size() == 1) { return names.get(0); }

can you add a test for it please?

Sure, can you point me in the right direction where you would want this test, or a similar test I can start from? The project is kinda big and hard to find the right place

Probably in DefaultCodegenTest

Why is this branch needed? I think this may break other generators.
We should be able to extract the single name in the dart generator.

Please elaborate on why this change in the default codegen is needed as this will likely impact other generators as well.

It's my bad, will update it

agilob · 2021-09-02T12:08:43Z

 @Override
 public String getSchemaType(Schema p) {
+ if (p instanceof ComposedSchema) {
+ ComposedSchema cs = (ComposedSchema) p;


use spaces to format indents

pls add descriptive unit tests for null handling and size = 0, size = 1 and size > 1

kuhnroyal · 2021-09-02T13:42:22Z

+ if (cs.getOneOf() != null) {
+ List<Schema> schemas = ModelUtils.getInterfaces(cs);
+ if(schemas.size() != 1) {
+ return "dynamic";


We should go with Object or Object? for all new code, depending on if it is nullable/required.

josh-burton · 2021-09-02T17:51:53Z

Can you generate the samples as well?

wing328 · 2021-09-25T06:20:24Z

Can you generate the samples as well?

Looks like there's no change in the samples as Dart is using the simple petstore.yaml. There's another spec that covers a lot more test cases: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml

zakton5 · 2022-02-06T18:33:24Z

@wing328 Just curious, why does this one keep getting delayed?

agilob · 2022-02-06T20:24:19Z

not enough green ticks to merge it

akhan5 · 2022-09-05T06:22:03Z

@wing328, @agilob can this PR gets merged this week.

I tried to use a workaround for oneOf types "--type-mappings myOneOfRequestType=dynamic" but got compile time errors related to dynamic datatype in "dart-dio" generated code.

ahmednfwela · 2022-09-05T07:02:34Z

wouldn't it be better to merge this PR instead ? #12295

akhan5 · 2022-09-05T07:24:25Z

@ahmednfwela, is it #12295 going to be released in milestone 6.1.0?
Currently, I am stuck on oneOf types.

ahmednfwela · 2022-09-05T07:25:30Z

@akhan5 it is ready for merge, hope it will be out in 6.1.0

kuhnroyal · 2022-09-06T21:38:19Z

I think we can close this one?

jgoyvaerts · 2021-09-02T11:33:58Z

Currently oneOf is not handled correctly in dart, this PR fixes that. It contains a commit from #6914 as well as an extra commit added to handle the single oneOf case as a nullable type.

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

agilob · 2021-09-02T12:08:19Z

 if (exts != null && exts.containsKey("x-one-of-name")) {
 return (String) exts.get("x-one-of-name");
 }
+ if (names.size() == 1) return names.get(0);


if (names.size() == 1) { return names.get(0); }

can you add a test for it please?

Sure, can you point me in the right direction where you would want this test, or a similar test I can start from? The project is kinda big and hard to find the right place

Probably in DefaultCodegenTest

Why is this branch needed? I think this may break other generators.
We should be able to extract the single name in the dart generator.

Please elaborate on why this change in the default codegen is needed as this will likely impact other generators as well.

It's my bad, will update it

agilob · 2021-09-02T12:08:43Z

 @Override
 public String getSchemaType(Schema p) {
+ if (p instanceof ComposedSchema) {
+ ComposedSchema cs = (ComposedSchema) p;


use spaces to format indents

pls add descriptive unit tests for null handling and size = 0, size = 1 and size > 1

kuhnroyal · 2021-09-02T13:42:22Z

+ if (cs.getOneOf() != null) {
+ List<Schema> schemas = ModelUtils.getInterfaces(cs);
+ if(schemas.size() != 1) {
+ return "dynamic";


We should go with Object or Object? for all new code, depending on if it is nullable/required.

josh-burton · 2021-09-02T17:51:53Z

Can you generate the samples as well?

wing328 · 2021-09-25T06:20:24Z

Can you generate the samples as well?

Looks like there's no change in the samples as Dart is using the simple petstore.yaml. There's another spec that covers a lot more test cases: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml

zakton5 · 2022-02-06T18:33:24Z

@wing328 Just curious, why does this one keep getting delayed?

agilob · 2022-02-06T20:24:19Z

not enough green ticks to merge it

akhan5 · 2022-09-05T06:22:03Z

@wing328, @agilob can this PR gets merged this week.

I tried to use a workaround for oneOf types "--type-mappings myOneOfRequestType=dynamic" but got compile time errors related to dynamic datatype in "dart-dio" generated code.

ahmednfwela · 2022-09-05T07:02:34Z

wouldn't it be better to merge this PR instead ? #12295

akhan5 · 2022-09-05T07:24:25Z

@ahmednfwela, is it #12295 going to be released in milestone 6.1.0?
Currently, I am stuck on oneOf types.

ahmednfwela · 2022-09-05T07:25:30Z

@akhan5 it is ready for merge, hope it will be out in 6.1.0

kuhnroyal · 2022-09-06T21:38:19Z

I think we can close this one?

jgoyvaerts · 2021-09-02T11:33:58Z

Currently oneOf is not handled correctly in dart, this PR fixes that. It contains a commit from #6914 as well as an extra commit added to handle the single oneOf case as a nullable type.

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

agilob · 2021-09-02T12:08:19Z

 if (exts != null && exts.containsKey("x-one-of-name")) {
 return (String) exts.get("x-one-of-name");
 }
+ if (names.size() == 1) return names.get(0);


if (names.size() == 1) { return names.get(0); }

can you add a test for it please?

Sure, can you point me in the right direction where you would want this test, or a similar test I can start from? The project is kinda big and hard to find the right place

Probably in DefaultCodegenTest

Why is this branch needed? I think this may break other generators.
We should be able to extract the single name in the dart generator.

Please elaborate on why this change in the default codegen is needed as this will likely impact other generators as well.

It's my bad, will update it

agilob · 2021-09-02T12:08:43Z

 @Override
 public String getSchemaType(Schema p) {
+ if (p instanceof ComposedSchema) {
+ ComposedSchema cs = (ComposedSchema) p;


use spaces to format indents

pls add descriptive unit tests for null handling and size = 0, size = 1 and size > 1

kuhnroyal · 2021-09-02T13:42:22Z

+ if (cs.getOneOf() != null) {
+ List<Schema> schemas = ModelUtils.getInterfaces(cs);
+ if(schemas.size() != 1) {
+ return "dynamic";


We should go with Object or Object? for all new code, depending on if it is nullable/required.

josh-burton · 2021-09-02T17:51:53Z

Can you generate the samples as well?

wing328 · 2021-09-25T06:20:24Z

Can you generate the samples as well?

Looks like there's no change in the samples as Dart is using the simple petstore.yaml. There's another spec that covers a lot more test cases: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml

zakton5 · 2022-02-06T18:33:24Z

@wing328 Just curious, why does this one keep getting delayed?

agilob · 2022-02-06T20:24:19Z

not enough green ticks to merge it

akhan5 · 2022-09-05T06:22:03Z

@wing328, @agilob can this PR gets merged this week.

I tried to use a workaround for oneOf types "--type-mappings myOneOfRequestType=dynamic" but got compile time errors related to dynamic datatype in "dart-dio" generated code.

ahmednfwela · 2022-09-05T07:02:34Z

wouldn't it be better to merge this PR instead ? #12295

akhan5 · 2022-09-05T07:24:25Z

@ahmednfwela, is it #12295 going to be released in milestone 6.1.0?
Currently, I am stuck on oneOf types.

ahmednfwela · 2022-09-05T07:25:30Z

@akhan5 it is ready for merge, hope it will be out in 6.1.0

kuhnroyal · 2022-09-06T21:38:19Z

I think we can close this one?

sbu-WBTand others added 2 commits September 1, 2021 14:18

Set type of OneOf to dynamic
1fefc43

Handle nullable oneOf cases correctly if there's only one type
e1dedfe

agilob reviewed Sep 2, 2021
View reviewed changes

kuhnroyal reviewed Sep 2, 2021
View reviewed changes

wing328 added Client: Dart Enhancement: Feature Feature: OAS 3.0 spec support labels Sep 25, 2021

wing328 added this to the 5.3.0 milestone Sep 25, 2021

wing328 modified the milestones: 5.3.0, 5.3.1 Oct 25, 2021

wing328 modified the milestones: 5.3.1, 5.4.0 Dec 29, 2021

wing328 modified the milestones: 5.4.0, 6.0.0 Jan 31, 2022

banool mentioned this pull request May 18, 2022
[dart-dio] handle polymorphism + discriminator serialization #12295
Merged
8 tasks

wing328 modified the milestones: 6.0.0, 6.1.0, 6.0.1 May 26, 2022

wing328 modified the milestones: 6.0.1, 6.1.0 Jul 5, 2022

wing328 modified the milestones: 6.1.0, 6.1.1 Sep 11, 2022

wing328 modified the milestones: 6.1.1, 6.2.1 Sep 24, 2022

wing328 modified the milestones: 6.2.1, 6.3.0 Nov 1, 2022

wing328 closed this Dec 28, 2022

sbu-WBTand others added 2 commits September 1, 2021 14:18

Set type of OneOf to dynamic
1fefc43

Handle nullable oneOf cases correctly if there's only one type
e1dedfe

agilob reviewed Sep 2, 2021
View reviewed changes

kuhnroyal reviewed Sep 2, 2021
View reviewed changes

wing328 added Client: Dart Enhancement: Feature Feature: OAS 3.0 spec support labels Sep 25, 2021

wing328 added this to the 5.3.0 milestone Sep 25, 2021

wing328 modified the milestones: 5.3.0, 5.3.1 Oct 25, 2021

wing328 modified the milestones: 5.3.1, 5.4.0 Dec 29, 2021

wing328 modified the milestones: 5.4.0, 6.0.0 Jan 31, 2022

banool mentioned this pull request May 18, 2022
[dart-dio] handle polymorphism + discriminator serialization #12295
Merged
8 tasks

wing328 modified the milestones: 6.0.0, 6.1.0, 6.0.1 May 26, 2022

wing328 modified the milestones: 6.0.1, 6.1.0 Jul 5, 2022

wing328 modified the milestones: 6.1.0, 6.1.1 Sep 11, 2022

wing328 modified the milestones: 6.1.1, 6.2.1 Sep 24, 2022

wing328 modified the milestones: 6.2.1, 6.3.0 Nov 1, 2022

wing328 closed this Dec 28, 2022

sbu-WBTand others added 2 commits September 1, 2021 14:18

Set type of OneOf to dynamic
1fefc43

Handle nullable oneOf cases correctly if there's only one type
e1dedfe

agilob reviewed Sep 2, 2021
View reviewed changes

kuhnroyal reviewed Sep 2, 2021
View reviewed changes

wing328 added Client: Dart Enhancement: Feature Feature: OAS 3.0 spec support labels Sep 25, 2021

wing328 added this to the 5.3.0 milestone Sep 25, 2021

wing328 modified the milestones: 5.3.0, 5.3.1 Oct 25, 2021

wing328 modified the milestones: 5.3.1, 5.4.0 Dec 29, 2021

wing328 modified the milestones: 5.4.0, 6.0.0 Jan 31, 2022

banool mentioned this pull request May 18, 2022
[dart-dio] handle polymorphism + discriminator serialization #12295
Merged
8 tasks

wing328 modified the milestones: 6.0.0, 6.1.0, 6.0.1 May 26, 2022

wing328 modified the milestones: 6.0.1, 6.1.0 Jul 5, 2022

wing328 modified the milestones: 6.1.0, 6.1.1 Sep 11, 2022

wing328 modified the milestones: 6.1.1, 6.2.1 Sep 24, 2022

wing328 modified the milestones: 6.2.1, 6.3.0 Nov 1, 2022

wing328 closed this Dec 28, 2022

sbu-WBTand others added 2 commits September 1, 2021 14:18

Set type of OneOf to dynamic
1fefc43

Handle nullable oneOf cases correctly if there's only one type
e1dedfe

agilob reviewed Sep 2, 2021
View reviewed changes

kuhnroyal reviewed Sep 2, 2021
View reviewed changes

wing328 added Client: Dart Enhancement: Feature Feature: OAS 3.0 spec support labels Sep 25, 2021

wing328 added this to the 5.3.0 milestone Sep 25, 2021

wing328 modified the milestones: 5.3.0, 5.3.1 Oct 25, 2021

wing328 modified the milestones: 5.3.1, 5.4.0 Dec 29, 2021

wing328 modified the milestones: 5.4.0, 6.0.0 Jan 31, 2022

banool mentioned this pull request May 18, 2022
[dart-dio] handle polymorphism + discriminator serialization #12295
Merged
8 tasks

wing328 modified the milestones: 6.0.0, 6.1.0, 6.0.1 May 26, 2022

wing328 modified the milestones: 6.0.1, 6.1.0 Jul 5, 2022

wing328 modified the milestones: 6.1.0, 6.1.1 Sep 11, 2022

wing328 modified the milestones: 6.1.1, 6.2.1 Sep 24, 2022

wing328 modified the milestones: 6.2.1, 6.3.0 Nov 1, 2022

wing328 closed this Dec 28, 2022

sbu-WBTand others added 2 commits September 1, 2021 14:18

Set type of OneOf to dynamic
1fefc43

Handle nullable oneOf cases correctly if there's only one type
e1dedfe

agilob reviewed Sep 2, 2021
View reviewed changes

kuhnroyal reviewed Sep 2, 2021
View reviewed changes

wing328 added Client: Dart Enhancement: Feature Feature: OAS 3.0 spec support labels Sep 25, 2021

wing328 added this to the 5.3.0 milestone Sep 25, 2021

wing328 modified the milestones: 5.3.0, 5.3.1 Oct 25, 2021

wing328 modified the milestones: 5.3.1, 5.4.0 Dec 29, 2021

wing328 modified the milestones: 5.4.0, 6.0.0 Jan 31, 2022

banool mentioned this pull request May 18, 2022
[dart-dio] handle polymorphism + discriminator serialization #12295
Merged
8 tasks

wing328 modified the milestones: 6.0.0, 6.1.0, 6.0.1 May 26, 2022

wing328 modified the milestones: 6.0.1, 6.1.0 Jul 5, 2022

wing328 modified the milestones: 6.1.0, 6.1.1 Sep 11, 2022

wing328 modified the milestones: 6.1.1, 6.2.1 Sep 24, 2022

wing328 modified the milestones: 6.2.1, 6.3.0 Nov 1, 2022

wing328 closed this Dec 28, 2022

sbu-WBTand others added 2 commits September 1, 2021 14:18

Set type of OneOf to dynamic
1fefc43

Handle nullable oneOf cases correctly if there's only one type
e1dedfe

agilob reviewed Sep 2, 2021
View reviewed changes

kuhnroyal reviewed Sep 2, 2021
View reviewed changes

wing328 added Client: Dart Enhancement: Feature Feature: OAS 3.0 spec support labels Sep 25, 2021

wing328 added this to the 5.3.0 milestone Sep 25, 2021

wing328 modified the milestones: 5.3.0, 5.3.1 Oct 25, 2021

wing328 modified the milestones: 5.3.1, 5.4.0 Dec 29, 2021

wing328 modified the milestones: 5.4.0, 6.0.0 Jan 31, 2022

banool mentioned this pull request May 18, 2022
[dart-dio] handle polymorphism + discriminator serialization #12295
Merged
8 tasks

wing328 modified the milestones: 6.0.0, 6.1.0, 6.0.1 May 26, 2022

wing328 modified the milestones: 6.0.1, 6.1.0 Jul 5, 2022

wing328 modified the milestones: 6.1.0, 6.1.1 Sep 11, 2022

wing328 modified the milestones: 6.1.1, 6.2.1 Sep 24, 2022

wing328 modified the milestones: 6.2.1, 6.3.0 Nov 1, 2022

wing328 closed this Dec 28, 2022

sbu-WBTand others added 2 commits September 1, 2021 14:18

Set type of OneOf to dynamic
1fefc43

Handle nullable oneOf cases correctly if there's only one type
e1dedfe

agilob reviewed Sep 2, 2021
View reviewed changes

kuhnroyal reviewed Sep 2, 2021
View reviewed changes

wing328 added Client: Dart Enhancement: Feature Feature: OAS 3.0 spec support labels Sep 25, 2021

wing328 added this to the 5.3.0 milestone Sep 25, 2021

wing328 modified the milestones: 5.3.0, 5.3.1 Oct 25, 2021

wing328 modified the milestones: 5.3.1, 5.4.0 Dec 29, 2021

wing328 modified the milestones: 5.4.0, 6.0.0 Jan 31, 2022

banool mentioned this pull request May 18, 2022
[dart-dio] handle polymorphism + discriminator serialization #12295
Merged
8 tasks

wing328 modified the milestones: 6.0.0, 6.1.0, 6.0.1 May 26, 2022

wing328 modified the milestones: 6.0.1, 6.1.0 Jul 5, 2022

wing328 modified the milestones: 6.1.0, 6.1.1 Sep 11, 2022

wing328 modified the milestones: 6.1.1, 6.2.1 Sep 24, 2022

wing328 modified the milestones: 6.2.1, 6.3.0 Nov 1, 2022

wing328 closed this Dec 28, 2022

sbu-WBTand others added 2 commits September 1, 2021 14:18

Set type of OneOf to dynamic
1fefc43

Handle nullable oneOf cases correctly if there's only one type
e1dedfe

agilob reviewed Sep 2, 2021
View reviewed changes

kuhnroyal reviewed Sep 2, 2021
View reviewed changes

wing328 added Client: Dart Enhancement: Feature Feature: OAS 3.0 spec support labels Sep 25, 2021

wing328 added this to the 5.3.0 milestone Sep 25, 2021

wing328 modified the milestones: 5.3.0, 5.3.1 Oct 25, 2021

wing328 modified the milestones: 5.3.1, 5.4.0 Dec 29, 2021

wing328 modified the milestones: 5.4.0, 6.0.0 Jan 31, 2022

banool mentioned this pull request May 18, 2022
[dart-dio] handle polymorphism + discriminator serialization #12295
Merged
8 tasks

wing328 modified the milestones: 6.0.0, 6.1.0, 6.0.1 May 26, 2022

wing328 modified the milestones: 6.0.1, 6.1.0 Jul 5, 2022

wing328 modified the milestones: 6.1.0, 6.1.1 Sep 11, 2022

wing328 modified the milestones: 6.1.1, 6.2.1 Sep 24, 2022

wing328 modified the milestones: 6.2.1, 6.3.0 Nov 1, 2022

wing328 closed this Dec 28, 2022

Uh oh!

Uh oh!

Conversation

jgoyvaerts commented Sep 2, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agilobSep 2, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

josh-burton commented Sep 2, 2021

Uh oh!

wing328 commented Sep 25, 2021

Uh oh!

zakton5 commented Feb 6, 2022

Uh oh!

agilob commented Feb 6, 2022

Uh oh!

akhan5 commented Sep 5, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmednfwela commented Sep 5, 2022

Uh oh!

akhan5 commented Sep 5, 2022

Uh oh!

ahmednfwela commented Sep 5, 2022

Uh oh!

kuhnroyal commented Sep 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Uh oh!

Conversation

jgoyvaerts commented Sep 2, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agilobSep 2, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

agilobSep 2, 2021•
edited
Loading

akhan5 commented Sep 5, 2022•
edited
Loading

agilobSep 2, 2021•
edited
Loading

akhan5 commented Sep 5, 2022•
edited
Loading