Bump dart2 code compatibility to Dart 2.14 and introduce sound null-safety by provokateurin · Pull Request #10541 · OpenAPITools/openapi-generator

provokateurin · 2021-10-06T12:52:58Z

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

I actually started working on this a few weeks ago, before any of the current PRs against the dart2 generator were made.
I'm unsure what to do now, but I want to put out my work, so that we can have a great dart2 generator.
Anyway I update the Dart version to the latest stable and thus implemented null-safety. I wasn't able to actually test the generated code yet, but there are no errors shown anymore (due to the project I'm generated a client for using oneOf).
I deleted the tests, because they didn't do anything at all and with null-safety there were errors because of uninitialized fields.

Related PRs:
#10532
#10536

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

agilob · 2021-10-06T13:23:00Z

This PR does more than adding null safety to dart generator, I think it should be split into a few smaller PRs. A few general comments:

I would go as far as dart 2.14, but something older, this might be too big change for some
ignore and remove all changes related to json_serializable, consider this generator gone. Ideally, [dart] json_serializable: remove experimental generator #10532 would be merged before this one
we tend to keep changes in dart-dio and dart-dio-next and dart in separate PRs
with removal of generated test files this is even more braking change, this risks deleting user developed tests

agilob · 2021-10-06T13:24:36Z

 }
 }
- return null;
+ return DateTime(1970);


user of this API can't distinguish between incorrect date and intentionally provided 1970

agilob · 2021-10-06T13:27:29Z


 final String name;
- final String value;
+ final String? value;


can query have name but no value? and for the line below, it has to be empty string not null string, as end user won't be able to distinguish intentional null string from no value. I think both fields should be not-null in this class

agilob · 2021-10-06T13:28:34Z

- String message;
- Exception innerException;
- StackTrace stackTrace;
+ String? message;


another design question, when does it make sense to raise ApiException without a message?

agilob · 2021-10-06T13:30:17Z


 {{#native_serialization}}
- static dynamic _deserialize(dynamic value, String targetType, {bool growable}) {
+ static dynamic _deserialize(dynamic value, String targetType, {bool? growable}) {


Would it make sense to make growable false or true by default? this would avoid doing growable == true a few times below, consider it micro-optimisation. I would also make it false, since other dart apis use immutable structures

agilob · 2021-10-06T13:30:50Z


 @Deprecated('Scheduled for removal in OpenAPI Generator 6.x. Use serializeAsync() instead.')
- String serialize(Object value) => value == null ? '' : json.encode(value);
+ String serialize(Object? value) => value == null ? '' : json.encode(value);


Does it ever make sense to serialise null object?

agilob · 2021-10-06T13:32:01Z

 class HttpBasicAuth implements Authentication {
- String username;
- String password;
+ String? username;


by making these not-null you will avoid defaulting to empty string below, another micro optimisation on our side

agilob · 2021-10-06T13:33:28Z

 OAuth({this.accessToken});

- String accessToken;
+ String? accessToken;


by making this not-null you will avoid null check below. does it make sense to use OAuth without access token? Technically yes, but practically that's a sec vuln on endpoint to accept empty code

agilob · 2021-10-06T13:49:00Z

 public String arrayModelType;
 public boolean isAlias; // Is this effectively an alias of another simple type
- public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isBoolean;
+ public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isPrimitiveType, isBoolean;


Is there really no other method for this already? Im really surprised this needs to be introduced as new code @wing328 ?

agilob · 2021-10-06T13:52:56Z

 {{/isArray}}
 {{/json_serializable}}
 }
- return Future<{{{returnType}}}>.value();


I think this was added recently to satisfy stricter linter config, so pls revert #10263

agilob · 2021-10-06T13:58:08Z

 List<QueryParam> queryParams,
- Object body,
+ Object? body,
 Map<String, String> headerParams,


headerParams and formParams are nullable in other openapi generators, so I would prefer to keep it this way for language agnostic users

agilob · 2021-10-06T13:58:49Z

 }
 if (value is Set && (match = _regSet.firstMatch(targetType)) != null) {
- targetType = match[1]; // ignore: parameter_assignments
+ targetType = match![1]!; // ignore: parameter_assignments


yea, that's better than my defauling to Object? 👍

agilob · 2021-10-19T16:49:38Z

This branch was only passing tests because github actions have not kicked in and many tests didn't run...

provokateurin · 2021-10-19T20:28:21Z

Sorry, at our company we decided it is currently not worth enough to fix the requested stuff but also the still missing stuff. Other people can you pickup these changes if they want to. Maybe we will come back to this, but currently it's not our plan to do so in a timely manner.

agilob · 2021-10-20T07:00:06Z

I've already rebased your branch and started fixing the above

agilob · 2021-10-27T13:21:00Z

Can you close this PR pls?

provokateurin · 2021-10-27T13:51:01Z

Sure!

agilob · 2021-10-27T13:55:22Z

#10637

provokateurin · 2021-10-06T12:52:58Z

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

I actually started working on this a few weeks ago, before any of the current PRs against the dart2 generator were made.
I'm unsure what to do now, but I want to put out my work, so that we can have a great dart2 generator.
Anyway I update the Dart version to the latest stable and thus implemented null-safety. I wasn't able to actually test the generated code yet, but there are no errors shown anymore (due to the project I'm generated a client for using oneOf).
I deleted the tests, because they didn't do anything at all and with null-safety there were errors because of uninitialized fields.

Related PRs:
#10532
#10536

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

agilob · 2021-10-06T13:23:00Z

This PR does more than adding null safety to dart generator, I think it should be split into a few smaller PRs. A few general comments:

I would go as far as dart 2.14, but something older, this might be too big change for some
ignore and remove all changes related to json_serializable, consider this generator gone. Ideally, [dart] json_serializable: remove experimental generator #10532 would be merged before this one
we tend to keep changes in dart-dio and dart-dio-next and dart in separate PRs
with removal of generated test files this is even more braking change, this risks deleting user developed tests

agilob · 2021-10-06T13:24:36Z

 }
 }
- return null;
+ return DateTime(1970);


user of this API can't distinguish between incorrect date and intentionally provided 1970

agilob · 2021-10-06T13:27:29Z


 final String name;
- final String value;
+ final String? value;


can query have name but no value? and for the line below, it has to be empty string not null string, as end user won't be able to distinguish intentional null string from no value. I think both fields should be not-null in this class

agilob · 2021-10-06T13:28:34Z

- String message;
- Exception innerException;
- StackTrace stackTrace;
+ String? message;


another design question, when does it make sense to raise ApiException without a message?

agilob · 2021-10-06T13:30:17Z


 {{#native_serialization}}
- static dynamic _deserialize(dynamic value, String targetType, {bool growable}) {
+ static dynamic _deserialize(dynamic value, String targetType, {bool? growable}) {


Would it make sense to make growable false or true by default? this would avoid doing growable == true a few times below, consider it micro-optimisation. I would also make it false, since other dart apis use immutable structures

agilob · 2021-10-06T13:30:50Z


 @Deprecated('Scheduled for removal in OpenAPI Generator 6.x. Use serializeAsync() instead.')
- String serialize(Object value) => value == null ? '' : json.encode(value);
+ String serialize(Object? value) => value == null ? '' : json.encode(value);


Does it ever make sense to serialise null object?

agilob · 2021-10-06T13:32:01Z

 class HttpBasicAuth implements Authentication {
- String username;
- String password;
+ String? username;


by making these not-null you will avoid defaulting to empty string below, another micro optimisation on our side

agilob · 2021-10-06T13:33:28Z

 OAuth({this.accessToken});

- String accessToken;
+ String? accessToken;


by making this not-null you will avoid null check below. does it make sense to use OAuth without access token? Technically yes, but practically that's a sec vuln on endpoint to accept empty code

agilob · 2021-10-06T13:49:00Z

 public String arrayModelType;
 public boolean isAlias; // Is this effectively an alias of another simple type
- public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isBoolean;
+ public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isPrimitiveType, isBoolean;


Is there really no other method for this already? Im really surprised this needs to be introduced as new code @wing328 ?

agilob · 2021-10-06T13:52:56Z

 {{/isArray}}
 {{/json_serializable}}
 }
- return Future<{{{returnType}}}>.value();


I think this was added recently to satisfy stricter linter config, so pls revert #10263

agilob · 2021-10-06T13:58:08Z

 List<QueryParam> queryParams,
- Object body,
+ Object? body,
 Map<String, String> headerParams,


headerParams and formParams are nullable in other openapi generators, so I would prefer to keep it this way for language agnostic users

agilob · 2021-10-06T13:58:49Z

 }
 if (value is Set && (match = _regSet.firstMatch(targetType)) != null) {
- targetType = match[1]; // ignore: parameter_assignments
+ targetType = match![1]!; // ignore: parameter_assignments


yea, that's better than my defauling to Object? 👍

agilob · 2021-10-19T16:49:38Z

This branch was only passing tests because github actions have not kicked in and many tests didn't run...

provokateurin · 2021-10-19T20:28:21Z

Sorry, at our company we decided it is currently not worth enough to fix the requested stuff but also the still missing stuff. Other people can you pickup these changes if they want to. Maybe we will come back to this, but currently it's not our plan to do so in a timely manner.

agilob · 2021-10-20T07:00:06Z

I've already rebased your branch and started fixing the above

agilob · 2021-10-27T13:21:00Z

Can you close this PR pls?

provokateurin · 2021-10-27T13:51:01Z

Sure!

agilob · 2021-10-27T13:55:22Z

#10637

provokateurin · 2021-10-06T12:52:58Z

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

I actually started working on this a few weeks ago, before any of the current PRs against the dart2 generator were made.
I'm unsure what to do now, but I want to put out my work, so that we can have a great dart2 generator.
Anyway I update the Dart version to the latest stable and thus implemented null-safety. I wasn't able to actually test the generated code yet, but there are no errors shown anymore (due to the project I'm generated a client for using oneOf).
I deleted the tests, because they didn't do anything at all and with null-safety there were errors because of uninitialized fields.

Related PRs:
#10532
#10536

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

agilob · 2021-10-06T13:23:00Z

This PR does more than adding null safety to dart generator, I think it should be split into a few smaller PRs. A few general comments:

I would go as far as dart 2.14, but something older, this might be too big change for some
ignore and remove all changes related to json_serializable, consider this generator gone. Ideally, [dart] json_serializable: remove experimental generator #10532 would be merged before this one
we tend to keep changes in dart-dio and dart-dio-next and dart in separate PRs
with removal of generated test files this is even more braking change, this risks deleting user developed tests

agilob · 2021-10-06T13:24:36Z

 }
 }
- return null;
+ return DateTime(1970);


user of this API can't distinguish between incorrect date and intentionally provided 1970

agilob · 2021-10-06T13:27:29Z


 final String name;
- final String value;
+ final String? value;


can query have name but no value? and for the line below, it has to be empty string not null string, as end user won't be able to distinguish intentional null string from no value. I think both fields should be not-null in this class

agilob · 2021-10-06T13:28:34Z

- String message;
- Exception innerException;
- StackTrace stackTrace;
+ String? message;


another design question, when does it make sense to raise ApiException without a message?

agilob · 2021-10-06T13:30:17Z


 {{#native_serialization}}
- static dynamic _deserialize(dynamic value, String targetType, {bool growable}) {
+ static dynamic _deserialize(dynamic value, String targetType, {bool? growable}) {


Would it make sense to make growable false or true by default? this would avoid doing growable == true a few times below, consider it micro-optimisation. I would also make it false, since other dart apis use immutable structures

agilob · 2021-10-06T13:30:50Z


 @Deprecated('Scheduled for removal in OpenAPI Generator 6.x. Use serializeAsync() instead.')
- String serialize(Object value) => value == null ? '' : json.encode(value);
+ String serialize(Object? value) => value == null ? '' : json.encode(value);


Does it ever make sense to serialise null object?

agilob · 2021-10-06T13:32:01Z

 class HttpBasicAuth implements Authentication {
- String username;
- String password;
+ String? username;


by making these not-null you will avoid defaulting to empty string below, another micro optimisation on our side

agilob · 2021-10-06T13:33:28Z

 OAuth({this.accessToken});

- String accessToken;
+ String? accessToken;


by making this not-null you will avoid null check below. does it make sense to use OAuth without access token? Technically yes, but practically that's a sec vuln on endpoint to accept empty code

agilob · 2021-10-06T13:49:00Z

 public String arrayModelType;
 public boolean isAlias; // Is this effectively an alias of another simple type
- public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isBoolean;
+ public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isPrimitiveType, isBoolean;


Is there really no other method for this already? Im really surprised this needs to be introduced as new code @wing328 ?

agilob · 2021-10-06T13:52:56Z

 {{/isArray}}
 {{/json_serializable}}
 }
- return Future<{{{returnType}}}>.value();


I think this was added recently to satisfy stricter linter config, so pls revert #10263

agilob · 2021-10-06T13:58:08Z

 List<QueryParam> queryParams,
- Object body,
+ Object? body,
 Map<String, String> headerParams,


headerParams and formParams are nullable in other openapi generators, so I would prefer to keep it this way for language agnostic users

agilob · 2021-10-06T13:58:49Z

 }
 if (value is Set && (match = _regSet.firstMatch(targetType)) != null) {
- targetType = match[1]; // ignore: parameter_assignments
+ targetType = match![1]!; // ignore: parameter_assignments


yea, that's better than my defauling to Object? 👍

agilob · 2021-10-19T16:49:38Z

This branch was only passing tests because github actions have not kicked in and many tests didn't run...

provokateurin · 2021-10-19T20:28:21Z

Sorry, at our company we decided it is currently not worth enough to fix the requested stuff but also the still missing stuff. Other people can you pickup these changes if they want to. Maybe we will come back to this, but currently it's not our plan to do so in a timely manner.

agilob · 2021-10-20T07:00:06Z

I've already rebased your branch and started fixing the above

agilob · 2021-10-27T13:21:00Z

Can you close this PR pls?

provokateurin · 2021-10-27T13:51:01Z

Sure!

agilob · 2021-10-27T13:55:22Z

#10637

provokateurin · 2021-10-06T12:52:58Z

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

I actually started working on this a few weeks ago, before any of the current PRs against the dart2 generator were made.
I'm unsure what to do now, but I want to put out my work, so that we can have a great dart2 generator.
Anyway I update the Dart version to the latest stable and thus implemented null-safety. I wasn't able to actually test the generated code yet, but there are no errors shown anymore (due to the project I'm generated a client for using oneOf).
I deleted the tests, because they didn't do anything at all and with null-safety there were errors because of uninitialized fields.

Related PRs:
#10532
#10536

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

agilob · 2021-10-06T13:23:00Z

This PR does more than adding null safety to dart generator, I think it should be split into a few smaller PRs. A few general comments:

I would go as far as dart 2.14, but something older, this might be too big change for some
ignore and remove all changes related to json_serializable, consider this generator gone. Ideally, [dart] json_serializable: remove experimental generator #10532 would be merged before this one
we tend to keep changes in dart-dio and dart-dio-next and dart in separate PRs
with removal of generated test files this is even more braking change, this risks deleting user developed tests

agilob · 2021-10-06T13:24:36Z

 }
 }
- return null;
+ return DateTime(1970);


user of this API can't distinguish between incorrect date and intentionally provided 1970

agilob · 2021-10-06T13:27:29Z


 final String name;
- final String value;
+ final String? value;


can query have name but no value? and for the line below, it has to be empty string not null string, as end user won't be able to distinguish intentional null string from no value. I think both fields should be not-null in this class

agilob · 2021-10-06T13:28:34Z

- String message;
- Exception innerException;
- StackTrace stackTrace;
+ String? message;


another design question, when does it make sense to raise ApiException without a message?

agilob · 2021-10-06T13:30:17Z


 {{#native_serialization}}
- static dynamic _deserialize(dynamic value, String targetType, {bool growable}) {
+ static dynamic _deserialize(dynamic value, String targetType, {bool? growable}) {


Would it make sense to make growable false or true by default? this would avoid doing growable == true a few times below, consider it micro-optimisation. I would also make it false, since other dart apis use immutable structures

agilob · 2021-10-06T13:30:50Z


 @Deprecated('Scheduled for removal in OpenAPI Generator 6.x. Use serializeAsync() instead.')
- String serialize(Object value) => value == null ? '' : json.encode(value);
+ String serialize(Object? value) => value == null ? '' : json.encode(value);


Does it ever make sense to serialise null object?

agilob · 2021-10-06T13:32:01Z

 class HttpBasicAuth implements Authentication {
- String username;
- String password;
+ String? username;


by making these not-null you will avoid defaulting to empty string below, another micro optimisation on our side

agilob · 2021-10-06T13:33:28Z

 OAuth({this.accessToken});

- String accessToken;
+ String? accessToken;


by making this not-null you will avoid null check below. does it make sense to use OAuth without access token? Technically yes, but practically that's a sec vuln on endpoint to accept empty code

agilob · 2021-10-06T13:49:00Z

 public String arrayModelType;
 public boolean isAlias; // Is this effectively an alias of another simple type
- public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isBoolean;
+ public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isPrimitiveType, isBoolean;


Is there really no other method for this already? Im really surprised this needs to be introduced as new code @wing328 ?

agilob · 2021-10-06T13:52:56Z

 {{/isArray}}
 {{/json_serializable}}
 }
- return Future<{{{returnType}}}>.value();


I think this was added recently to satisfy stricter linter config, so pls revert #10263

agilob · 2021-10-06T13:58:08Z

 List<QueryParam> queryParams,
- Object body,
+ Object? body,
 Map<String, String> headerParams,


headerParams and formParams are nullable in other openapi generators, so I would prefer to keep it this way for language agnostic users

agilob · 2021-10-06T13:58:49Z

 }
 if (value is Set && (match = _regSet.firstMatch(targetType)) != null) {
- targetType = match[1]; // ignore: parameter_assignments
+ targetType = match![1]!; // ignore: parameter_assignments


yea, that's better than my defauling to Object? 👍

agilob · 2021-10-19T16:49:38Z

This branch was only passing tests because github actions have not kicked in and many tests didn't run...

provokateurin · 2021-10-19T20:28:21Z

Sorry, at our company we decided it is currently not worth enough to fix the requested stuff but also the still missing stuff. Other people can you pickup these changes if they want to. Maybe we will come back to this, but currently it's not our plan to do so in a timely manner.

agilob · 2021-10-20T07:00:06Z

I've already rebased your branch and started fixing the above

agilob · 2021-10-27T13:21:00Z

Can you close this PR pls?

provokateurin · 2021-10-27T13:51:01Z

Sure!

agilob · 2021-10-27T13:55:22Z

#10637

provokateurin · 2021-10-06T12:52:58Z

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

I actually started working on this a few weeks ago, before any of the current PRs against the dart2 generator were made.
I'm unsure what to do now, but I want to put out my work, so that we can have a great dart2 generator.
Anyway I update the Dart version to the latest stable and thus implemented null-safety. I wasn't able to actually test the generated code yet, but there are no errors shown anymore (due to the project I'm generated a client for using oneOf).
I deleted the tests, because they didn't do anything at all and with null-safety there were errors because of uninitialized fields.

Related PRs:
#10532
#10536

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

agilob · 2021-10-06T13:23:00Z

This PR does more than adding null safety to dart generator, I think it should be split into a few smaller PRs. A few general comments:

I would go as far as dart 2.14, but something older, this might be too big change for some
ignore and remove all changes related to json_serializable, consider this generator gone. Ideally, [dart] json_serializable: remove experimental generator #10532 would be merged before this one
we tend to keep changes in dart-dio and dart-dio-next and dart in separate PRs
with removal of generated test files this is even more braking change, this risks deleting user developed tests

agilob · 2021-10-06T13:24:36Z

 }
 }
- return null;
+ return DateTime(1970);


user of this API can't distinguish between incorrect date and intentionally provided 1970

agilob · 2021-10-06T13:27:29Z


 final String name;
- final String value;
+ final String? value;


can query have name but no value? and for the line below, it has to be empty string not null string, as end user won't be able to distinguish intentional null string from no value. I think both fields should be not-null in this class

agilob · 2021-10-06T13:28:34Z

- String message;
- Exception innerException;
- StackTrace stackTrace;
+ String? message;


another design question, when does it make sense to raise ApiException without a message?

agilob · 2021-10-06T13:30:17Z


 {{#native_serialization}}
- static dynamic _deserialize(dynamic value, String targetType, {bool growable}) {
+ static dynamic _deserialize(dynamic value, String targetType, {bool? growable}) {


Would it make sense to make growable false or true by default? this would avoid doing growable == true a few times below, consider it micro-optimisation. I would also make it false, since other dart apis use immutable structures

agilob · 2021-10-06T13:30:50Z


 @Deprecated('Scheduled for removal in OpenAPI Generator 6.x. Use serializeAsync() instead.')
- String serialize(Object value) => value == null ? '' : json.encode(value);
+ String serialize(Object? value) => value == null ? '' : json.encode(value);


Does it ever make sense to serialise null object?

agilob · 2021-10-06T13:32:01Z

 class HttpBasicAuth implements Authentication {
- String username;
- String password;
+ String? username;


by making these not-null you will avoid defaulting to empty string below, another micro optimisation on our side

agilob · 2021-10-06T13:33:28Z

 OAuth({this.accessToken});

- String accessToken;
+ String? accessToken;


by making this not-null you will avoid null check below. does it make sense to use OAuth without access token? Technically yes, but practically that's a sec vuln on endpoint to accept empty code

agilob · 2021-10-06T13:49:00Z

 public String arrayModelType;
 public boolean isAlias; // Is this effectively an alias of another simple type
- public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isBoolean;
+ public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isPrimitiveType, isBoolean;


Is there really no other method for this already? Im really surprised this needs to be introduced as new code @wing328 ?

agilob · 2021-10-06T13:52:56Z

 {{/isArray}}
 {{/json_serializable}}
 }
- return Future<{{{returnType}}}>.value();


I think this was added recently to satisfy stricter linter config, so pls revert #10263

agilob · 2021-10-06T13:58:08Z

 List<QueryParam> queryParams,
- Object body,
+ Object? body,
 Map<String, String> headerParams,


headerParams and formParams are nullable in other openapi generators, so I would prefer to keep it this way for language agnostic users

agilob · 2021-10-06T13:58:49Z

 }
 if (value is Set && (match = _regSet.firstMatch(targetType)) != null) {
- targetType = match[1]; // ignore: parameter_assignments
+ targetType = match![1]!; // ignore: parameter_assignments


yea, that's better than my defauling to Object? 👍

agilob · 2021-10-19T16:49:38Z

This branch was only passing tests because github actions have not kicked in and many tests didn't run...

provokateurin · 2021-10-19T20:28:21Z

Sorry, at our company we decided it is currently not worth enough to fix the requested stuff but also the still missing stuff. Other people can you pickup these changes if they want to. Maybe we will come back to this, but currently it's not our plan to do so in a timely manner.

agilob · 2021-10-20T07:00:06Z

I've already rebased your branch and started fixing the above

agilob · 2021-10-27T13:21:00Z

Can you close this PR pls?

provokateurin · 2021-10-27T13:51:01Z

Sure!

agilob · 2021-10-27T13:55:22Z

#10637

provokateurin · 2021-10-06T12:52:58Z

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

I actually started working on this a few weeks ago, before any of the current PRs against the dart2 generator were made.
I'm unsure what to do now, but I want to put out my work, so that we can have a great dart2 generator.
Anyway I update the Dart version to the latest stable and thus implemented null-safety. I wasn't able to actually test the generated code yet, but there are no errors shown anymore (due to the project I'm generated a client for using oneOf).
I deleted the tests, because they didn't do anything at all and with null-safety there were errors because of uninitialized fields.

Related PRs:
#10532
#10536

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

agilob · 2021-10-06T13:23:00Z

This PR does more than adding null safety to dart generator, I think it should be split into a few smaller PRs. A few general comments:

I would go as far as dart 2.14, but something older, this might be too big change for some
ignore and remove all changes related to json_serializable, consider this generator gone. Ideally, [dart] json_serializable: remove experimental generator #10532 would be merged before this one
we tend to keep changes in dart-dio and dart-dio-next and dart in separate PRs
with removal of generated test files this is even more braking change, this risks deleting user developed tests

agilob · 2021-10-06T13:24:36Z

 }
 }
- return null;
+ return DateTime(1970);


user of this API can't distinguish between incorrect date and intentionally provided 1970

agilob · 2021-10-06T13:27:29Z


 final String name;
- final String value;
+ final String? value;


can query have name but no value? and for the line below, it has to be empty string not null string, as end user won't be able to distinguish intentional null string from no value. I think both fields should be not-null in this class

agilob · 2021-10-06T13:28:34Z

- String message;
- Exception innerException;
- StackTrace stackTrace;
+ String? message;


another design question, when does it make sense to raise ApiException without a message?

agilob · 2021-10-06T13:30:17Z


 {{#native_serialization}}
- static dynamic _deserialize(dynamic value, String targetType, {bool growable}) {
+ static dynamic _deserialize(dynamic value, String targetType, {bool? growable}) {


Would it make sense to make growable false or true by default? this would avoid doing growable == true a few times below, consider it micro-optimisation. I would also make it false, since other dart apis use immutable structures

agilob · 2021-10-06T13:30:50Z


 @Deprecated('Scheduled for removal in OpenAPI Generator 6.x. Use serializeAsync() instead.')
- String serialize(Object value) => value == null ? '' : json.encode(value);
+ String serialize(Object? value) => value == null ? '' : json.encode(value);


Does it ever make sense to serialise null object?

agilob · 2021-10-06T13:32:01Z

 class HttpBasicAuth implements Authentication {
- String username;
- String password;
+ String? username;


by making these not-null you will avoid defaulting to empty string below, another micro optimisation on our side

agilob · 2021-10-06T13:33:28Z

 OAuth({this.accessToken});

- String accessToken;
+ String? accessToken;


by making this not-null you will avoid null check below. does it make sense to use OAuth without access token? Technically yes, but practically that's a sec vuln on endpoint to accept empty code

agilob · 2021-10-06T13:49:00Z

 public String arrayModelType;
 public boolean isAlias; // Is this effectively an alias of another simple type
- public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isBoolean;
+ public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isPrimitiveType, isBoolean;


Is there really no other method for this already? Im really surprised this needs to be introduced as new code @wing328 ?

agilob · 2021-10-06T13:52:56Z

 {{/isArray}}
 {{/json_serializable}}
 }
- return Future<{{{returnType}}}>.value();


I think this was added recently to satisfy stricter linter config, so pls revert #10263

agilob · 2021-10-06T13:58:08Z

 List<QueryParam> queryParams,
- Object body,
+ Object? body,
 Map<String, String> headerParams,


headerParams and formParams are nullable in other openapi generators, so I would prefer to keep it this way for language agnostic users

agilob · 2021-10-06T13:58:49Z

 }
 if (value is Set && (match = _regSet.firstMatch(targetType)) != null) {
- targetType = match[1]; // ignore: parameter_assignments
+ targetType = match![1]!; // ignore: parameter_assignments


yea, that's better than my defauling to Object? 👍

agilob · 2021-10-19T16:49:38Z

This branch was only passing tests because github actions have not kicked in and many tests didn't run...

provokateurin · 2021-10-19T20:28:21Z

Sorry, at our company we decided it is currently not worth enough to fix the requested stuff but also the still missing stuff. Other people can you pickup these changes if they want to. Maybe we will come back to this, but currently it's not our plan to do so in a timely manner.

agilob · 2021-10-20T07:00:06Z

I've already rebased your branch and started fixing the above

agilob · 2021-10-27T13:21:00Z

Can you close this PR pls?

provokateurin · 2021-10-27T13:51:01Z

Sure!

agilob · 2021-10-27T13:55:22Z

#10637

provokateurin · 2021-10-06T12:52:58Z

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

I actually started working on this a few weeks ago, before any of the current PRs against the dart2 generator were made.
I'm unsure what to do now, but I want to put out my work, so that we can have a great dart2 generator.
Anyway I update the Dart version to the latest stable and thus implemented null-safety. I wasn't able to actually test the generated code yet, but there are no errors shown anymore (due to the project I'm generated a client for using oneOf).
I deleted the tests, because they didn't do anything at all and with null-safety there were errors because of uninitialized fields.

Related PRs:
#10532
#10536

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

agilob · 2021-10-06T13:23:00Z

This PR does more than adding null safety to dart generator, I think it should be split into a few smaller PRs. A few general comments:

I would go as far as dart 2.14, but something older, this might be too big change for some
ignore and remove all changes related to json_serializable, consider this generator gone. Ideally, [dart] json_serializable: remove experimental generator #10532 would be merged before this one
we tend to keep changes in dart-dio and dart-dio-next and dart in separate PRs
with removal of generated test files this is even more braking change, this risks deleting user developed tests

agilob · 2021-10-06T13:24:36Z

 }
 }
- return null;
+ return DateTime(1970);


user of this API can't distinguish between incorrect date and intentionally provided 1970

agilob · 2021-10-06T13:27:29Z


 final String name;
- final String value;
+ final String? value;


can query have name but no value? and for the line below, it has to be empty string not null string, as end user won't be able to distinguish intentional null string from no value. I think both fields should be not-null in this class

agilob · 2021-10-06T13:28:34Z

- String message;
- Exception innerException;
- StackTrace stackTrace;
+ String? message;


another design question, when does it make sense to raise ApiException without a message?

agilob · 2021-10-06T13:30:17Z


 {{#native_serialization}}
- static dynamic _deserialize(dynamic value, String targetType, {bool growable}) {
+ static dynamic _deserialize(dynamic value, String targetType, {bool? growable}) {


Would it make sense to make growable false or true by default? this would avoid doing growable == true a few times below, consider it micro-optimisation. I would also make it false, since other dart apis use immutable structures

agilob · 2021-10-06T13:30:50Z


 @Deprecated('Scheduled for removal in OpenAPI Generator 6.x. Use serializeAsync() instead.')
- String serialize(Object value) => value == null ? '' : json.encode(value);
+ String serialize(Object? value) => value == null ? '' : json.encode(value);


Does it ever make sense to serialise null object?

agilob · 2021-10-06T13:32:01Z

 class HttpBasicAuth implements Authentication {
- String username;
- String password;
+ String? username;


by making these not-null you will avoid defaulting to empty string below, another micro optimisation on our side

agilob · 2021-10-06T13:33:28Z

 OAuth({this.accessToken});

- String accessToken;
+ String? accessToken;


by making this not-null you will avoid null check below. does it make sense to use OAuth without access token? Technically yes, but practically that's a sec vuln on endpoint to accept empty code

agilob · 2021-10-06T13:49:00Z

 public String arrayModelType;
 public boolean isAlias; // Is this effectively an alias of another simple type
- public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isBoolean;
+ public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isPrimitiveType, isBoolean;


Is there really no other method for this already? Im really surprised this needs to be introduced as new code @wing328 ?

agilob · 2021-10-06T13:52:56Z

 {{/isArray}}
 {{/json_serializable}}
 }
- return Future<{{{returnType}}}>.value();


I think this was added recently to satisfy stricter linter config, so pls revert #10263

agilob · 2021-10-06T13:58:08Z

 List<QueryParam> queryParams,
- Object body,
+ Object? body,
 Map<String, String> headerParams,


headerParams and formParams are nullable in other openapi generators, so I would prefer to keep it this way for language agnostic users

agilob · 2021-10-06T13:58:49Z

 }
 if (value is Set && (match = _regSet.firstMatch(targetType)) != null) {
- targetType = match[1]; // ignore: parameter_assignments
+ targetType = match![1]!; // ignore: parameter_assignments


yea, that's better than my defauling to Object? 👍

agilob · 2021-10-19T16:49:38Z

This branch was only passing tests because github actions have not kicked in and many tests didn't run...

provokateurin · 2021-10-19T20:28:21Z

Sorry, at our company we decided it is currently not worth enough to fix the requested stuff but also the still missing stuff. Other people can you pickup these changes if they want to. Maybe we will come back to this, but currently it's not our plan to do so in a timely manner.

agilob · 2021-10-20T07:00:06Z

I've already rebased your branch and started fixing the above

agilob · 2021-10-27T13:21:00Z

Can you close this PR pls?

provokateurin · 2021-10-27T13:51:01Z

Sure!

agilob · 2021-10-27T13:55:22Z

#10637

provokateurin · 2021-10-06T12:52:58Z

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

I actually started working on this a few weeks ago, before any of the current PRs against the dart2 generator were made.
I'm unsure what to do now, but I want to put out my work, so that we can have a great dart2 generator.
Anyway I update the Dart version to the latest stable and thus implemented null-safety. I wasn't able to actually test the generated code yet, but there are no errors shown anymore (due to the project I'm generated a client for using oneOf).
I deleted the tests, because they didn't do anything at all and with null-safety there were errors because of uninitialized fields.

Related PRs:
#10532
#10536

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

agilob · 2021-10-06T13:23:00Z

This PR does more than adding null safety to dart generator, I think it should be split into a few smaller PRs. A few general comments:

I would go as far as dart 2.14, but something older, this might be too big change for some
ignore and remove all changes related to json_serializable, consider this generator gone. Ideally, [dart] json_serializable: remove experimental generator #10532 would be merged before this one
we tend to keep changes in dart-dio and dart-dio-next and dart in separate PRs
with removal of generated test files this is even more braking change, this risks deleting user developed tests

agilob · 2021-10-06T13:24:36Z

 }
 }
- return null;
+ return DateTime(1970);


user of this API can't distinguish between incorrect date and intentionally provided 1970

agilob · 2021-10-06T13:27:29Z


 final String name;
- final String value;
+ final String? value;


can query have name but no value? and for the line below, it has to be empty string not null string, as end user won't be able to distinguish intentional null string from no value. I think both fields should be not-null in this class

agilob · 2021-10-06T13:28:34Z

- String message;
- Exception innerException;
- StackTrace stackTrace;
+ String? message;


another design question, when does it make sense to raise ApiException without a message?

agilob · 2021-10-06T13:30:17Z


 {{#native_serialization}}
- static dynamic _deserialize(dynamic value, String targetType, {bool growable}) {
+ static dynamic _deserialize(dynamic value, String targetType, {bool? growable}) {


Would it make sense to make growable false or true by default? this would avoid doing growable == true a few times below, consider it micro-optimisation. I would also make it false, since other dart apis use immutable structures

agilob · 2021-10-06T13:30:50Z


 @Deprecated('Scheduled for removal in OpenAPI Generator 6.x. Use serializeAsync() instead.')
- String serialize(Object value) => value == null ? '' : json.encode(value);
+ String serialize(Object? value) => value == null ? '' : json.encode(value);


Does it ever make sense to serialise null object?

agilob · 2021-10-06T13:32:01Z

 class HttpBasicAuth implements Authentication {
- String username;
- String password;
+ String? username;


by making these not-null you will avoid defaulting to empty string below, another micro optimisation on our side

agilob · 2021-10-06T13:33:28Z

 OAuth({this.accessToken});

- String accessToken;
+ String? accessToken;


by making this not-null you will avoid null check below. does it make sense to use OAuth without access token? Technically yes, but practically that's a sec vuln on endpoint to accept empty code

agilob · 2021-10-06T13:49:00Z

 public String arrayModelType;
 public boolean isAlias; // Is this effectively an alias of another simple type
- public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isBoolean;
+ public boolean isString, isInteger, isLong, isNumber, isNumeric, isFloat, isDouble, isDate, isDateTime, isShort, isUnboundedInteger, isPrimitiveType, isBoolean;


Is there really no other method for this already? Im really surprised this needs to be introduced as new code @wing328 ?

agilob · 2021-10-06T13:52:56Z

 {{/isArray}}
 {{/json_serializable}}
 }
- return Future<{{{returnType}}}>.value();


I think this was added recently to satisfy stricter linter config, so pls revert #10263

agilob · 2021-10-06T13:58:08Z

 List<QueryParam> queryParams,
- Object body,
+ Object? body,
 Map<String, String> headerParams,


headerParams and formParams are nullable in other openapi generators, so I would prefer to keep it this way for language agnostic users

agilob · 2021-10-06T13:58:49Z

 }
 if (value is Set && (match = _regSet.firstMatch(targetType)) != null) {
- targetType = match[1]; // ignore: parameter_assignments
+ targetType = match![1]!; // ignore: parameter_assignments


yea, that's better than my defauling to Object? 👍

agilob · 2021-10-19T16:49:38Z

This branch was only passing tests because github actions have not kicked in and many tests didn't run...

provokateurin · 2021-10-19T20:28:21Z

Sorry, at our company we decided it is currently not worth enough to fix the requested stuff but also the still missing stuff. Other people can you pickup these changes if they want to. Maybe we will come back to this, but currently it's not our plan to do so in a timely manner.

agilob · 2021-10-20T07:00:06Z

I've already rebased your branch and started fixing the above

agilob · 2021-10-27T13:21:00Z

Can you close this PR pls?

provokateurin · 2021-10-27T13:51:01Z

Sure!

agilob · 2021-10-27T13:55:22Z

#10637

Kate Döen added 2 commits October 6, 2021 14:36

fix: Make dart2 generated code compilable
a1d65f4

Update dart2 client samples
7444a10

agilob reviewed Oct 6, 2021
View reviewed changes

provokateurin closed this Oct 27, 2021

wing328 mentioned this pull request Apr 6, 2023
[REQ][python-nextgen] Allow integers as numbers when no format is set #15098
Closed

Kate Döen added 2 commits October 6, 2021 14:36

fix: Make dart2 generated code compilable
a1d65f4

Update dart2 client samples
7444a10

agilob reviewed Oct 6, 2021
View reviewed changes

provokateurin closed this Oct 27, 2021

wing328 mentioned this pull request Apr 6, 2023
[REQ][python-nextgen] Allow integers as numbers when no format is set #15098
Closed

Kate Döen added 2 commits October 6, 2021 14:36

fix: Make dart2 generated code compilable
a1d65f4

Update dart2 client samples
7444a10

agilob reviewed Oct 6, 2021
View reviewed changes

provokateurin closed this Oct 27, 2021

wing328 mentioned this pull request Apr 6, 2023
[REQ][python-nextgen] Allow integers as numbers when no format is set #15098
Closed

Kate Döen added 2 commits October 6, 2021 14:36

fix: Make dart2 generated code compilable
a1d65f4

Update dart2 client samples
7444a10

agilob reviewed Oct 6, 2021
View reviewed changes

provokateurin closed this Oct 27, 2021

wing328 mentioned this pull request Apr 6, 2023
[REQ][python-nextgen] Allow integers as numbers when no format is set #15098
Closed

Kate Döen added 2 commits October 6, 2021 14:36

fix: Make dart2 generated code compilable
a1d65f4

Update dart2 client samples
7444a10

agilob reviewed Oct 6, 2021
View reviewed changes

provokateurin closed this Oct 27, 2021

wing328 mentioned this pull request Apr 6, 2023
[REQ][python-nextgen] Allow integers as numbers when no format is set #15098
Closed

Kate Döen added 2 commits October 6, 2021 14:36

fix: Make dart2 generated code compilable
a1d65f4

Update dart2 client samples
7444a10

agilob reviewed Oct 6, 2021
View reviewed changes

provokateurin closed this Oct 27, 2021

wing328 mentioned this pull request Apr 6, 2023
[REQ][python-nextgen] Allow integers as numbers when no format is set #15098
Closed

Kate Döen added 2 commits October 6, 2021 14:36

fix: Make dart2 generated code compilable
a1d65f4

Update dart2 client samples
7444a10

agilob reviewed Oct 6, 2021
View reviewed changes

provokateurin closed this Oct 27, 2021

wing328 mentioned this pull request Apr 6, 2023
[REQ][python-nextgen] Allow integers as numbers when no format is set #15098
Closed

Kate Döen added 2 commits October 6, 2021 14:36

fix: Make dart2 generated code compilable
a1d65f4

Update dart2 client samples
7444a10

agilob reviewed Oct 6, 2021
View reviewed changes

provokateurin closed this Oct 27, 2021

wing328 mentioned this pull request Apr 6, 2023
[REQ][python-nextgen] Allow integers as numbers when no format is set #15098
Closed

Uh oh!

Uh oh!

Conversation

provokateurin commented Oct 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

agilob commented Oct 6, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agilobOct 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agilobOct 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agilob commented Oct 19, 2021

Uh oh!

provokateurin commented Oct 19, 2021

Uh oh!

agilob commented Oct 20, 2021

Uh oh!

agilob commented Oct 27, 2021

Uh oh!

provokateurin commented Oct 27, 2021

Uh oh!

agilob commented Oct 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

provokateurin commented Oct 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

agilob commented Oct 6, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agilobOct 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agilobOct 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

provokateurin commented Oct 6, 2021•
edited
Loading

agilobOct 6, 2021•
edited
Loading

agilobOct 6, 2021•
edited
Loading

provokateurin commented Oct 6, 2021•
edited
Loading

agilobOct 6, 2021•
edited
Loading

agilobOct 6, 2021•
edited
Loading

provokateurin commented Oct 6, 2021•
edited
Loading