[crystal][client] Add param default values to method definitions and refactor methods to use only keyword args if the method has more than one param by cyangle · Pull Request #10673 · OpenAPITools/openapi-generator

cyangle · 2021-10-24T00:16:51Z

@wing328 This PR mainly refactored how it handles nillable and nullable types and default values. I got some ideas from the kotlin-client sample code
The breaking change is the requirement of keyword argument invoking style of methods which is needed to support setting default values
last in order is required for setting default values to positional params but it's not required in keyword args

There are other minor fixes. Check the details listed below, and you should also check the commit messages.

Refactor methods to use keyword args if the method has more than one param
Add default values to method definitions and model initializers
Add boolean flag hasOnlyOneParam - sets to true when the method has only one param
Handle empty collection param
Handle conversion to string from non file and non string types
Refactor model with nilable types - Inspiration from kotlin-client code samples
Refactor model initializers to support only keyword args
Add profile crystal-client to pom.xml
Clean up gitignore.mustache
Change deprecated URI.encode to URI.encode_path
Fix tests in file samples/client/petstore/crystal/spec/api/pet_api_spec.cr

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cyangle · 2021-10-26T13:26:55Z

I'm breaking this PR into smaller ones

@name

You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

It would be convenient to allow calling a method using keyward arg and also positional arg when there is only one paramter def one_param_method(name : String) puts name end one_param_method(name: "Pet") one_param_method("Pet") When there are more than one param, the methond only supports invoking with keyword arguments: def two_param_method(*, name : String = "Pet", age : Int32) puts "#{name} is #{age} years old" end two_param_method(age: 3) # => Pet is 3 years old two_param_method("Pet", 3) # => Compilation Error: missing arguments: name, age

…has one param

only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

Handle file param separately to simplify to make it more readable

cyangle · 2021-10-28T13:33:52Z

#10721 is extracted from this PR

wing328 · 2022-05-04T16:56:16Z

@cyangle closing this one for the time being. Please file a new one if needed. Thanks.

cyangle · 2021-10-24T00:16:51Z

@wing328 This PR mainly refactored how it handles nillable and nullable types and default values. I got some ideas from the kotlin-client sample code
The breaking change is the requirement of keyword argument invoking style of methods which is needed to support setting default values
last in order is required for setting default values to positional params but it's not required in keyword args

There are other minor fixes. Check the details listed below, and you should also check the commit messages.

Refactor methods to use keyword args if the method has more than one param
Add default values to method definitions and model initializers
Add boolean flag hasOnlyOneParam - sets to true when the method has only one param
Handle empty collection param
Handle conversion to string from non file and non string types
Refactor model with nilable types - Inspiration from kotlin-client code samples
Refactor model initializers to support only keyword args
Add profile crystal-client to pom.xml
Clean up gitignore.mustache
Change deprecated URI.encode to URI.encode_path
Fix tests in file samples/client/petstore/crystal/spec/api/pet_api_spec.cr

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cyangle · 2021-10-26T13:26:55Z

I'm breaking this PR into smaller ones

@name

You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

It would be convenient to allow calling a method using keyward arg and also positional arg when there is only one paramter def one_param_method(name : String) puts name end one_param_method(name: "Pet") one_param_method("Pet") When there are more than one param, the methond only supports invoking with keyword arguments: def two_param_method(*, name : String = "Pet", age : Int32) puts "#{name} is #{age} years old" end two_param_method(age: 3) # => Pet is 3 years old two_param_method("Pet", 3) # => Compilation Error: missing arguments: name, age

…has one param

only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

Handle file param separately to simplify to make it more readable

cyangle · 2021-10-28T13:33:52Z

#10721 is extracted from this PR

wing328 · 2022-05-04T16:56:16Z

@cyangle closing this one for the time being. Please file a new one if needed. Thanks.

cyangle · 2021-10-24T00:16:51Z

@wing328 This PR mainly refactored how it handles nillable and nullable types and default values. I got some ideas from the kotlin-client sample code
The breaking change is the requirement of keyword argument invoking style of methods which is needed to support setting default values
last in order is required for setting default values to positional params but it's not required in keyword args

There are other minor fixes. Check the details listed below, and you should also check the commit messages.

Refactor methods to use keyword args if the method has more than one param
Add default values to method definitions and model initializers
Add boolean flag hasOnlyOneParam - sets to true when the method has only one param
Handle empty collection param
Handle conversion to string from non file and non string types
Refactor model with nilable types - Inspiration from kotlin-client code samples
Refactor model initializers to support only keyword args
Add profile crystal-client to pom.xml
Clean up gitignore.mustache
Change deprecated URI.encode to URI.encode_path
Fix tests in file samples/client/petstore/crystal/spec/api/pet_api_spec.cr

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cyangle · 2021-10-26T13:26:55Z

I'm breaking this PR into smaller ones

@name

You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

It would be convenient to allow calling a method using keyward arg and also positional arg when there is only one paramter def one_param_method(name : String) puts name end one_param_method(name: "Pet") one_param_method("Pet") When there are more than one param, the methond only supports invoking with keyword arguments: def two_param_method(*, name : String = "Pet", age : Int32) puts "#{name} is #{age} years old" end two_param_method(age: 3) # => Pet is 3 years old two_param_method("Pet", 3) # => Compilation Error: missing arguments: name, age

…has one param

only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

Handle file param separately to simplify to make it more readable

cyangle · 2021-10-28T13:33:52Z

#10721 is extracted from this PR

wing328 · 2022-05-04T16:56:16Z

@cyangle closing this one for the time being. Please file a new one if needed. Thanks.

cyangle · 2021-10-24T00:16:51Z

@wing328 This PR mainly refactored how it handles nillable and nullable types and default values. I got some ideas from the kotlin-client sample code
The breaking change is the requirement of keyword argument invoking style of methods which is needed to support setting default values
last in order is required for setting default values to positional params but it's not required in keyword args

There are other minor fixes. Check the details listed below, and you should also check the commit messages.

Refactor methods to use keyword args if the method has more than one param
Add default values to method definitions and model initializers
Add boolean flag hasOnlyOneParam - sets to true when the method has only one param
Handle empty collection param
Handle conversion to string from non file and non string types
Refactor model with nilable types - Inspiration from kotlin-client code samples
Refactor model initializers to support only keyword args
Add profile crystal-client to pom.xml
Clean up gitignore.mustache
Change deprecated URI.encode to URI.encode_path
Fix tests in file samples/client/petstore/crystal/spec/api/pet_api_spec.cr

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cyangle · 2021-10-26T13:26:55Z

I'm breaking this PR into smaller ones

@name

You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

It would be convenient to allow calling a method using keyward arg and also positional arg when there is only one paramter def one_param_method(name : String) puts name end one_param_method(name: "Pet") one_param_method("Pet") When there are more than one param, the methond only supports invoking with keyword arguments: def two_param_method(*, name : String = "Pet", age : Int32) puts "#{name} is #{age} years old" end two_param_method(age: 3) # => Pet is 3 years old two_param_method("Pet", 3) # => Compilation Error: missing arguments: name, age

…has one param

only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

Handle file param separately to simplify to make it more readable

cyangle · 2021-10-28T13:33:52Z

#10721 is extracted from this PR

wing328 · 2022-05-04T16:56:16Z

@cyangle closing this one for the time being. Please file a new one if needed. Thanks.

cyangle · 2021-10-24T00:16:51Z

@wing328 This PR mainly refactored how it handles nillable and nullable types and default values. I got some ideas from the kotlin-client sample code
The breaking change is the requirement of keyword argument invoking style of methods which is needed to support setting default values
last in order is required for setting default values to positional params but it's not required in keyword args

There are other minor fixes. Check the details listed below, and you should also check the commit messages.

Refactor methods to use keyword args if the method has more than one param
Add default values to method definitions and model initializers
Add boolean flag hasOnlyOneParam - sets to true when the method has only one param
Handle empty collection param
Handle conversion to string from non file and non string types
Refactor model with nilable types - Inspiration from kotlin-client code samples
Refactor model initializers to support only keyword args
Add profile crystal-client to pom.xml
Clean up gitignore.mustache
Change deprecated URI.encode to URI.encode_path
Fix tests in file samples/client/petstore/crystal/spec/api/pet_api_spec.cr

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cyangle · 2021-10-26T13:26:55Z

I'm breaking this PR into smaller ones

@name

You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

It would be convenient to allow calling a method using keyward arg and also positional arg when there is only one paramter def one_param_method(name : String) puts name end one_param_method(name: "Pet") one_param_method("Pet") When there are more than one param, the methond only supports invoking with keyword arguments: def two_param_method(*, name : String = "Pet", age : Int32) puts "#{name} is #{age} years old" end two_param_method(age: 3) # => Pet is 3 years old two_param_method("Pet", 3) # => Compilation Error: missing arguments: name, age

…has one param

only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

Handle file param separately to simplify to make it more readable

cyangle · 2021-10-28T13:33:52Z

#10721 is extracted from this PR

wing328 · 2022-05-04T16:56:16Z

@cyangle closing this one for the time being. Please file a new one if needed. Thanks.

cyangle · 2021-10-24T00:16:51Z

@wing328 This PR mainly refactored how it handles nillable and nullable types and default values. I got some ideas from the kotlin-client sample code
The breaking change is the requirement of keyword argument invoking style of methods which is needed to support setting default values
last in order is required for setting default values to positional params but it's not required in keyword args

There are other minor fixes. Check the details listed below, and you should also check the commit messages.

Refactor methods to use keyword args if the method has more than one param
Add default values to method definitions and model initializers
Add boolean flag hasOnlyOneParam - sets to true when the method has only one param
Handle empty collection param
Handle conversion to string from non file and non string types
Refactor model with nilable types - Inspiration from kotlin-client code samples
Refactor model initializers to support only keyword args
Add profile crystal-client to pom.xml
Clean up gitignore.mustache
Change deprecated URI.encode to URI.encode_path
Fix tests in file samples/client/petstore/crystal/spec/api/pet_api_spec.cr

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cyangle · 2021-10-26T13:26:55Z

I'm breaking this PR into smaller ones

@name

You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

It would be convenient to allow calling a method using keyward arg and also positional arg when there is only one paramter def one_param_method(name : String) puts name end one_param_method(name: "Pet") one_param_method("Pet") When there are more than one param, the methond only supports invoking with keyword arguments: def two_param_method(*, name : String = "Pet", age : Int32) puts "#{name} is #{age} years old" end two_param_method(age: 3) # => Pet is 3 years old two_param_method("Pet", 3) # => Compilation Error: missing arguments: name, age

…has one param

only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

Handle file param separately to simplify to make it more readable

cyangle · 2021-10-28T13:33:52Z

#10721 is extracted from this PR

wing328 · 2022-05-04T16:56:16Z

@cyangle closing this one for the time being. Please file a new one if needed. Thanks.

cyangle · 2021-10-24T00:16:51Z

@wing328 This PR mainly refactored how it handles nillable and nullable types and default values. I got some ideas from the kotlin-client sample code
The breaking change is the requirement of keyword argument invoking style of methods which is needed to support setting default values
last in order is required for setting default values to positional params but it's not required in keyword args

There are other minor fixes. Check the details listed below, and you should also check the commit messages.

Refactor methods to use keyword args if the method has more than one param
Add default values to method definitions and model initializers
Add boolean flag hasOnlyOneParam - sets to true when the method has only one param
Handle empty collection param
Handle conversion to string from non file and non string types
Refactor model with nilable types - Inspiration from kotlin-client code samples
Refactor model initializers to support only keyword args
Add profile crystal-client to pom.xml
Clean up gitignore.mustache
Change deprecated URI.encode to URI.encode_path
Fix tests in file samples/client/petstore/crystal/spec/api/pet_api_spec.cr

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cyangle · 2021-10-26T13:26:55Z

I'm breaking this PR into smaller ones

@name

You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

It would be convenient to allow calling a method using keyward arg and also positional arg when there is only one paramter def one_param_method(name : String) puts name end one_param_method(name: "Pet") one_param_method("Pet") When there are more than one param, the methond only supports invoking with keyword arguments: def two_param_method(*, name : String = "Pet", age : Int32) puts "#{name} is #{age} years old" end two_param_method(age: 3) # => Pet is 3 years old two_param_method("Pet", 3) # => Compilation Error: missing arguments: name, age

…has one param

only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

Handle file param separately to simplify to make it more readable

cyangle · 2021-10-28T13:33:52Z

#10721 is extracted from this PR

wing328 · 2022-05-04T16:56:16Z

@cyangle closing this one for the time being. Please file a new one if needed. Thanks.

cyangle · 2021-10-24T00:16:51Z

@wing328 This PR mainly refactored how it handles nillable and nullable types and default values. I got some ideas from the kotlin-client sample code
The breaking change is the requirement of keyword argument invoking style of methods which is needed to support setting default values
last in order is required for setting default values to positional params but it's not required in keyword args

There are other minor fixes. Check the details listed below, and you should also check the commit messages.

Refactor methods to use keyword args if the method has more than one param
Add default values to method definitions and model initializers
Add boolean flag hasOnlyOneParam - sets to true when the method has only one param
Handle empty collection param
Handle conversion to string from non file and non string types
Refactor model with nilable types - Inspiration from kotlin-client code samples
Refactor model initializers to support only keyword args
Add profile crystal-client to pom.xml
Clean up gitignore.mustache
Change deprecated URI.encode to URI.encode_path
Fix tests in file samples/client/petstore/crystal/spec/api/pet_api_spec.cr

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cyangle · 2021-10-26T13:26:55Z

I'm breaking this PR into smaller ones

@name

You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

It would be convenient to allow calling a method using keyward arg and also positional arg when there is only one paramter def one_param_method(name : String) puts name end one_param_method(name: "Pet") one_param_method("Pet") When there are more than one param, the methond only supports invoking with keyword arguments: def two_param_method(*, name : String = "Pet", age : Int32) puts "#{name} is #{age} years old" end two_param_method(age: 3) # => Pet is 3 years old two_param_method("Pet", 3) # => Compilation Error: missing arguments: name, age

…has one param

only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

Handle file param separately to simplify to make it more readable

cyangle · 2021-10-28T13:33:52Z

#10721 is extracted from this PR

wing328 · 2022-05-04T16:56:16Z

@cyangle closing this one for the time being. Please file a new one if needed. Thanks.

cyangle mentioned this pull request Oct 24, 2021
Enhancement to the Crystal client generator #8363
Open

cyangle mentioned this pull request Oct 26, 2021
[crystal][client][closes #10696] Update crystal client gitignore.mustache with shards related files #10698
Merged
5 tasks

cyangle added 8 commits October 27, 2021 20:35

Add default value support and make optional args default to nil
55c63fc

Refresh generated sample code for crystal
bb2da89

Add crystal-client profile to pom.xml
a31d532

Use keyword arguments by default
39145bf
You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

Allow invoking methods with positional argument when the method only …
697cb61
…has one param

Fix required vs nullable in model
2ab36f2
only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

simplify param serializations and handles file param
09f63ea
Handle file param separately to simplify to make it more readable

cyangle force-pushed the nil_as_default_for_optional_args branch from 8b98d55 to 09f63eaCompare October 28, 2021 01:37

cyangle marked this pull request as draft October 30, 2021 14:55

wing328 closed this May 4, 2022

cyangle mentioned this pull request Oct 24, 2021
Enhancement to the Crystal client generator #8363
Open

cyangle mentioned this pull request Oct 26, 2021
[crystal][client][closes #10696] Update crystal client gitignore.mustache with shards related files #10698
Merged
5 tasks

cyangle added 8 commits October 27, 2021 20:35

Add default value support and make optional args default to nil
55c63fc

Refresh generated sample code for crystal
bb2da89

Add crystal-client profile to pom.xml
a31d532

Use keyword arguments by default
39145bf
You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

Allow invoking methods with positional argument when the method only …
697cb61
…has one param

Fix required vs nullable in model
2ab36f2
only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

simplify param serializations and handles file param
09f63ea
Handle file param separately to simplify to make it more readable

cyangle force-pushed the nil_as_default_for_optional_args branch from 8b98d55 to 09f63eaCompare October 28, 2021 01:37

cyangle marked this pull request as draft October 30, 2021 14:55

wing328 closed this May 4, 2022

cyangle mentioned this pull request Oct 24, 2021
Enhancement to the Crystal client generator #8363
Open

cyangle mentioned this pull request Oct 26, 2021
[crystal][client][closes #10696] Update crystal client gitignore.mustache with shards related files #10698
Merged
5 tasks

cyangle added 8 commits October 27, 2021 20:35

Add default value support and make optional args default to nil
55c63fc

Refresh generated sample code for crystal
bb2da89

Add crystal-client profile to pom.xml
a31d532

Use keyword arguments by default
39145bf
You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

Allow invoking methods with positional argument when the method only …
697cb61
…has one param

Fix required vs nullable in model
2ab36f2
only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

simplify param serializations and handles file param
09f63ea
Handle file param separately to simplify to make it more readable

cyangle force-pushed the nil_as_default_for_optional_args branch from 8b98d55 to 09f63eaCompare October 28, 2021 01:37

cyangle marked this pull request as draft October 30, 2021 14:55

wing328 closed this May 4, 2022

cyangle mentioned this pull request Oct 24, 2021
Enhancement to the Crystal client generator #8363
Open

cyangle mentioned this pull request Oct 26, 2021
[crystal][client][closes #10696] Update crystal client gitignore.mustache with shards related files #10698
Merged
5 tasks

cyangle added 8 commits October 27, 2021 20:35

Add default value support and make optional args default to nil
55c63fc

Refresh generated sample code for crystal
bb2da89

Add crystal-client profile to pom.xml
a31d532

Use keyword arguments by default
39145bf
You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

Allow invoking methods with positional argument when the method only …
697cb61
…has one param

Fix required vs nullable in model
2ab36f2
only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

simplify param serializations and handles file param
09f63ea
Handle file param separately to simplify to make it more readable

cyangle force-pushed the nil_as_default_for_optional_args branch from 8b98d55 to 09f63eaCompare October 28, 2021 01:37

cyangle marked this pull request as draft October 30, 2021 14:55

wing328 closed this May 4, 2022

cyangle mentioned this pull request Oct 24, 2021
Enhancement to the Crystal client generator #8363
Open

cyangle mentioned this pull request Oct 26, 2021
[crystal][client][closes #10696] Update crystal client gitignore.mustache with shards related files #10698
Merged
5 tasks

cyangle added 8 commits October 27, 2021 20:35

Add default value support and make optional args default to nil
55c63fc

Refresh generated sample code for crystal
bb2da89

Add crystal-client profile to pom.xml
a31d532

Use keyword arguments by default
39145bf
You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

Allow invoking methods with positional argument when the method only …
697cb61
…has one param

Fix required vs nullable in model
2ab36f2
only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

simplify param serializations and handles file param
09f63ea
Handle file param separately to simplify to make it more readable

cyangle force-pushed the nil_as_default_for_optional_args branch from 8b98d55 to 09f63eaCompare October 28, 2021 01:37

cyangle marked this pull request as draft October 30, 2021 14:55

wing328 closed this May 4, 2022

cyangle mentioned this pull request Oct 24, 2021
Enhancement to the Crystal client generator #8363
Open

cyangle mentioned this pull request Oct 26, 2021
[crystal][client][closes #10696] Update crystal client gitignore.mustache with shards related files #10698
Merged
5 tasks

cyangle added 8 commits October 27, 2021 20:35

Add default value support and make optional args default to nil
55c63fc

Refresh generated sample code for crystal
bb2da89

Add crystal-client profile to pom.xml
a31d532

Use keyword arguments by default
39145bf
You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

Allow invoking methods with positional argument when the method only …
697cb61
…has one param

Fix required vs nullable in model
2ab36f2
only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

simplify param serializations and handles file param
09f63ea
Handle file param separately to simplify to make it more readable

cyangle force-pushed the nil_as_default_for_optional_args branch from 8b98d55 to 09f63eaCompare October 28, 2021 01:37

cyangle marked this pull request as draft October 30, 2021 14:55

wing328 closed this May 4, 2022

cyangle mentioned this pull request Oct 24, 2021
Enhancement to the Crystal client generator #8363
Open

cyangle mentioned this pull request Oct 26, 2021
[crystal][client][closes #10696] Update crystal client gitignore.mustache with shards related files #10698
Merged
5 tasks

cyangle added 8 commits October 27, 2021 20:35

Add default value support and make optional args default to nil
55c63fc

Refresh generated sample code for crystal
bb2da89

Add crystal-client profile to pom.xml
a31d532

Use keyword arguments by default
39145bf
You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

Allow invoking methods with positional argument when the method only …
697cb61
…has one param

Fix required vs nullable in model
2ab36f2
only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

simplify param serializations and handles file param
09f63ea
Handle file param separately to simplify to make it more readable

cyangle force-pushed the nil_as_default_for_optional_args branch from 8b98d55 to 09f63eaCompare October 28, 2021 01:37

cyangle marked this pull request as draft October 30, 2021 14:55

wing328 closed this May 4, 2022

cyangle mentioned this pull request Oct 24, 2021
Enhancement to the Crystal client generator #8363
Open

cyangle mentioned this pull request Oct 26, 2021
[crystal][client][closes #10696] Update crystal client gitignore.mustache with shards related files #10698
Merged
5 tasks

cyangle added 8 commits October 27, 2021 20:35

Add default value support and make optional args default to nil
55c63fc

Refresh generated sample code for crystal
bb2da89

Add crystal-client profile to pom.xml
a31d532

Use keyword arguments by default
39145bf
You can put keyword argument with default value before ones without default values So that this compiles: class Pet property name : String property id : Int64? def initialize(*, @name : String = "pet", @id : Int64?) end end pp Pet.new(id: 1)

Allow invoking methods with positional argument when the method only …
697cb61
…has one param

Fix required vs nullable in model
2ab36f2
only nullable properties should emit_null all optional and nullable required properties are nilable: They should have type {{dataType}}? nullable required should also emit nulls in json format as the json field key is required

simplify param serializations and handles file param
09f63ea
Handle file param separately to simplify to make it more readable

cyangle force-pushed the nil_as_default_for_optional_args branch from 8b98d55 to 09f63eaCompare October 28, 2021 01:37

cyangle marked this pull request as draft October 30, 2021 14:55

wing328 closed this May 4, 2022

Uh oh!

Uh oh!

Conversation

cyangle commented Oct 24, 2021

PR checklist

Uh oh!

cyangle commented Oct 26, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyangle commented Oct 28, 2021

Uh oh!

wing328 commented May 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

cyangle commented Oct 24, 2021

PR checklist

Uh oh!

cyangle commented Oct 26, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyangle commented Oct 28, 2021

Uh oh!

wing328 commented May 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

cyangle commented Oct 24, 2021

PR checklist

Uh oh!

cyangle commented Oct 26, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyangle commented Oct 28, 2021

Uh oh!

wing328 commented May 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

cyangle commented Oct 24, 2021

PR checklist

Uh oh!

cyangle commented Oct 26, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyangle commented Oct 28, 2021

Uh oh!

wing328 commented May 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

cyangle commented Oct 26, 2021•
edited
Loading

cyangle commented Oct 26, 2021•
edited
Loading

cyangle commented Oct 26, 2021•
edited
Loading

cyangle commented Oct 26, 2021•
edited
Loading

cyangle commented Oct 26, 2021•
edited
Loading

cyangle commented Oct 26, 2021•
edited
Loading