Add compilation test to typescript-angular-v13-provided-in-root petst…

[cghislai]

…ore sample

This adds a simple test to ensure the generated typescript-angular-v13-provided-in-root code is compilable.

This would prevent issues such as #10975, #10864, or #11172 (all duplicates) to occur.

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[cghislai]

@amakhrov can you check this if travis builds? thanks.

[cghislai]

the error on ci/circleci: node0 does not appear to be related to this change?

[amakhrov]

@cghislai it doesn't seem related, right. However, it's suspicious that both your PRs have the same failure.

I can see 2 recently merged PRs related to spring-mvc generator (the one that fails in your PR). Is it possible that your branch is behind master and this causes the issue?

[cghislai]

i was lagging by 1 commit. I could generate the spring-mvc sample javadoc locally. I see there is a file encoding error, and that it is triggered when the samples input changed (and [info] Code generation is skipped because input was unchanged is not logged). I will look into it later, hopefully its as simple as specifying the encoding in the pom.

[cghislai]

I will wait for #11477 to be merged to fix circleci builds then rebase

[cghislai]

@amakhrov, the build errors have been fixed. can you have another look?
Thanks

[amakhrov]

@сghislai thanks! LGTM

[cghislai]

…ore sample

This adds a simple test to ensure the generated typescript-angular-v13-provided-in-root code is compilable.

This would prevent issues such as #10975, #10864, or #11172 (all duplicates) to occur.

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[cghislai]

@amakhrov can you check this if travis builds? thanks.

[cghislai]

the error on ci/circleci: node0 does not appear to be related to this change?

[amakhrov]

@cghislai it doesn't seem related, right. However, it's suspicious that both your PRs have the same failure.

I can see 2 recently merged PRs related to spring-mvc generator (the one that fails in your PR). Is it possible that your branch is behind master and this causes the issue?

[cghislai]

i was lagging by 1 commit. I could generate the spring-mvc sample javadoc locally. I see there is a file encoding error, and that it is triggered when the samples input changed (and [info] Code generation is skipped because input was unchanged is not logged). I will look into it later, hopefully its as simple as specifying the encoding in the pom.

[cghislai]

I will wait for #11477 to be merged to fix circleci builds then rebase

[cghislai]

@amakhrov, the build errors have been fixed. can you have another look?
Thanks

[amakhrov]

@сghislai thanks! LGTM

[cghislai]

…ore sample

This adds a simple test to ensure the generated typescript-angular-v13-provided-in-root code is compilable.

This would prevent issues such as #10975, #10864, or #11172 (all duplicates) to occur.

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[cghislai]

@amakhrov can you check this if travis builds? thanks.

[cghislai]

the error on ci/circleci: node0 does not appear to be related to this change?

[amakhrov]

@cghislai it doesn't seem related, right. However, it's suspicious that both your PRs have the same failure.

I can see 2 recently merged PRs related to spring-mvc generator (the one that fails in your PR). Is it possible that your branch is behind master and this causes the issue?

[cghislai]

i was lagging by 1 commit. I could generate the spring-mvc sample javadoc locally. I see there is a file encoding error, and that it is triggered when the samples input changed (and [info] Code generation is skipped because input was unchanged is not logged). I will look into it later, hopefully its as simple as specifying the encoding in the pom.

[cghislai]

I will wait for #11477 to be merged to fix circleci builds then rebase

[cghislai]

@amakhrov, the build errors have been fixed. can you have another look?
Thanks

[amakhrov]

@сghislai thanks! LGTM

[cghislai]

…ore sample

This adds a simple test to ensure the generated typescript-angular-v13-provided-in-root code is compilable.

This would prevent issues such as #10975, #10864, or #11172 (all duplicates) to occur.

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[cghislai]

@amakhrov can you check this if travis builds? thanks.

[cghislai]

the error on ci/circleci: node0 does not appear to be related to this change?

[amakhrov]

@cghislai it doesn't seem related, right. However, it's suspicious that both your PRs have the same failure.

I can see 2 recently merged PRs related to spring-mvc generator (the one that fails in your PR). Is it possible that your branch is behind master and this causes the issue?

[cghislai]

i was lagging by 1 commit. I could generate the spring-mvc sample javadoc locally. I see there is a file encoding error, and that it is triggered when the samples input changed (and [info] Code generation is skipped because input was unchanged is not logged). I will look into it later, hopefully its as simple as specifying the encoding in the pom.

[cghislai]

I will wait for #11477 to be merged to fix circleci builds then rebase

[cghislai]

@amakhrov, the build errors have been fixed. can you have another look?
Thanks

[amakhrov]

@сghislai thanks! LGTM

[cghislai]

…ore sample

This adds a simple test to ensure the generated typescript-angular-v13-provided-in-root code is compilable.

This would prevent issues such as #10975, #10864, or #11172 (all duplicates) to occur.

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[cghislai]

@amakhrov can you check this if travis builds? thanks.

[cghislai]

the error on ci/circleci: node0 does not appear to be related to this change?

[amakhrov]

@cghislai it doesn't seem related, right. However, it's suspicious that both your PRs have the same failure.

I can see 2 recently merged PRs related to spring-mvc generator (the one that fails in your PR). Is it possible that your branch is behind master and this causes the issue?

[cghislai]

i was lagging by 1 commit. I could generate the spring-mvc sample javadoc locally. I see there is a file encoding error, and that it is triggered when the samples input changed (and [info] Code generation is skipped because input was unchanged is not logged). I will look into it later, hopefully its as simple as specifying the encoding in the pom.

[cghislai]

I will wait for #11477 to be merged to fix circleci builds then rebase

[cghislai]

@amakhrov, the build errors have been fixed. can you have another look?
Thanks

[amakhrov]

@сghislai thanks! LGTM

[cghislai]

…ore sample

This adds a simple test to ensure the generated typescript-angular-v13-provided-in-root code is compilable.

This would prevent issues such as #10975, #10864, or #11172 (all duplicates) to occur.

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[cghislai]

@amakhrov can you check this if travis builds? thanks.

[cghislai]

the error on ci/circleci: node0 does not appear to be related to this change?

[amakhrov]

@cghislai it doesn't seem related, right. However, it's suspicious that both your PRs have the same failure.

I can see 2 recently merged PRs related to spring-mvc generator (the one that fails in your PR). Is it possible that your branch is behind master and this causes the issue?

[cghislai]

i was lagging by 1 commit. I could generate the spring-mvc sample javadoc locally. I see there is a file encoding error, and that it is triggered when the samples input changed (and [info] Code generation is skipped because input was unchanged is not logged). I will look into it later, hopefully its as simple as specifying the encoding in the pom.

[cghislai]

I will wait for #11477 to be merged to fix circleci builds then rebase

[cghislai]

@amakhrov, the build errors have been fixed. can you have another look?
Thanks

[amakhrov]

@сghislai thanks! LGTM

[cghislai]

…ore sample

This adds a simple test to ensure the generated typescript-angular-v13-provided-in-root code is compilable.

This would prevent issues such as #10975, #10864, or #11172 (all duplicates) to occur.

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[cghislai]

@amakhrov can you check this if travis builds? thanks.

[cghislai]

the error on ci/circleci: node0 does not appear to be related to this change?

[amakhrov]

@cghislai it doesn't seem related, right. However, it's suspicious that both your PRs have the same failure.

I can see 2 recently merged PRs related to spring-mvc generator (the one that fails in your PR). Is it possible that your branch is behind master and this causes the issue?

[cghislai]

i was lagging by 1 commit. I could generate the spring-mvc sample javadoc locally. I see there is a file encoding error, and that it is triggered when the samples input changed (and [info] Code generation is skipped because input was unchanged is not logged). I will look into it later, hopefully its as simple as specifying the encoding in the pom.

[cghislai]

I will wait for #11477 to be merged to fix circleci builds then rebase

[cghislai]

@amakhrov, the build errors have been fixed. can you have another look?
Thanks

[amakhrov]

@сghislai thanks! LGTM

[cghislai]

…ore sample

This adds a simple test to ensure the generated typescript-angular-v13-provided-in-root code is compilable.

This would prevent issues such as #10975, #10864, or #11172 (all duplicates) to occur.

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[cghislai]

@amakhrov can you check this if travis builds? thanks.

[cghislai]

the error on ci/circleci: node0 does not appear to be related to this change?

[amakhrov]

@cghislai it doesn't seem related, right. However, it's suspicious that both your PRs have the same failure.

I can see 2 recently merged PRs related to spring-mvc generator (the one that fails in your PR). Is it possible that your branch is behind master and this causes the issue?

[cghislai]

i was lagging by 1 commit. I could generate the spring-mvc sample javadoc locally. I see there is a file encoding error, and that it is triggered when the samples input changed (and [info] Code generation is skipped because input was unchanged is not logged). I will look into it later, hopefully its as simple as specifying the encoding in the pom.

[cghislai]

I will wait for #11477 to be merged to fix circleci builds then rebase

[cghislai]

@amakhrov, the build errors have been fixed. can you have another look?
Thanks

[amakhrov]

@сghislai thanks! LGTM