Python AIOHTTP server generator

[Jyhess]

@wing328@taxpon@frol@mbohlool@cbornet@kenjones-cisco@tomplus

Following issue 1322, I started to write a generator for aiohttp server.
It's a work in progress, and I would like early review and help to fix some remaining issues.

Note:

• I think some improvements can be applied to flask generator (like security management for example), but for the moment, I didn't change it as I'm not familiar with.

And here is some questions:

In preprocessOpenAPI function, I set body name to "body" by default. I would like set it to type name (pet or user is better, but didn't figure how to get easily this information. Do you know how I can find this information ?

In model.mustach, I would like to generate imports for other generated class, like

from openapi_server.models.category import Category
from openapi_server.models.tag import Tag

Do you know how I can do that ? There is the same issue with Flask generator.

In test controllers, examples are not generated. Any clue on that ?

Do you know why side files, like git_push.sh, or setup.py are generated? I'm not sure they should be part of a code generator.

[wing328]

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

[wing328]

@Jyhess thanks for the PR. Are you free on the coming week to have a quick chat about this PR?

I'm available via https://gitter.im (ID: wing328) or Google Hangout (you can find the email address in my profile page)

[Jyhess]

Hi William, We can have a chat on gitter this week. I'm available from 10 am french timezone, 5 pm for you I guess. FYI, I updated my PR with some more fixes. BR, Julien Le sam. 24 nov. 2018 à 10:18, William Cheng <notifications@github.com> a écrit :

…

@Jyhess <https://github.com/Jyhess> thanks for the PR. Are you free on the coming week to have a quick chat about this PR? I'm available via https://gitter.im (ID: wing328) or Google Hangout (you can find the email address in my profile page) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1470 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYB-oI45etkTSewCgRt5lko7iWmiD2Ppks5uyQ7rgaJpZM4YmPJN> .

[wing328]

@Jyhess currently, we test the python clients in Travis by adding the folders to pom.xml: https://github.com/OpenAPITools/openapi-generator/blob/master/pom.xml#L1039

If it's not a lot of work, I suggest we do the same for Python AIOHTTP Petstore server samples by adding a pom.xml under samples/server/petstore/aiohttpConnexion/

[Jyhess]

Tests for generated server cannot succeed until this PR on connexion is not released.

Moreover, there is some other issues in generated tests for the moment:

• examples are empty, which occur validation error for mandatory fields
• form and file upload are not yet managed
• body with list are not yet supported
  I will try to fix them, but I don't know when.

I will add travis files and find a way to deactivate or fix failing tests.

[Jyhess]

@wing328 I fixed tests. I also added and fixed tests for python-flask generator.

[wing328]

I'll review again later today or tomorrow and merge it into master if no further feedback

[Jyhess]

OK, I fixed some tests and normalized flask folders.
I think we are good for a first version.

[wing328]

Tweet: https://twitter.com/oas_generator/status/1083751186782552064

HN: https://news.ycombinator.com/item?id=18884281

Reddit: https://www.reddit.com/r/programming/comments/aewn74/generate_a_python_aiohttp_server_with_openapi/