Skip to content

Fix missing RequestBody.required of inline request body#1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 5 commits into from
Jan 14, 2019
Merged

Fix missing RequestBody.required of inline request body #1847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e624de6
Add test case that reproduce the issue #1782
ackintosh Jan 8, 2019
d7af1d9
Fix missing RequestBody.required
ackintosh Jan 8, 2019
c34a1c2
Update samples
ackintosh Jan 8, 2019
144f3d2
Merge branch 'master' into fix-issue-1782
ackintosh Jan 12, 2019
3a1fedd
Run ensure-up-to-date script
ackintosh Jan 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ private void flattenRequestBody(OpenAPI openAPI, String pathname, Operation oper

// create request body
RequestBody rb = new RequestBody();
rb.setRequired(requestBody.getRequired());
Content content = new Content();
MediaType mt = new MediaType();
Schema schema = new Schema();
Expand Down
3 changes: 3 additions & 0 deletions ...les/openapi-generator/src/test/java/org/openapitools/codegen/InlineModelResolverTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,9 @@ public void resolveInlineRequestBodyWithRequired() {

RequestBody requestBodyReference = openAPI.getPaths().get("/resolve_inline_request_body_with_required").getPost().getRequestBody();
assertTrue(requestBodyReference.getRequired());

RequestBody referencedRequestBody = ModelUtils.getReferencedRequestBody(openAPI, requestBodyReference);
assertTrue(referencedRequestBody.getRequired());
}

@Test
Expand Down
8 changes: 4 additions & 4 deletions ...ent/petstore/java/feign/src/test/java/org/openapitools/client/api/AnotherFakeApiTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,12 +26,12 @@ public void setup() {
/**
* To test special tags
*
* To test special tags
* To test special tags and operation ID starting with number
*/
@Test
public void testSpecialTagsTest() {
Client client = null;
// Client response = api.testSpecialTags(client);
public void call123testSpecialTagsTest() {
Client body = null;
// Client response = api.call123testSpecialTags(body);

// TODO: test validations
}
Expand Down
24 changes: 12 additions & 12 deletions ...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/FakeApiTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,8 +51,8 @@ public void fakeOuterBooleanSerializeTest() {
*/
@Test
public void fakeOuterCompositeSerializeTest() {
OuterComposite outerComposite = null;
// OuterComposite response = api.fakeOuterCompositeSerialize(outerComposite);
OuterComposite body = null;
// OuterComposite response = api.fakeOuterCompositeSerialize(body);

// TODO: test validations
}
Expand DownExpand Up@@ -93,8 +93,8 @@ public void fakeOuterStringSerializeTest() {
*/
@Test
public void testBodyWithFileSchemaTest() {
FileSchemaTestClass fileSchemaTestClass = null;
// api.testBodyWithFileSchema(fileSchemaTestClass);
FileSchemaTestClass body = null;
// api.testBodyWithFileSchema(body);

// TODO: test validations
}
Expand All@@ -108,8 +108,8 @@ public void testBodyWithFileSchemaTest() {
@Test
public void testBodyWithQueryParamsTest() {
String query = null;
User user = null;
// api.testBodyWithQueryParams(query, user);
User body = null;
// api.testBodyWithQueryParams(query, body);

// TODO: test validations
}
Expand All@@ -124,10 +124,10 @@ public void testBodyWithQueryParamsTest() {
*/
@Test
public void testBodyWithQueryParamsTestQueryMap() {
User user = null;
User body = null;
FakeApi.TestBodyWithQueryParamsQueryParams queryParams = new FakeApi.TestBodyWithQueryParamsQueryParams()
.query(null);
// api.testBodyWithQueryParams(user, queryParams);
// api.testBodyWithQueryParams(body, queryParams);

// TODO: test validations
}
Expand All@@ -139,8 +139,8 @@ public void testBodyWithQueryParamsTestQueryMap() {
*/
@Test
public void testClientModelTest() {
Client client = null;
// Client response = api.testClientModel(client);
Client body = null;
// Client response = api.testClientModel(body);

// TODO: test validations
}
Expand DownExpand Up@@ -264,8 +264,8 @@ public void testGroupParametersTestQueryMap() {
*/
@Test
public void testInlineAdditionalPropertiesTest() {
Map<String, String> requestBody = null;
// api.testInlineAdditionalProperties(requestBody);
Map<String, String> param = null;
// api.testInlineAdditionalProperties(param);

// TODO: test validations
}
Expand Down
4 changes: 2 additions & 2 deletions ...ore/java/feign/src/test/java/org/openapitools/client/api/FakeClassnameTags123ApiTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
*/
@Test
public void testClassnameTest() {
Client client = null;
// Client response = api.testClassname(client);
Client body = null;
// Client response = api.testClassname(body);

// TODO: test validations
}
Expand Down
24 changes: 20 additions & 4 deletions samples/client/petstore/java/feign/src/test/java/org/openapitools/client/api/PetApiTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@ public void setup() {
*/
@Test
public void addPetTest() {
Pet pet = null;
// api.addPet(pet);
Pet body = null;
// api.addPet(body);

// TODO: test validations
}
Expand DownExpand Up@@ -135,8 +135,8 @@ public void getPetByIdTest() {
*/
@Test
public void updatePetTest() {
Pet pet = null;
// api.updatePet(pet);
Pet body = null;
// api.updatePet(body);

// TODO: test validations
}
Expand DownExpand Up@@ -174,4 +174,20 @@ public void uploadFileTest() {
}


/**
* uploads an image (required)
*
*
*/
@Test
public void uploadFileWithRequiredFileTest() {
Long petId = null;
File requiredFile = null;
String additionalMetadata = null;
// ModelApiResponse response = api.uploadFileWithRequiredFile(petId, requiredFile, additionalMetadata);

// TODO: test validations
}


}
4 changes: 2 additions & 2 deletions ...es/client/petstore/java/feign/src/test/java/org/openapitools/client/api/StoreApiTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,8 +71,8 @@ public void getOrderByIdTest() {
*/
@Test
public void placeOrderTest() {
Order order = null;
// Order response = api.placeOrder(order);
Order body = null;
// Order response = api.placeOrder(body);

// TODO: test validations
}
Expand Down
16 changes: 8 additions & 8 deletions ...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/UserApiTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
*/
@Test
public void createUserTest() {
User user = null;
// api.createUser(user);
User body = null;
// api.createUser(body);

// TODO: test validations
}
Expand All@@ -44,8 +44,8 @@ public void createUserTest() {
*/
@Test
public void createUsersWithArrayInputTest() {
List<User> user = null;
// api.createUsersWithArrayInput(user);
List<User> body = null;
// api.createUsersWithArrayInput(body);

// TODO: test validations
}
Expand All@@ -58,8 +58,8 @@ public void createUsersWithArrayInputTest() {
*/
@Test
public void createUsersWithListInputTest() {
List<User> user = null;
// api.createUsersWithListInput(user);
List<User> body = null;
// api.createUsersWithListInput(body);

// TODO: test validations
}
Expand DownExpand Up@@ -146,8 +146,8 @@ public void logoutUserTest() {
@Test
public void updateUserTest() {
String username = null;
User user = null;
// api.updateUser(username, user);
User body = null;
// api.updateUser(username, body);

// TODO: test validations
}
Expand Down
Binary file addedsamples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
5 changes: 5 additions & 0 deletions samples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
172 changes: 172 additions & 0 deletions samples/openapi3/client/petstore/kotlin/gradlew
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix missing RequestBody.required of inline request body by ackintosh · Pull Request #1847 · OpenAPITools/openapi-generator · GitHub
Skip to content
Fix missing RequestBody.required of inline request body#1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wing328
merged 5 commits into

from

Jan 14, 2019
 Merged


Fix missing RequestBody.required of inline request body
#1847
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
e624de6

Add test case that reproduce the issue #1782


ackintosh Jan 8, 2019
d7af1d9

Fix missing RequestBody.required


ackintosh Jan 8, 2019
c34a1c2

Update samples


ackintosh Jan 8, 2019
144f3d2

Merge branch 'master' into fix-issue-1782


ackintosh Jan 12, 2019
3a1fedd

Run ensure-up-to-date script


ackintosh Jan 12, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ private void flattenRequestBody(OpenAPI openAPI, String pathname, Operation oper

 // create request body
 RequestBody rb = new RequestBody();
 rb.setRequired(requestBody.getRequired());
 Content content = new Content();
 MediaType mt = new MediaType();
 Schema schema = new Schema();
Expand Down

3 changes: 3 additions & 0 deletions
...les/openapi-generator/src/test/java/org/openapitools/codegen/InlineModelResolverTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,9 @@ public void resolveInlineRequestBodyWithRequired() {

 RequestBody requestBodyReference = openAPI.getPaths().get("/resolve_inline_request_body_with_required").getPost().getRequestBody();
 assertTrue(requestBodyReference.getRequired());

 RequestBody referencedRequestBody = ModelUtils.getReferencedRequestBody(openAPI, requestBodyReference);
 assertTrue(referencedRequestBody.getRequired());
 }

 @Test
Expand Down

8 changes: 4 additions & 4 deletions
...ent/petstore/java/feign/src/test/java/org/openapitools/client/api/AnotherFakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,12 +26,12 @@ public void setup() {
 /**
 * To test special tags
 *
 * To test special tags
 * To test special tags and operation ID starting with number
 */
 @Test
 public void testSpecialTagsTest() {
 Client client = null;
 // Client response = api.testSpecialTags(client);
 public void call123testSpecialTagsTest() {
 Client body = null;
 // Client response = api.call123testSpecialTags(body);

 // TODO: test validations
 }
Expand Down

24 changes: 12 additions & 12 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/FakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,8 +51,8 @@ public void fakeOuterBooleanSerializeTest() {
 */
 @Test
 public void fakeOuterCompositeSerializeTest() {
 OuterComposite outerComposite = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(outerComposite);
 OuterComposite body = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -93,8 +93,8 @@ public void fakeOuterStringSerializeTest() {
 */
 @Test
 public void testBodyWithFileSchemaTest() {
 FileSchemaTestClass fileSchemaTestClass = null;
 // api.testBodyWithFileSchema(fileSchemaTestClass);
 FileSchemaTestClass body = null;
 // api.testBodyWithFileSchema(body);

 // TODO: test validations
 }
Expand All@@ -108,8 +108,8 @@ public void testBodyWithFileSchemaTest() {
 @Test
 public void testBodyWithQueryParamsTest() {
 String query = null;
 User user = null;
 // api.testBodyWithQueryParams(query, user);
 User body = null;
 // api.testBodyWithQueryParams(query, body);

 // TODO: test validations
 }
Expand All@@ -124,10 +124,10 @@ public void testBodyWithQueryParamsTest() {
 */
 @Test
 public void testBodyWithQueryParamsTestQueryMap() {
 User user = null;
 User body = null;
 FakeApi.TestBodyWithQueryParamsQueryParams queryParams = new FakeApi.TestBodyWithQueryParamsQueryParams()
 .query(null);
 // api.testBodyWithQueryParams(user, queryParams);
 // api.testBodyWithQueryParams(body, queryParams);

 // TODO: test validations
 }
Expand All@@ -139,8 +139,8 @@ public void testBodyWithQueryParamsTestQueryMap() {
 */
 @Test
 public void testClientModelTest() {
 Client client = null;
 // Client response = api.testClientModel(client);
 Client body = null;
 // Client response = api.testClientModel(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -264,8 +264,8 @@ public void testGroupParametersTestQueryMap() {
 */
 @Test
 public void testInlineAdditionalPropertiesTest() {
 Map<String, String> requestBody = null;
 // api.testInlineAdditionalProperties(requestBody);
 Map<String, String> param = null;
 // api.testInlineAdditionalProperties(param);

 // TODO: test validations
 }
Expand Down

4 changes: 2 additions & 2 deletions
...ore/java/feign/src/test/java/org/openapitools/client/api/FakeClassnameTags123ApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void testClassnameTest() {
 Client client = null;
 // Client response = api.testClassname(client);
 Client body = null;
 // Client response = api.testClassname(body);

 // TODO: test validations
 }
Expand Down

24 changes: 20 additions & 4 deletions
samples/client/petstore/java/feign/src/test/java/org/openapitools/client/api/PetApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@ public void setup() {
 */
 @Test
 public void addPetTest() {
 Pet pet = null;
 // api.addPet(pet);
 Pet body = null;
 // api.addPet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -135,8 +135,8 @@ public void getPetByIdTest() {
 */
 @Test
 public void updatePetTest() {
 Pet pet = null;
 // api.updatePet(pet);
 Pet body = null;
 // api.updatePet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -174,4 +174,20 @@ public void uploadFileTest() {
 }


 /**
 * uploads an image (required)
 *
 * 
 */
 @Test
 public void uploadFileWithRequiredFileTest() {
 Long petId = null;
 File requiredFile = null;
 String additionalMetadata = null;
 // ModelApiResponse response = api.uploadFileWithRequiredFile(petId, requiredFile, additionalMetadata);

 // TODO: test validations
 }


}

4 changes: 2 additions & 2 deletions
...es/client/petstore/java/feign/src/test/java/org/openapitools/client/api/StoreApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,8 +71,8 @@ public void getOrderByIdTest() {
 */
 @Test
 public void placeOrderTest() {
 Order order = null;
 // Order response = api.placeOrder(order);
 Order body = null;
 // Order response = api.placeOrder(body);

 // TODO: test validations
 }
Expand Down

16 changes: 8 additions & 8 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/UserApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void createUserTest() {
 User user = null;
 // api.createUser(user);
 User body = null;
 // api.createUser(body);

 // TODO: test validations
 }
Expand All@@ -44,8 +44,8 @@ public void createUserTest() {
 */
 @Test
 public void createUsersWithArrayInputTest() {
 List<User> user = null;
 // api.createUsersWithArrayInput(user);
 List<User> body = null;
 // api.createUsersWithArrayInput(body);

 // TODO: test validations
 }
Expand All@@ -58,8 +58,8 @@ public void createUsersWithArrayInputTest() {
 */
 @Test
 public void createUsersWithListInputTest() {
 List<User> user = null;
 // api.createUsersWithListInput(user);
 List<User> body = null;
 // api.createUsersWithListInput(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -146,8 +146,8 @@ public void logoutUserTest() {
 @Test
 public void updateUserTest() {
 String username = null;
 User user = null;
 // api.updateUser(username, user);
 User body = null;
 // api.updateUser(username, body);

 // TODO: test validations
 }
Expand Down
Binary file addedsamples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.jar

View file


Open in desktop


Binary file not shown.


5 changes: 5 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.properties

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists

172 changes: 172 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradlew

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix missing RequestBody.required of inline request body by ackintosh · Pull Request #1847 · OpenAPITools/openapi-generator · GitHub
Skip to content
Fix missing RequestBody.required of inline request body#1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wing328
merged 5 commits into

from

Jan 14, 2019
 Merged


Fix missing RequestBody.required of inline request body
#1847
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
e624de6

Add test case that reproduce the issue #1782


ackintosh Jan 8, 2019
d7af1d9

Fix missing RequestBody.required


ackintosh Jan 8, 2019
c34a1c2

Update samples


ackintosh Jan 8, 2019
144f3d2

Merge branch 'master' into fix-issue-1782


ackintosh Jan 12, 2019
3a1fedd

Run ensure-up-to-date script


ackintosh Jan 12, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ private void flattenRequestBody(OpenAPI openAPI, String pathname, Operation oper

 // create request body
 RequestBody rb = new RequestBody();
 rb.setRequired(requestBody.getRequired());
 Content content = new Content();
 MediaType mt = new MediaType();
 Schema schema = new Schema();
Expand Down

3 changes: 3 additions & 0 deletions
...les/openapi-generator/src/test/java/org/openapitools/codegen/InlineModelResolverTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,9 @@ public void resolveInlineRequestBodyWithRequired() {

 RequestBody requestBodyReference = openAPI.getPaths().get("/resolve_inline_request_body_with_required").getPost().getRequestBody();
 assertTrue(requestBodyReference.getRequired());

 RequestBody referencedRequestBody = ModelUtils.getReferencedRequestBody(openAPI, requestBodyReference);
 assertTrue(referencedRequestBody.getRequired());
 }

 @Test
Expand Down

8 changes: 4 additions & 4 deletions
...ent/petstore/java/feign/src/test/java/org/openapitools/client/api/AnotherFakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,12 +26,12 @@ public void setup() {
 /**
 * To test special tags
 *
 * To test special tags
 * To test special tags and operation ID starting with number
 */
 @Test
 public void testSpecialTagsTest() {
 Client client = null;
 // Client response = api.testSpecialTags(client);
 public void call123testSpecialTagsTest() {
 Client body = null;
 // Client response = api.call123testSpecialTags(body);

 // TODO: test validations
 }
Expand Down

24 changes: 12 additions & 12 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/FakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,8 +51,8 @@ public void fakeOuterBooleanSerializeTest() {
 */
 @Test
 public void fakeOuterCompositeSerializeTest() {
 OuterComposite outerComposite = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(outerComposite);
 OuterComposite body = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -93,8 +93,8 @@ public void fakeOuterStringSerializeTest() {
 */
 @Test
 public void testBodyWithFileSchemaTest() {
 FileSchemaTestClass fileSchemaTestClass = null;
 // api.testBodyWithFileSchema(fileSchemaTestClass);
 FileSchemaTestClass body = null;
 // api.testBodyWithFileSchema(body);

 // TODO: test validations
 }
Expand All@@ -108,8 +108,8 @@ public void testBodyWithFileSchemaTest() {
 @Test
 public void testBodyWithQueryParamsTest() {
 String query = null;
 User user = null;
 // api.testBodyWithQueryParams(query, user);
 User body = null;
 // api.testBodyWithQueryParams(query, body);

 // TODO: test validations
 }
Expand All@@ -124,10 +124,10 @@ public void testBodyWithQueryParamsTest() {
 */
 @Test
 public void testBodyWithQueryParamsTestQueryMap() {
 User user = null;
 User body = null;
 FakeApi.TestBodyWithQueryParamsQueryParams queryParams = new FakeApi.TestBodyWithQueryParamsQueryParams()
 .query(null);
 // api.testBodyWithQueryParams(user, queryParams);
 // api.testBodyWithQueryParams(body, queryParams);

 // TODO: test validations
 }
Expand All@@ -139,8 +139,8 @@ public void testBodyWithQueryParamsTestQueryMap() {
 */
 @Test
 public void testClientModelTest() {
 Client client = null;
 // Client response = api.testClientModel(client);
 Client body = null;
 // Client response = api.testClientModel(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -264,8 +264,8 @@ public void testGroupParametersTestQueryMap() {
 */
 @Test
 public void testInlineAdditionalPropertiesTest() {
 Map<String, String> requestBody = null;
 // api.testInlineAdditionalProperties(requestBody);
 Map<String, String> param = null;
 // api.testInlineAdditionalProperties(param);

 // TODO: test validations
 }
Expand Down

4 changes: 2 additions & 2 deletions
...ore/java/feign/src/test/java/org/openapitools/client/api/FakeClassnameTags123ApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void testClassnameTest() {
 Client client = null;
 // Client response = api.testClassname(client);
 Client body = null;
 // Client response = api.testClassname(body);

 // TODO: test validations
 }
Expand Down

24 changes: 20 additions & 4 deletions
samples/client/petstore/java/feign/src/test/java/org/openapitools/client/api/PetApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@ public void setup() {
 */
 @Test
 public void addPetTest() {
 Pet pet = null;
 // api.addPet(pet);
 Pet body = null;
 // api.addPet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -135,8 +135,8 @@ public void getPetByIdTest() {
 */
 @Test
 public void updatePetTest() {
 Pet pet = null;
 // api.updatePet(pet);
 Pet body = null;
 // api.updatePet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -174,4 +174,20 @@ public void uploadFileTest() {
 }


 /**
 * uploads an image (required)
 *
 * 
 */
 @Test
 public void uploadFileWithRequiredFileTest() {
 Long petId = null;
 File requiredFile = null;
 String additionalMetadata = null;
 // ModelApiResponse response = api.uploadFileWithRequiredFile(petId, requiredFile, additionalMetadata);

 // TODO: test validations
 }


}

4 changes: 2 additions & 2 deletions
...es/client/petstore/java/feign/src/test/java/org/openapitools/client/api/StoreApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,8 +71,8 @@ public void getOrderByIdTest() {
 */
 @Test
 public void placeOrderTest() {
 Order order = null;
 // Order response = api.placeOrder(order);
 Order body = null;
 // Order response = api.placeOrder(body);

 // TODO: test validations
 }
Expand Down

16 changes: 8 additions & 8 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/UserApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void createUserTest() {
 User user = null;
 // api.createUser(user);
 User body = null;
 // api.createUser(body);

 // TODO: test validations
 }
Expand All@@ -44,8 +44,8 @@ public void createUserTest() {
 */
 @Test
 public void createUsersWithArrayInputTest() {
 List<User> user = null;
 // api.createUsersWithArrayInput(user);
 List<User> body = null;
 // api.createUsersWithArrayInput(body);

 // TODO: test validations
 }
Expand All@@ -58,8 +58,8 @@ public void createUsersWithArrayInputTest() {
 */
 @Test
 public void createUsersWithListInputTest() {
 List<User> user = null;
 // api.createUsersWithListInput(user);
 List<User> body = null;
 // api.createUsersWithListInput(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -146,8 +146,8 @@ public void logoutUserTest() {
 @Test
 public void updateUserTest() {
 String username = null;
 User user = null;
 // api.updateUser(username, user);
 User body = null;
 // api.updateUser(username, body);

 // TODO: test validations
 }
Expand Down
Binary file addedsamples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.jar

View file


Open in desktop


Binary file not shown.


5 changes: 5 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.properties

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists

172 changes: 172 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradlew

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix missing RequestBody.required of inline request body by ackintosh · Pull Request #1847 · OpenAPITools/openapi-generator · GitHub
Skip to content
Fix missing RequestBody.required of inline request body#1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wing328
merged 5 commits into

from

Jan 14, 2019
 Merged


Fix missing RequestBody.required of inline request body
#1847
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
e624de6

Add test case that reproduce the issue #1782


ackintosh Jan 8, 2019
d7af1d9

Fix missing RequestBody.required


ackintosh Jan 8, 2019
c34a1c2

Update samples


ackintosh Jan 8, 2019
144f3d2

Merge branch 'master' into fix-issue-1782


ackintosh Jan 12, 2019
3a1fedd

Run ensure-up-to-date script


ackintosh Jan 12, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ private void flattenRequestBody(OpenAPI openAPI, String pathname, Operation oper

 // create request body
 RequestBody rb = new RequestBody();
 rb.setRequired(requestBody.getRequired());
 Content content = new Content();
 MediaType mt = new MediaType();
 Schema schema = new Schema();
Expand Down

3 changes: 3 additions & 0 deletions
...les/openapi-generator/src/test/java/org/openapitools/codegen/InlineModelResolverTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,9 @@ public void resolveInlineRequestBodyWithRequired() {

 RequestBody requestBodyReference = openAPI.getPaths().get("/resolve_inline_request_body_with_required").getPost().getRequestBody();
 assertTrue(requestBodyReference.getRequired());

 RequestBody referencedRequestBody = ModelUtils.getReferencedRequestBody(openAPI, requestBodyReference);
 assertTrue(referencedRequestBody.getRequired());
 }

 @Test
Expand Down

8 changes: 4 additions & 4 deletions
...ent/petstore/java/feign/src/test/java/org/openapitools/client/api/AnotherFakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,12 +26,12 @@ public void setup() {
 /**
 * To test special tags
 *
 * To test special tags
 * To test special tags and operation ID starting with number
 */
 @Test
 public void testSpecialTagsTest() {
 Client client = null;
 // Client response = api.testSpecialTags(client);
 public void call123testSpecialTagsTest() {
 Client body = null;
 // Client response = api.call123testSpecialTags(body);

 // TODO: test validations
 }
Expand Down

24 changes: 12 additions & 12 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/FakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,8 +51,8 @@ public void fakeOuterBooleanSerializeTest() {
 */
 @Test
 public void fakeOuterCompositeSerializeTest() {
 OuterComposite outerComposite = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(outerComposite);
 OuterComposite body = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -93,8 +93,8 @@ public void fakeOuterStringSerializeTest() {
 */
 @Test
 public void testBodyWithFileSchemaTest() {
 FileSchemaTestClass fileSchemaTestClass = null;
 // api.testBodyWithFileSchema(fileSchemaTestClass);
 FileSchemaTestClass body = null;
 // api.testBodyWithFileSchema(body);

 // TODO: test validations
 }
Expand All@@ -108,8 +108,8 @@ public void testBodyWithFileSchemaTest() {
 @Test
 public void testBodyWithQueryParamsTest() {
 String query = null;
 User user = null;
 // api.testBodyWithQueryParams(query, user);
 User body = null;
 // api.testBodyWithQueryParams(query, body);

 // TODO: test validations
 }
Expand All@@ -124,10 +124,10 @@ public void testBodyWithQueryParamsTest() {
 */
 @Test
 public void testBodyWithQueryParamsTestQueryMap() {
 User user = null;
 User body = null;
 FakeApi.TestBodyWithQueryParamsQueryParams queryParams = new FakeApi.TestBodyWithQueryParamsQueryParams()
 .query(null);
 // api.testBodyWithQueryParams(user, queryParams);
 // api.testBodyWithQueryParams(body, queryParams);

 // TODO: test validations
 }
Expand All@@ -139,8 +139,8 @@ public void testBodyWithQueryParamsTestQueryMap() {
 */
 @Test
 public void testClientModelTest() {
 Client client = null;
 // Client response = api.testClientModel(client);
 Client body = null;
 // Client response = api.testClientModel(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -264,8 +264,8 @@ public void testGroupParametersTestQueryMap() {
 */
 @Test
 public void testInlineAdditionalPropertiesTest() {
 Map<String, String> requestBody = null;
 // api.testInlineAdditionalProperties(requestBody);
 Map<String, String> param = null;
 // api.testInlineAdditionalProperties(param);

 // TODO: test validations
 }
Expand Down

4 changes: 2 additions & 2 deletions
...ore/java/feign/src/test/java/org/openapitools/client/api/FakeClassnameTags123ApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void testClassnameTest() {
 Client client = null;
 // Client response = api.testClassname(client);
 Client body = null;
 // Client response = api.testClassname(body);

 // TODO: test validations
 }
Expand Down

24 changes: 20 additions & 4 deletions
samples/client/petstore/java/feign/src/test/java/org/openapitools/client/api/PetApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@ public void setup() {
 */
 @Test
 public void addPetTest() {
 Pet pet = null;
 // api.addPet(pet);
 Pet body = null;
 // api.addPet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -135,8 +135,8 @@ public void getPetByIdTest() {
 */
 @Test
 public void updatePetTest() {
 Pet pet = null;
 // api.updatePet(pet);
 Pet body = null;
 // api.updatePet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -174,4 +174,20 @@ public void uploadFileTest() {
 }


 /**
 * uploads an image (required)
 *
 * 
 */
 @Test
 public void uploadFileWithRequiredFileTest() {
 Long petId = null;
 File requiredFile = null;
 String additionalMetadata = null;
 // ModelApiResponse response = api.uploadFileWithRequiredFile(petId, requiredFile, additionalMetadata);

 // TODO: test validations
 }


}

4 changes: 2 additions & 2 deletions
...es/client/petstore/java/feign/src/test/java/org/openapitools/client/api/StoreApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,8 +71,8 @@ public void getOrderByIdTest() {
 */
 @Test
 public void placeOrderTest() {
 Order order = null;
 // Order response = api.placeOrder(order);
 Order body = null;
 // Order response = api.placeOrder(body);

 // TODO: test validations
 }
Expand Down

16 changes: 8 additions & 8 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/UserApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void createUserTest() {
 User user = null;
 // api.createUser(user);
 User body = null;
 // api.createUser(body);

 // TODO: test validations
 }
Expand All@@ -44,8 +44,8 @@ public void createUserTest() {
 */
 @Test
 public void createUsersWithArrayInputTest() {
 List<User> user = null;
 // api.createUsersWithArrayInput(user);
 List<User> body = null;
 // api.createUsersWithArrayInput(body);

 // TODO: test validations
 }
Expand All@@ -58,8 +58,8 @@ public void createUsersWithArrayInputTest() {
 */
 @Test
 public void createUsersWithListInputTest() {
 List<User> user = null;
 // api.createUsersWithListInput(user);
 List<User> body = null;
 // api.createUsersWithListInput(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -146,8 +146,8 @@ public void logoutUserTest() {
 @Test
 public void updateUserTest() {
 String username = null;
 User user = null;
 // api.updateUser(username, user);
 User body = null;
 // api.updateUser(username, body);

 // TODO: test validations
 }
Expand Down
Binary file addedsamples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.jar

View file


Open in desktop


Binary file not shown.


5 changes: 5 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.properties

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists

172 changes: 172 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradlew

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fix missing RequestBody.required of inline request body by ackintosh · Pull Request #1847 · OpenAPITools/openapi-generator · GitHub
Skip to content
Fix missing RequestBody.required of inline request body#1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wing328
merged 5 commits into

from

Jan 14, 2019
 Merged


Fix missing RequestBody.required of inline request body
#1847
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
e624de6

Add test case that reproduce the issue #1782


ackintosh Jan 8, 2019
d7af1d9

Fix missing RequestBody.required


ackintosh Jan 8, 2019
c34a1c2

Update samples


ackintosh Jan 8, 2019
144f3d2

Merge branch 'master' into fix-issue-1782


ackintosh Jan 12, 2019
3a1fedd

Run ensure-up-to-date script


ackintosh Jan 12, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ private void flattenRequestBody(OpenAPI openAPI, String pathname, Operation oper

 // create request body
 RequestBody rb = new RequestBody();
 rb.setRequired(requestBody.getRequired());
 Content content = new Content();
 MediaType mt = new MediaType();
 Schema schema = new Schema();
Expand Down

3 changes: 3 additions & 0 deletions
...les/openapi-generator/src/test/java/org/openapitools/codegen/InlineModelResolverTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,9 @@ public void resolveInlineRequestBodyWithRequired() {

 RequestBody requestBodyReference = openAPI.getPaths().get("/resolve_inline_request_body_with_required").getPost().getRequestBody();
 assertTrue(requestBodyReference.getRequired());

 RequestBody referencedRequestBody = ModelUtils.getReferencedRequestBody(openAPI, requestBodyReference);
 assertTrue(referencedRequestBody.getRequired());
 }

 @Test
Expand Down

8 changes: 4 additions & 4 deletions
...ent/petstore/java/feign/src/test/java/org/openapitools/client/api/AnotherFakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,12 +26,12 @@ public void setup() {
 /**
 * To test special tags
 *
 * To test special tags
 * To test special tags and operation ID starting with number
 */
 @Test
 public void testSpecialTagsTest() {
 Client client = null;
 // Client response = api.testSpecialTags(client);
 public void call123testSpecialTagsTest() {
 Client body = null;
 // Client response = api.call123testSpecialTags(body);

 // TODO: test validations
 }
Expand Down

24 changes: 12 additions & 12 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/FakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,8 +51,8 @@ public void fakeOuterBooleanSerializeTest() {
 */
 @Test
 public void fakeOuterCompositeSerializeTest() {
 OuterComposite outerComposite = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(outerComposite);
 OuterComposite body = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -93,8 +93,8 @@ public void fakeOuterStringSerializeTest() {
 */
 @Test
 public void testBodyWithFileSchemaTest() {
 FileSchemaTestClass fileSchemaTestClass = null;
 // api.testBodyWithFileSchema(fileSchemaTestClass);
 FileSchemaTestClass body = null;
 // api.testBodyWithFileSchema(body);

 // TODO: test validations
 }
Expand All@@ -108,8 +108,8 @@ public void testBodyWithFileSchemaTest() {
 @Test
 public void testBodyWithQueryParamsTest() {
 String query = null;
 User user = null;
 // api.testBodyWithQueryParams(query, user);
 User body = null;
 // api.testBodyWithQueryParams(query, body);

 // TODO: test validations
 }
Expand All@@ -124,10 +124,10 @@ public void testBodyWithQueryParamsTest() {
 */
 @Test
 public void testBodyWithQueryParamsTestQueryMap() {
 User user = null;
 User body = null;
 FakeApi.TestBodyWithQueryParamsQueryParams queryParams = new FakeApi.TestBodyWithQueryParamsQueryParams()
 .query(null);
 // api.testBodyWithQueryParams(user, queryParams);
 // api.testBodyWithQueryParams(body, queryParams);

 // TODO: test validations
 }
Expand All@@ -139,8 +139,8 @@ public void testBodyWithQueryParamsTestQueryMap() {
 */
 @Test
 public void testClientModelTest() {
 Client client = null;
 // Client response = api.testClientModel(client);
 Client body = null;
 // Client response = api.testClientModel(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -264,8 +264,8 @@ public void testGroupParametersTestQueryMap() {
 */
 @Test
 public void testInlineAdditionalPropertiesTest() {
 Map<String, String> requestBody = null;
 // api.testInlineAdditionalProperties(requestBody);
 Map<String, String> param = null;
 // api.testInlineAdditionalProperties(param);

 // TODO: test validations
 }
Expand Down

4 changes: 2 additions & 2 deletions
...ore/java/feign/src/test/java/org/openapitools/client/api/FakeClassnameTags123ApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void testClassnameTest() {
 Client client = null;
 // Client response = api.testClassname(client);
 Client body = null;
 // Client response = api.testClassname(body);

 // TODO: test validations
 }
Expand Down

24 changes: 20 additions & 4 deletions
samples/client/petstore/java/feign/src/test/java/org/openapitools/client/api/PetApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@ public void setup() {
 */
 @Test
 public void addPetTest() {
 Pet pet = null;
 // api.addPet(pet);
 Pet body = null;
 // api.addPet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -135,8 +135,8 @@ public void getPetByIdTest() {
 */
 @Test
 public void updatePetTest() {
 Pet pet = null;
 // api.updatePet(pet);
 Pet body = null;
 // api.updatePet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -174,4 +174,20 @@ public void uploadFileTest() {
 }


 /**
 * uploads an image (required)
 *
 * 
 */
 @Test
 public void uploadFileWithRequiredFileTest() {
 Long petId = null;
 File requiredFile = null;
 String additionalMetadata = null;
 // ModelApiResponse response = api.uploadFileWithRequiredFile(petId, requiredFile, additionalMetadata);

 // TODO: test validations
 }


}

4 changes: 2 additions & 2 deletions
...es/client/petstore/java/feign/src/test/java/org/openapitools/client/api/StoreApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,8 +71,8 @@ public void getOrderByIdTest() {
 */
 @Test
 public void placeOrderTest() {
 Order order = null;
 // Order response = api.placeOrder(order);
 Order body = null;
 // Order response = api.placeOrder(body);

 // TODO: test validations
 }
Expand Down

16 changes: 8 additions & 8 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/UserApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void createUserTest() {
 User user = null;
 // api.createUser(user);
 User body = null;
 // api.createUser(body);

 // TODO: test validations
 }
Expand All@@ -44,8 +44,8 @@ public void createUserTest() {
 */
 @Test
 public void createUsersWithArrayInputTest() {
 List<User> user = null;
 // api.createUsersWithArrayInput(user);
 List<User> body = null;
 // api.createUsersWithArrayInput(body);

 // TODO: test validations
 }
Expand All@@ -58,8 +58,8 @@ public void createUsersWithArrayInputTest() {
 */
 @Test
 public void createUsersWithListInputTest() {
 List<User> user = null;
 // api.createUsersWithListInput(user);
 List<User> body = null;
 // api.createUsersWithListInput(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -146,8 +146,8 @@ public void logoutUserTest() {
 @Test
 public void updateUserTest() {
 String username = null;
 User user = null;
 // api.updateUser(username, user);
 User body = null;
 // api.updateUser(username, body);

 // TODO: test validations
 }
Expand Down
Binary file addedsamples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.jar

View file


Open in desktop


Binary file not shown.


5 changes: 5 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.properties

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists

172 changes: 172 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradlew

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix missing RequestBody.required of inline request body by ackintosh · Pull Request #1847 · OpenAPITools/openapi-generator · GitHub
Skip to content
Fix missing RequestBody.required of inline request body#1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wing328
merged 5 commits into

from

Jan 14, 2019
 Merged


Fix missing RequestBody.required of inline request body
#1847
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
e624de6

Add test case that reproduce the issue #1782


ackintosh Jan 8, 2019
d7af1d9

Fix missing RequestBody.required


ackintosh Jan 8, 2019
c34a1c2

Update samples


ackintosh Jan 8, 2019
144f3d2

Merge branch 'master' into fix-issue-1782


ackintosh Jan 12, 2019
3a1fedd

Run ensure-up-to-date script


ackintosh Jan 12, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ private void flattenRequestBody(OpenAPI openAPI, String pathname, Operation oper

 // create request body
 RequestBody rb = new RequestBody();
 rb.setRequired(requestBody.getRequired());
 Content content = new Content();
 MediaType mt = new MediaType();
 Schema schema = new Schema();
Expand Down

3 changes: 3 additions & 0 deletions
...les/openapi-generator/src/test/java/org/openapitools/codegen/InlineModelResolverTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,9 @@ public void resolveInlineRequestBodyWithRequired() {

 RequestBody requestBodyReference = openAPI.getPaths().get("/resolve_inline_request_body_with_required").getPost().getRequestBody();
 assertTrue(requestBodyReference.getRequired());

 RequestBody referencedRequestBody = ModelUtils.getReferencedRequestBody(openAPI, requestBodyReference);
 assertTrue(referencedRequestBody.getRequired());
 }

 @Test
Expand Down

8 changes: 4 additions & 4 deletions
...ent/petstore/java/feign/src/test/java/org/openapitools/client/api/AnotherFakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,12 +26,12 @@ public void setup() {
 /**
 * To test special tags
 *
 * To test special tags
 * To test special tags and operation ID starting with number
 */
 @Test
 public void testSpecialTagsTest() {
 Client client = null;
 // Client response = api.testSpecialTags(client);
 public void call123testSpecialTagsTest() {
 Client body = null;
 // Client response = api.call123testSpecialTags(body);

 // TODO: test validations
 }
Expand Down

24 changes: 12 additions & 12 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/FakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,8 +51,8 @@ public void fakeOuterBooleanSerializeTest() {
 */
 @Test
 public void fakeOuterCompositeSerializeTest() {
 OuterComposite outerComposite = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(outerComposite);
 OuterComposite body = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -93,8 +93,8 @@ public void fakeOuterStringSerializeTest() {
 */
 @Test
 public void testBodyWithFileSchemaTest() {
 FileSchemaTestClass fileSchemaTestClass = null;
 // api.testBodyWithFileSchema(fileSchemaTestClass);
 FileSchemaTestClass body = null;
 // api.testBodyWithFileSchema(body);

 // TODO: test validations
 }
Expand All@@ -108,8 +108,8 @@ public void testBodyWithFileSchemaTest() {
 @Test
 public void testBodyWithQueryParamsTest() {
 String query = null;
 User user = null;
 // api.testBodyWithQueryParams(query, user);
 User body = null;
 // api.testBodyWithQueryParams(query, body);

 // TODO: test validations
 }
Expand All@@ -124,10 +124,10 @@ public void testBodyWithQueryParamsTest() {
 */
 @Test
 public void testBodyWithQueryParamsTestQueryMap() {
 User user = null;
 User body = null;
 FakeApi.TestBodyWithQueryParamsQueryParams queryParams = new FakeApi.TestBodyWithQueryParamsQueryParams()
 .query(null);
 // api.testBodyWithQueryParams(user, queryParams);
 // api.testBodyWithQueryParams(body, queryParams);

 // TODO: test validations
 }
Expand All@@ -139,8 +139,8 @@ public void testBodyWithQueryParamsTestQueryMap() {
 */
 @Test
 public void testClientModelTest() {
 Client client = null;
 // Client response = api.testClientModel(client);
 Client body = null;
 // Client response = api.testClientModel(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -264,8 +264,8 @@ public void testGroupParametersTestQueryMap() {
 */
 @Test
 public void testInlineAdditionalPropertiesTest() {
 Map<String, String> requestBody = null;
 // api.testInlineAdditionalProperties(requestBody);
 Map<String, String> param = null;
 // api.testInlineAdditionalProperties(param);

 // TODO: test validations
 }
Expand Down

4 changes: 2 additions & 2 deletions
...ore/java/feign/src/test/java/org/openapitools/client/api/FakeClassnameTags123ApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void testClassnameTest() {
 Client client = null;
 // Client response = api.testClassname(client);
 Client body = null;
 // Client response = api.testClassname(body);

 // TODO: test validations
 }
Expand Down

24 changes: 20 additions & 4 deletions
samples/client/petstore/java/feign/src/test/java/org/openapitools/client/api/PetApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@ public void setup() {
 */
 @Test
 public void addPetTest() {
 Pet pet = null;
 // api.addPet(pet);
 Pet body = null;
 // api.addPet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -135,8 +135,8 @@ public void getPetByIdTest() {
 */
 @Test
 public void updatePetTest() {
 Pet pet = null;
 // api.updatePet(pet);
 Pet body = null;
 // api.updatePet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -174,4 +174,20 @@ public void uploadFileTest() {
 }


 /**
 * uploads an image (required)
 *
 * 
 */
 @Test
 public void uploadFileWithRequiredFileTest() {
 Long petId = null;
 File requiredFile = null;
 String additionalMetadata = null;
 // ModelApiResponse response = api.uploadFileWithRequiredFile(petId, requiredFile, additionalMetadata);

 // TODO: test validations
 }


}

4 changes: 2 additions & 2 deletions
...es/client/petstore/java/feign/src/test/java/org/openapitools/client/api/StoreApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,8 +71,8 @@ public void getOrderByIdTest() {
 */
 @Test
 public void placeOrderTest() {
 Order order = null;
 // Order response = api.placeOrder(order);
 Order body = null;
 // Order response = api.placeOrder(body);

 // TODO: test validations
 }
Expand Down

16 changes: 8 additions & 8 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/UserApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void createUserTest() {
 User user = null;
 // api.createUser(user);
 User body = null;
 // api.createUser(body);

 // TODO: test validations
 }
Expand All@@ -44,8 +44,8 @@ public void createUserTest() {
 */
 @Test
 public void createUsersWithArrayInputTest() {
 List<User> user = null;
 // api.createUsersWithArrayInput(user);
 List<User> body = null;
 // api.createUsersWithArrayInput(body);

 // TODO: test validations
 }
Expand All@@ -58,8 +58,8 @@ public void createUsersWithArrayInputTest() {
 */
 @Test
 public void createUsersWithListInputTest() {
 List<User> user = null;
 // api.createUsersWithListInput(user);
 List<User> body = null;
 // api.createUsersWithListInput(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -146,8 +146,8 @@ public void logoutUserTest() {
 @Test
 public void updateUserTest() {
 String username = null;
 User user = null;
 // api.updateUser(username, user);
 User body = null;
 // api.updateUser(username, body);

 // TODO: test validations
 }
Expand Down
Binary file addedsamples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.jar

View file


Open in desktop


Binary file not shown.


5 changes: 5 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.properties

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists

172 changes: 172 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradlew

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix missing RequestBody.required of inline request body by ackintosh · Pull Request #1847 · OpenAPITools/openapi-generator · GitHub
Skip to content
Fix missing RequestBody.required of inline request body#1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wing328
merged 5 commits into

from

Jan 14, 2019
 Merged


Fix missing RequestBody.required of inline request body
#1847
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
e624de6

Add test case that reproduce the issue #1782


ackintosh Jan 8, 2019
d7af1d9

Fix missing RequestBody.required


ackintosh Jan 8, 2019
c34a1c2

Update samples


ackintosh Jan 8, 2019
144f3d2

Merge branch 'master' into fix-issue-1782


ackintosh Jan 12, 2019
3a1fedd

Run ensure-up-to-date script


ackintosh Jan 12, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ private void flattenRequestBody(OpenAPI openAPI, String pathname, Operation oper

 // create request body
 RequestBody rb = new RequestBody();
 rb.setRequired(requestBody.getRequired());
 Content content = new Content();
 MediaType mt = new MediaType();
 Schema schema = new Schema();
Expand Down

3 changes: 3 additions & 0 deletions
...les/openapi-generator/src/test/java/org/openapitools/codegen/InlineModelResolverTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,9 @@ public void resolveInlineRequestBodyWithRequired() {

 RequestBody requestBodyReference = openAPI.getPaths().get("/resolve_inline_request_body_with_required").getPost().getRequestBody();
 assertTrue(requestBodyReference.getRequired());

 RequestBody referencedRequestBody = ModelUtils.getReferencedRequestBody(openAPI, requestBodyReference);
 assertTrue(referencedRequestBody.getRequired());
 }

 @Test
Expand Down

8 changes: 4 additions & 4 deletions
...ent/petstore/java/feign/src/test/java/org/openapitools/client/api/AnotherFakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,12 +26,12 @@ public void setup() {
 /**
 * To test special tags
 *
 * To test special tags
 * To test special tags and operation ID starting with number
 */
 @Test
 public void testSpecialTagsTest() {
 Client client = null;
 // Client response = api.testSpecialTags(client);
 public void call123testSpecialTagsTest() {
 Client body = null;
 // Client response = api.call123testSpecialTags(body);

 // TODO: test validations
 }
Expand Down

24 changes: 12 additions & 12 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/FakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,8 +51,8 @@ public void fakeOuterBooleanSerializeTest() {
 */
 @Test
 public void fakeOuterCompositeSerializeTest() {
 OuterComposite outerComposite = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(outerComposite);
 OuterComposite body = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -93,8 +93,8 @@ public void fakeOuterStringSerializeTest() {
 */
 @Test
 public void testBodyWithFileSchemaTest() {
 FileSchemaTestClass fileSchemaTestClass = null;
 // api.testBodyWithFileSchema(fileSchemaTestClass);
 FileSchemaTestClass body = null;
 // api.testBodyWithFileSchema(body);

 // TODO: test validations
 }
Expand All@@ -108,8 +108,8 @@ public void testBodyWithFileSchemaTest() {
 @Test
 public void testBodyWithQueryParamsTest() {
 String query = null;
 User user = null;
 // api.testBodyWithQueryParams(query, user);
 User body = null;
 // api.testBodyWithQueryParams(query, body);

 // TODO: test validations
 }
Expand All@@ -124,10 +124,10 @@ public void testBodyWithQueryParamsTest() {
 */
 @Test
 public void testBodyWithQueryParamsTestQueryMap() {
 User user = null;
 User body = null;
 FakeApi.TestBodyWithQueryParamsQueryParams queryParams = new FakeApi.TestBodyWithQueryParamsQueryParams()
 .query(null);
 // api.testBodyWithQueryParams(user, queryParams);
 // api.testBodyWithQueryParams(body, queryParams);

 // TODO: test validations
 }
Expand All@@ -139,8 +139,8 @@ public void testBodyWithQueryParamsTestQueryMap() {
 */
 @Test
 public void testClientModelTest() {
 Client client = null;
 // Client response = api.testClientModel(client);
 Client body = null;
 // Client response = api.testClientModel(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -264,8 +264,8 @@ public void testGroupParametersTestQueryMap() {
 */
 @Test
 public void testInlineAdditionalPropertiesTest() {
 Map<String, String> requestBody = null;
 // api.testInlineAdditionalProperties(requestBody);
 Map<String, String> param = null;
 // api.testInlineAdditionalProperties(param);

 // TODO: test validations
 }
Expand Down

4 changes: 2 additions & 2 deletions
...ore/java/feign/src/test/java/org/openapitools/client/api/FakeClassnameTags123ApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void testClassnameTest() {
 Client client = null;
 // Client response = api.testClassname(client);
 Client body = null;
 // Client response = api.testClassname(body);

 // TODO: test validations
 }
Expand Down

24 changes: 20 additions & 4 deletions
samples/client/petstore/java/feign/src/test/java/org/openapitools/client/api/PetApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@ public void setup() {
 */
 @Test
 public void addPetTest() {
 Pet pet = null;
 // api.addPet(pet);
 Pet body = null;
 // api.addPet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -135,8 +135,8 @@ public void getPetByIdTest() {
 */
 @Test
 public void updatePetTest() {
 Pet pet = null;
 // api.updatePet(pet);
 Pet body = null;
 // api.updatePet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -174,4 +174,20 @@ public void uploadFileTest() {
 }


 /**
 * uploads an image (required)
 *
 * 
 */
 @Test
 public void uploadFileWithRequiredFileTest() {
 Long petId = null;
 File requiredFile = null;
 String additionalMetadata = null;
 // ModelApiResponse response = api.uploadFileWithRequiredFile(petId, requiredFile, additionalMetadata);

 // TODO: test validations
 }


}

4 changes: 2 additions & 2 deletions
...es/client/petstore/java/feign/src/test/java/org/openapitools/client/api/StoreApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,8 +71,8 @@ public void getOrderByIdTest() {
 */
 @Test
 public void placeOrderTest() {
 Order order = null;
 // Order response = api.placeOrder(order);
 Order body = null;
 // Order response = api.placeOrder(body);

 // TODO: test validations
 }
Expand Down

16 changes: 8 additions & 8 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/UserApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void createUserTest() {
 User user = null;
 // api.createUser(user);
 User body = null;
 // api.createUser(body);

 // TODO: test validations
 }
Expand All@@ -44,8 +44,8 @@ public void createUserTest() {
 */
 @Test
 public void createUsersWithArrayInputTest() {
 List<User> user = null;
 // api.createUsersWithArrayInput(user);
 List<User> body = null;
 // api.createUsersWithArrayInput(body);

 // TODO: test validations
 }
Expand All@@ -58,8 +58,8 @@ public void createUsersWithArrayInputTest() {
 */
 @Test
 public void createUsersWithListInputTest() {
 List<User> user = null;
 // api.createUsersWithListInput(user);
 List<User> body = null;
 // api.createUsersWithListInput(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -146,8 +146,8 @@ public void logoutUserTest() {
 @Test
 public void updateUserTest() {
 String username = null;
 User user = null;
 // api.updateUser(username, user);
 User body = null;
 // api.updateUser(username, body);

 // TODO: test validations
 }
Expand Down
Binary file addedsamples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.jar

View file


Open in desktop


Binary file not shown.


5 changes: 5 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.properties

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists

172 changes: 172 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradlew

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Fix missing RequestBody.required of inline request body by ackintosh · Pull Request #1847 · OpenAPITools/openapi-generator · GitHub
Skip to content
Fix missing RequestBody.required of inline request body#1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wing328
merged 5 commits into

from

Jan 14, 2019
 Merged


Fix missing RequestBody.required of inline request body
#1847
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
e624de6

Add test case that reproduce the issue #1782


ackintosh Jan 8, 2019
d7af1d9

Fix missing RequestBody.required


ackintosh Jan 8, 2019
c34a1c2

Update samples


ackintosh Jan 8, 2019
144f3d2

Merge branch 'master' into fix-issue-1782


ackintosh Jan 12, 2019
3a1fedd

Run ensure-up-to-date script


ackintosh Jan 12, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ private void flattenRequestBody(OpenAPI openAPI, String pathname, Operation oper

 // create request body
 RequestBody rb = new RequestBody();
 rb.setRequired(requestBody.getRequired());
 Content content = new Content();
 MediaType mt = new MediaType();
 Schema schema = new Schema();
Expand Down

3 changes: 3 additions & 0 deletions
...les/openapi-generator/src/test/java/org/openapitools/codegen/InlineModelResolverTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,9 @@ public void resolveInlineRequestBodyWithRequired() {

 RequestBody requestBodyReference = openAPI.getPaths().get("/resolve_inline_request_body_with_required").getPost().getRequestBody();
 assertTrue(requestBodyReference.getRequired());

 RequestBody referencedRequestBody = ModelUtils.getReferencedRequestBody(openAPI, requestBodyReference);
 assertTrue(referencedRequestBody.getRequired());
 }

 @Test
Expand Down

8 changes: 4 additions & 4 deletions
...ent/petstore/java/feign/src/test/java/org/openapitools/client/api/AnotherFakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,12 +26,12 @@ public void setup() {
 /**
 * To test special tags
 *
 * To test special tags
 * To test special tags and operation ID starting with number
 */
 @Test
 public void testSpecialTagsTest() {
 Client client = null;
 // Client response = api.testSpecialTags(client);
 public void call123testSpecialTagsTest() {
 Client body = null;
 // Client response = api.call123testSpecialTags(body);

 // TODO: test validations
 }
Expand Down

24 changes: 12 additions & 12 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/FakeApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,8 +51,8 @@ public void fakeOuterBooleanSerializeTest() {
 */
 @Test
 public void fakeOuterCompositeSerializeTest() {
 OuterComposite outerComposite = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(outerComposite);
 OuterComposite body = null;
 // OuterComposite response = api.fakeOuterCompositeSerialize(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -93,8 +93,8 @@ public void fakeOuterStringSerializeTest() {
 */
 @Test
 public void testBodyWithFileSchemaTest() {
 FileSchemaTestClass fileSchemaTestClass = null;
 // api.testBodyWithFileSchema(fileSchemaTestClass);
 FileSchemaTestClass body = null;
 // api.testBodyWithFileSchema(body);

 // TODO: test validations
 }
Expand All@@ -108,8 +108,8 @@ public void testBodyWithFileSchemaTest() {
 @Test
 public void testBodyWithQueryParamsTest() {
 String query = null;
 User user = null;
 // api.testBodyWithQueryParams(query, user);
 User body = null;
 // api.testBodyWithQueryParams(query, body);

 // TODO: test validations
 }
Expand All@@ -124,10 +124,10 @@ public void testBodyWithQueryParamsTest() {
 */
 @Test
 public void testBodyWithQueryParamsTestQueryMap() {
 User user = null;
 User body = null;
 FakeApi.TestBodyWithQueryParamsQueryParams queryParams = new FakeApi.TestBodyWithQueryParamsQueryParams()
 .query(null);
 // api.testBodyWithQueryParams(user, queryParams);
 // api.testBodyWithQueryParams(body, queryParams);

 // TODO: test validations
 }
Expand All@@ -139,8 +139,8 @@ public void testBodyWithQueryParamsTestQueryMap() {
 */
 @Test
 public void testClientModelTest() {
 Client client = null;
 // Client response = api.testClientModel(client);
 Client body = null;
 // Client response = api.testClientModel(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -264,8 +264,8 @@ public void testGroupParametersTestQueryMap() {
 */
 @Test
 public void testInlineAdditionalPropertiesTest() {
 Map<String, String> requestBody = null;
 // api.testInlineAdditionalProperties(requestBody);
 Map<String, String> param = null;
 // api.testInlineAdditionalProperties(param);

 // TODO: test validations
 }
Expand Down

4 changes: 2 additions & 2 deletions
...ore/java/feign/src/test/java/org/openapitools/client/api/FakeClassnameTags123ApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void testClassnameTest() {
 Client client = null;
 // Client response = api.testClassname(client);
 Client body = null;
 // Client response = api.testClassname(body);

 // TODO: test validations
 }
Expand Down

24 changes: 20 additions & 4 deletions
samples/client/petstore/java/feign/src/test/java/org/openapitools/client/api/PetApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@ public void setup() {
 */
 @Test
 public void addPetTest() {
 Pet pet = null;
 // api.addPet(pet);
 Pet body = null;
 // api.addPet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -135,8 +135,8 @@ public void getPetByIdTest() {
 */
 @Test
 public void updatePetTest() {
 Pet pet = null;
 // api.updatePet(pet);
 Pet body = null;
 // api.updatePet(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -174,4 +174,20 @@ public void uploadFileTest() {
 }


 /**
 * uploads an image (required)
 *
 * 
 */
 @Test
 public void uploadFileWithRequiredFileTest() {
 Long petId = null;
 File requiredFile = null;
 String additionalMetadata = null;
 // ModelApiResponse response = api.uploadFileWithRequiredFile(petId, requiredFile, additionalMetadata);

 // TODO: test validations
 }


}

4 changes: 2 additions & 2 deletions
...es/client/petstore/java/feign/src/test/java/org/openapitools/client/api/StoreApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,8 +71,8 @@ public void getOrderByIdTest() {
 */
 @Test
 public void placeOrderTest() {
 Order order = null;
 // Order response = api.placeOrder(order);
 Order body = null;
 // Order response = api.placeOrder(body);

 // TODO: test validations
 }
Expand Down

16 changes: 8 additions & 8 deletions
...les/client/petstore/java/feign/src/test/java/org/openapitools/client/api/UserApiTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ public void setup() {
 */
 @Test
 public void createUserTest() {
 User user = null;
 // api.createUser(user);
 User body = null;
 // api.createUser(body);

 // TODO: test validations
 }
Expand All@@ -44,8 +44,8 @@ public void createUserTest() {
 */
 @Test
 public void createUsersWithArrayInputTest() {
 List<User> user = null;
 // api.createUsersWithArrayInput(user);
 List<User> body = null;
 // api.createUsersWithArrayInput(body);

 // TODO: test validations
 }
Expand All@@ -58,8 +58,8 @@ public void createUsersWithArrayInputTest() {
 */
 @Test
 public void createUsersWithListInputTest() {
 List<User> user = null;
 // api.createUsersWithListInput(user);
 List<User> body = null;
 // api.createUsersWithListInput(body);

 // TODO: test validations
 }
Expand DownExpand Up@@ -146,8 +146,8 @@ public void logoutUserTest() {
 @Test
 public void updateUserTest() {
 String username = null;
 User user = null;
 // api.updateUser(username, user);
 User body = null;
 // api.updateUser(username, body);

 // TODO: test validations
 }
Expand Down
Binary file addedsamples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.jar

View file


Open in desktop


Binary file not shown.


5 changes: 5 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.properties

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists

172 changes: 172 additions & 0 deletions
samples/openapi3/client/petstore/kotlin/gradlew

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading