[WIP] add support to remote files

[ramzimaalej]

PR checklist

• Read the contribution guidelines.
• [] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

[auto-labeler]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[wing328]

@ramzimaalej thanks for the PR.

The -i command line argument in the CLI already supports both local files and remote URLs so you may want to reuse the logic there.

[Catscratch]

Bump! Please merge it into master as soon as it is working.

[ramzimaalej]

using the same code as "-i" command would mean slower execution as it loads and validates the api file, unless we want to undertake a refactoring to make the code look the same. What I did here is to verify if the provided file location is valid, if yes download the file and initiate the processing in the same fashion as a local file

@wing328

[jimschubert]

@ramzimaalej it seems to me (please correct me if I'm wrong), that this doesn't handle split remote files and would in fact break this support? Also, renaming to a single local yaml file seems like this would break when the remote file is JSON.

I'm not following the benefit of including the logic here when it already exists in swagger-parser. Could you provide an example of how this adds value in this scenario?

[wing328]

Closed via #3826

[ramzimaalej]

PR checklist

• Read the contribution guidelines.
• [] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

[auto-labeler]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[wing328]

@ramzimaalej thanks for the PR.

The -i command line argument in the CLI already supports both local files and remote URLs so you may want to reuse the logic there.

[Catscratch]

Bump! Please merge it into master as soon as it is working.

[ramzimaalej]

using the same code as "-i" command would mean slower execution as it loads and validates the api file, unless we want to undertake a refactoring to make the code look the same. What I did here is to verify if the provided file location is valid, if yes download the file and initiate the processing in the same fashion as a local file

@wing328

[jimschubert]

@ramzimaalej it seems to me (please correct me if I'm wrong), that this doesn't handle split remote files and would in fact break this support? Also, renaming to a single local yaml file seems like this would break when the remote file is JSON.

I'm not following the benefit of including the logic here when it already exists in swagger-parser. Could you provide an example of how this adds value in this scenario?

[wing328]

Closed via #3826

[ramzimaalej]

PR checklist

• Read the contribution guidelines.
• [] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

[auto-labeler]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[wing328]

@ramzimaalej thanks for the PR.

The -i command line argument in the CLI already supports both local files and remote URLs so you may want to reuse the logic there.

[Catscratch]

Bump! Please merge it into master as soon as it is working.

[ramzimaalej]

using the same code as "-i" command would mean slower execution as it loads and validates the api file, unless we want to undertake a refactoring to make the code look the same. What I did here is to verify if the provided file location is valid, if yes download the file and initiate the processing in the same fashion as a local file

@wing328

[jimschubert]

@ramzimaalej it seems to me (please correct me if I'm wrong), that this doesn't handle split remote files and would in fact break this support? Also, renaming to a single local yaml file seems like this would break when the remote file is JSON.

I'm not following the benefit of including the logic here when it already exists in swagger-parser. Could you provide an example of how this adds value in this scenario?

[wing328]

Closed via #3826

[ramzimaalej]

PR checklist

• Read the contribution guidelines.
• [] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

[auto-labeler]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[wing328]

@ramzimaalej thanks for the PR.

The -i command line argument in the CLI already supports both local files and remote URLs so you may want to reuse the logic there.

[Catscratch]

Bump! Please merge it into master as soon as it is working.

[ramzimaalej]

using the same code as "-i" command would mean slower execution as it loads and validates the api file, unless we want to undertake a refactoring to make the code look the same. What I did here is to verify if the provided file location is valid, if yes download the file and initiate the processing in the same fashion as a local file

@wing328

[jimschubert]

@ramzimaalej it seems to me (please correct me if I'm wrong), that this doesn't handle split remote files and would in fact break this support? Also, renaming to a single local yaml file seems like this would break when the remote file is JSON.

I'm not following the benefit of including the logic here when it already exists in swagger-parser. Could you provide an example of how this adds value in this scenario?

[wing328]

Closed via #3826

[ramzimaalej]

PR checklist

• Read the contribution guidelines.
• [] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

[auto-labeler]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[wing328]

@ramzimaalej thanks for the PR.

The -i command line argument in the CLI already supports both local files and remote URLs so you may want to reuse the logic there.

[Catscratch]

Bump! Please merge it into master as soon as it is working.

[ramzimaalej]

using the same code as "-i" command would mean slower execution as it loads and validates the api file, unless we want to undertake a refactoring to make the code look the same. What I did here is to verify if the provided file location is valid, if yes download the file and initiate the processing in the same fashion as a local file

@wing328

[jimschubert]

@ramzimaalej it seems to me (please correct me if I'm wrong), that this doesn't handle split remote files and would in fact break this support? Also, renaming to a single local yaml file seems like this would break when the remote file is JSON.

I'm not following the benefit of including the logic here when it already exists in swagger-parser. Could you provide an example of how this adds value in this scenario?

[wing328]

Closed via #3826

[ramzimaalej]

PR checklist

• Read the contribution guidelines.
• [] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

[auto-labeler]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[wing328]

@ramzimaalej thanks for the PR.

The -i command line argument in the CLI already supports both local files and remote URLs so you may want to reuse the logic there.

[Catscratch]

Bump! Please merge it into master as soon as it is working.

[ramzimaalej]

using the same code as "-i" command would mean slower execution as it loads and validates the api file, unless we want to undertake a refactoring to make the code look the same. What I did here is to verify if the provided file location is valid, if yes download the file and initiate the processing in the same fashion as a local file

@wing328

[jimschubert]

@ramzimaalej it seems to me (please correct me if I'm wrong), that this doesn't handle split remote files and would in fact break this support? Also, renaming to a single local yaml file seems like this would break when the remote file is JSON.

I'm not following the benefit of including the logic here when it already exists in swagger-parser. Could you provide an example of how this adds value in this scenario?

[wing328]

Closed via #3826

[ramzimaalej]

PR checklist

• Read the contribution guidelines.
• [] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

[auto-labeler]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[wing328]

@ramzimaalej thanks for the PR.

The -i command line argument in the CLI already supports both local files and remote URLs so you may want to reuse the logic there.

[Catscratch]

Bump! Please merge it into master as soon as it is working.

[ramzimaalej]

using the same code as "-i" command would mean slower execution as it loads and validates the api file, unless we want to undertake a refactoring to make the code look the same. What I did here is to verify if the provided file location is valid, if yes download the file and initiate the processing in the same fashion as a local file

@wing328

[jimschubert]

@ramzimaalej it seems to me (please correct me if I'm wrong), that this doesn't handle split remote files and would in fact break this support? Also, renaming to a single local yaml file seems like this would break when the remote file is JSON.

I'm not following the benefit of including the logic here when it already exists in swagger-parser. Could you provide an example of how this adds value in this scenario?

[wing328]

Closed via #3826

[ramzimaalej]

PR checklist

• Read the contribution guidelines.
• [] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

[auto-labeler]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[wing328]

@ramzimaalej thanks for the PR.

The -i command line argument in the CLI already supports both local files and remote URLs so you may want to reuse the logic there.

[Catscratch]

Bump! Please merge it into master as soon as it is working.

[ramzimaalej]

using the same code as "-i" command would mean slower execution as it loads and validates the api file, unless we want to undertake a refactoring to make the code look the same. What I did here is to verify if the provided file location is valid, if yes download the file and initiate the processing in the same fashion as a local file

@wing328

[jimschubert]

@ramzimaalej it seems to me (please correct me if I'm wrong), that this doesn't handle split remote files and would in fact break this support? Also, renaming to a single local yaml file seems like this would break when the remote file is JSON.

I'm not following the benefit of including the logic here when it already exists in swagger-parser. Could you provide an example of how this adds value in this scenario?

[wing328]

Closed via #3826