Skip to content

[Rust Server] Support multipart/form_data request bodies - #2846

Merged
richardwhiuk merged 5 commits into
OpenAPITools:masterfrom
Metaswitch:multipart_form_data
Aug 4, 2019
Merged

[Rust Server] Support multipart/form_data request bodies#2846
richardwhiuk merged 5 commits into
OpenAPITools:masterfrom
Metaswitch:multipart_form_data

Conversation

@richardwhiuk

Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@frol, @farcaller, @bjgill

Description of the PR

  • Support multipart/form_data in the Rust Server generator
  • Add a new test API to test the change.
  • Update the examples to match

This has been written, and reviewed by myself, and others at @Metaswitch.

- Support multipart/form_data in the Rust Server
- Add a new test API to test the change.
- Update the examples to match
@richardwhiuk

Copy link
Copy Markdown
ContributorAuthor

CI Failure is in the elm code, which should be unrelated (e.g. it's seen in the merge of #2112).

@wing328

Copy link
Copy Markdown
Member

@richardwhiuk right, the CI failure (addressed in the latest master) has nothing to do with this PR.

If you are you free, let's have a quick chat via https://gitter.im (ID: wing328).

@wing328wing328 added this to the 4.0.0 milestone May 9, 2019
@wing328wing328 modified the milestones: 4.0.0, 4.0.1May 13, 2019
@wing328wing328 modified the milestones: 4.0.1, 4.0.2May 31, 2019

@bjgillbjgill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - looks good. I've just got a dependency version question and a minor style tweak.

@wing328wing328 modified the milestones: 4.0.2, 4.0.3Jun 20, 2019
@wing328wing328 modified the milestones: 4.0.3, 4.1.0Jul 9, 2019
@richardwhiuk
richardwhiuk merged commit 6963e5e into OpenAPITools:masterAug 4, 2019
@richardwhiuk
richardwhiuk deleted the multipart_form_data branch August 4, 2019 11:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@richardwhiuk@wing328@bjgill