[Core, HTML2] Rendered docs are incomplete

[richardwhiuk]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
  • No technical committee for HTML 2.

Description of the PR

• Simple aliased types are now passed to the generator

• Body parameters are now provided with their schemas

• Schema block is now visible in the generated documentation

Note, this changes some of the core behaviour, which doesn't pass aliased models to the generator, so may have large scale impacts.

Changes are by @MalachiJones, @mthebridge, @richardwhiuk and others at @Metaswitch

This fixes#1441

[macjohnny]

will find node alway return a result here?

[macjohnny]

can you explain what is the impact of this change?

[macjohnny]

@richardwhiuk thanks for your PR!

[eclipse1985]

Is this related to #2427 ?

[frank-schoenheit-red6es]

anybody here who can bring this forward? Recently migrated to openapi-generator from swagger-generator, and using the html generator as an opportunity to publish a "have a quick look" version of the API documentation during a Jenkins build. The bug here breaks this approach :-(

[macjohnny]

@richardwhiuk can you resolve the conflicts?

[richardwhiuk]

@macjohnny Yeah, I'll resolve the conflicts.

We've spotted some bugs that occur with this fix that I think should be covered along with this fix - I'll try and get those resolved this week.

[frank-schoenheit-red6es]

thanks for your efforts, guys!

[eclipse1985]

@richardwhiuk any update :)?

[Fjolnir-Dvorak]

Thank you for the merge request. I tried it a few minutes ago and merged it with the latest master. Simple objects are working but if objects are nested it still does not work. Concerning the merge conflict I accepted the master and tried also to comment the defaultGenerator passage out as the pull request did.
I hope I will remember to design a simple test yaml to visualize the error which I will post here

The problem I found so far occurs if the response is a list of objects.

paths:
/url:
post:
responses:
200:
description: successful operation
content:
application/json:
schema:
type:
array
items:
$ref: '#/components/schemas/AdvData'

[rachanadeshmukh]

Hi, are there any updates on the status of merging this fix? My team is currently dependent on this in order to generate static html2 documentation based on openapi specs that contain all the required annotated documentation (including request schemas). We are using the gradle plugin for this.

[JonarJr]

any updates for this fix?

[masci]

Patch in #5643 works for me

[jimschubert]

I've merged master into this code and opened/merged #7510

As mentioned earlier, #5643 was opened with a similar fix, but after checking the code between the two branches it looks like that PR just copied this code and refactored. I'm pretty big on attribution of contributions, so I've replaced the findNode changes from #5643 with the findNode implementation from this PR.