Uh oh!
There was an error while loading. Please reload this page.
Bugfix/3248 - #3857
Conversation
jimschubert
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've left a few comments.
| * @param schema potentially containing a '$ref' | ||
| * @return true if it's a model with at least one properties | ||
| */ | ||
| public static boolean isModel(Schema schema) { |
There was a problem hiding this comment.
Removing a public helper is a breaking change (these are used by programmatic consumers, and this would therefore need to be deprecated before removal).
| // property.baseType = getSimpleRef(p.get$ref()); | ||
| //} | ||
| // --END of revision | ||
| property.isModel = ModelUtils.isModel(p); |
There was a problem hiding this comment.
If you're changing the template to not use isModel, we should keep this as the change affects all generators. See my resolution in #3855, which sets isModel as expected (after the naive attempt done in setNonArrayMapProperty.
| } | ||
| @Test | ||
| public void objectQueryParamIdentifyAsObject() { |
There was a problem hiding this comment.
NOTE: Removing this test/functionality would be considered a breaking change and would need to be documented as a regression.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)