Skip to content

[scala][client] ScalaAkkaClientCodegenTest: refactor assertions - #3893

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
sullis:ScalaAkkaClientCodegenTest-refactor-assertions
Sep 16, 2019
Merged

[scala][client] ScalaAkkaClientCodegenTest: refactor assertions#3893
wing328 merged 1 commit into
OpenAPITools:masterfrom
sullis:ScalaAkkaClientCodegenTest-refactor-assertions

Conversation

@sullis

@sullissullis commented Sep 15, 2019

Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@sullissullis changed the title ScalaAkkaClientCodegenTest: refactor assertions[scala][client] ScalaAkkaClientCodegenTest: refactor assertionsSep 15, 2019
@sullis

Copy link
Copy Markdown
ContributorAuthor

@wing328

@wing328

Copy link
Copy Markdown
Member

cc @clasnake (2017/07) @jimschubert (2017/09) @shijinkui (2018/01) @ramzimaalej (2018/03)

@ramzimaalejramzimaalej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328
wing328 merged commit 3f9d1b1 into OpenAPITools:masterSep 16, 2019
@sullis
sullis deleted the ScalaAkkaClientCodegenTest-refactor-assertions branch September 16, 2019 17:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sullis@wing328@ramzimaalej