Skip to content

Kotlin client multiple enums - #3928

Closed
andrewemery wants to merge 2 commits into
OpenAPITools:masterfrom
andrewemery:kotlin-client-multiple-enums
Closed

Kotlin client multiple enums#3928
andrewemery wants to merge 2 commits into
OpenAPITools:masterfrom
andrewemery:kotlin-client-multiple-enums

Conversation

@andrewemery

Copy link
Copy Markdown
Contributor

Fix for #3917.

@wing328

Copy link
Copy Markdown
Member

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328wing328 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once you fix the commit authorship, I'll merge it into master.

@andrewemery

andrewemery commented Sep 25, 2019

Copy link
Copy Markdown
ContributorAuthor

@wing328 Thanks. I'll fix up the attribution but I'll let you decide if you want to merge.
This fix was also included as part of #3900

@andrewemery
andrewemeryforce-pushed the kotlin-client-multiple-enums branch from 0c89bed to 8d7ffd0CompareSeptember 25, 2019 03:08
@wing328

Copy link
Copy Markdown
Member

@andrewemery ah I thought you undo those changes in #3900 and filed a separate PR instead.

@wing328wing328 closed this Sep 25, 2019
@andrewemery

Copy link
Copy Markdown
ContributorAuthor

@wing328 Thanks. I kept the fix in because it touched that part of the template, but I raised a separate pull request because I assumed #3900 would take much longer to get merged.

@wing328

Copy link
Copy Markdown
Member

@andrewemery that's ok. (I wasn't clear to begin with).

Do you have a Twitter account? We'll tag you in a tweet to promote the multi-platform client.

@andrewemery

Copy link
Copy Markdown
ContributorAuthor

@wing328 No, but thank you for asking.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewemery@wing328@richardwhiuk