Skip to content

[Kotlin][multiplatform] minor improvements - #3931

Merged
wing328 merged 5 commits into
masterfrom
kotlin-multiplatform-improve
Sep 22, 2019
Merged

[Kotlin][multiplatform] minor improvements#3931
wing328 merged 5 commits into
masterfrom
kotlin-multiplatform-improve

Conversation

@wing328

@wing328wing328 commented Sep 21, 2019

Copy link
Copy Markdown
Member

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • test the client in the CI
  • better code format

cc @andrewemery (contributor of Kotlin multiplatform client)

cc @jimschubert (2017/09), @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04)

@andrewemeryandrewemery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@wing328
wing328 merged commit 91a610e into masterSep 22, 2019
@wing328
wing328 deleted the kotlin-multiplatform-improve branch September 22, 2019 02:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wing328@andrewemery