Uh oh!
There was an error while loading. Please reload this page.
Fix Kotlin query collection format - #4248
Merged
wing328 merged 2 commits intoOct 29, 2019
Merged
Conversation
The OpenApi codegen converts OpenApi v2 documents into an OpenApi v3 representation. The query parameter collection formats are squeezed into different values from the raw OpenApi 2 collection format values. For example: csv -> space See: DefaultCodegen#getCollectionFormat
andrewemeryforce-pushed
the
kotlin-query-collection-format
branch
from
October 28, 2019 09:44
06bc9af to
ee1ccdaComparewing328
commented
Oct 28, 2019
Member
cc @jimschubert (2017/09), @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) |
wing328
approved these changes
Oct 28, 2019
wing328
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix, which looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect query header collection constants
The OpenAPI generator converts OpenAPI v2 documents into an OpenAPI v3
representation. The query parameter collection formats are squeezed
into different values from the raw OpenAPI 2 collection format values.
For example: csv -> space
See: DefaultCodegen#getCollectionFormat
To fix#4285