You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a composed schema has required attributes, it incorrectly adds duplicate optionalVars from the parent which should have been in the requiredVars and deduplicated.
If contributing template-only or documentation-only changes which will change sample output, build the project before.
Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@mtraynham thanks for the PR, which looks good to me.
wing328
changed the title
[default codegen] #4171 - Correct parent variables being duplicated in child[default codegen] Correct parent variables being duplicated in childNov 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4171.
When a composed schema has
requiredattributes, it incorrectly adds duplicateoptionalVarsfrom the parent which should have been in therequiredVarsand deduplicated.For example:
{ "Parent": { "required": [ "a" ], "type": "object", "properties": { "a": { "type": "string" } } }, "Child": { "required": [ "a", "c" ], "type": "object", "allOf": [ { "$ref": "#/components/schemas/Parent" }, { "type": "object", "properties": { "c": { "type": "string" } } } ] } }If a template loops required and optional properties separately it generates something like the following, where the property
cis duplicated:The composedSchema required attributes should be added to both
requiredandallRequiredarrays.I added tests to check both this functionality and where the child has the
requiredproperty, not the composed model.PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.1.x,5.0.x. Default:master.Not sure who to attach to this... @wing328