Implement Server Stub Code for Vert.x Web by lwlee2608 · Pull Request #4286 · OpenAPITools/openapi-generator

lwlee2608 · 2019-10-26T12:18:14Z

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project before.
Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add server generation java-vertx-web which use Vert.x-Web

cc @wing328 @jimschubert @cbornet @ackintosh @jmini @etherealjoy

For #115

Signed-off-by: lwlee2608 <lwlee2608@gmail.com>

wing328 · 2019-10-27T04:12:05Z

+
+# if you've executed sbt assembly previously it will use that instead.
+export JAVA_OPTS="${JAVA_OPTS} -Xmx1024M -DloggerPath=conf/log4j.properties"
+ags="generate -i $SPEC -g $GENERATOR --artifact-id java-vertx-web-rx-server -o $STUB_DIR --additional-properties hideGenerationTimestamp=true $@"


Minor suggestion: adding -t with the resource (template) folder so that we don't need to recompile the whole project if we're only changing the templates.

i see, good idea.

wing328 · 2019-10-27T04:12:38Z

@@ -0,0 +1,162 @@
+/*
+ * Copyright 2018 OpenAPI-Generator Contributors (https://openapi-generator.tech)
+ * Copyright 2018 SmartBear Software


@lwlee2608 I don't think we need line 3 as per https://opensource.stackexchange.com/questions/7300/copyright-notice-in-the-file-header-apache-v2-license/7301#7301

wing328 · 2019-10-27T04:14:17Z

+
+To build the project using maven, run:
+```bash
+mvn package && java -jar target/target/java-vertx-web-rx-server-1.0.0-SNAPSHOT-fat.jar


Do we need to use {{artifactVersion}} instead of hard-coded 1.0.0-SNAPSHOT?

my mistake, done

wing328 · 2019-10-27T04:29:48Z

Tested locally and the result is good:

[INFO] skip non existing resourceDirectory /private/tmp/vertx2/src/test/resources
[INFO] [INFO] --- maven-compiler-plugin:3.3:testCompile (default-testCompile) @ openapi-java-vertx-web-server ---
[INFO] No sources to compile
[INFO] [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ openapi-java-vertx-web-server ---
[INFO] No tests to run.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.732 s
[INFO] Finished at: 2019-10-27T12:29:13+08:00
[INFO] ------------------------------------------------------------------------

wing328 · 2019-10-27T04:32:25Z

Please add a new entry for testing in https://github.com/OpenAPITools/openapi-generator/blob/master/pom.xml#L1166

If the output works with JDK7 as well, please also add an entry to https://github.com/OpenAPITools/openapi-generator/blob/master/pom.xml#L1205

…fromOperation(). Also remove unused annotation import from model

lwlee2608 · 2019-10-27T07:11:22Z

@wing328 all comments have been addressed. Please review

The server uses Java8 feature extensively, therefore does not work in JDK7 or lower.

wing328

LGTM. Let's merge it into master and get some feedback from the community.

wing328 · 2019-10-28T06:08:54Z

@lwlee2608 thanks for the new generator, which has been merged into master.

For your upcoming PRs, I would recommend creating a new branch as per git best practice.

wing328 · 2019-10-31T09:13:57Z

@lwlee2608 thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

lwlee2608 added 17 commits July 19, 2019 16:45

InlineResolver to flatten callback operations
4bfd819
Signed-off-by: lwlee2608 <lwlee2608@gmail.com>

Merge remote-tracking branch 'origin/master'
cf9c013

Merge remote-tracking branch 'upstream/master'
2dac28a

clone from VertxServerCodegen, to new VertxWebServerCodegen
30e5619

Merge remote-tracking branch 'upstream/master'
d429663

fix compilation error in VertxWebCodegn
cf25454

Start working on VertxWebServerCodegen, adding support files
8ab01a4

add server api handler
4c76f6f

add server api and fix yaml spec file generation
748d33e

link api to apiHandler
3ce43b9

convert vertx parameters into API model
28a611a

add support to multipart/form-data upload files
8e6f751

ability to set http status code from ApiImpl
85fded7

replace rootPackage with invokerPackage
1e23f3c

add readme and sample
e3046b4

Merge remote-tracking branch 'upstream/master'
2beadb1

fix circleCi error
99c6d9c

wing328 reviewed Oct 27, 2019
View reviewed changes

wing328 added this to the 4.2.0 milestone Oct 27, 2019

wing328 reviewed Oct 27, 2019
View reviewed changes

Comment thread...pi-generator/src/main/java/org/openapitools/codegen/languages/JavaVertXWebServerCodegen.java

wing328 reviewed Oct 27, 2019
View reviewed changes

Comment thread...pi-generator/src/main/java/org/openapitools/codegen/languages/JavaVertXWebServerCodegen.java Outdated

lwlee2608 added 5 commits October 27, 2019 13:26

override file to FileUpload in typeMapping, no need to override from …
302e2e0
…fromOperation(). Also remove unused annotation import from model

remove smartBear software copyright
5ee3360

use {{artifactVersion}} instead of hardcode version in readme
e83c8ca

add -t flag in generation script
8cf2a1b

add generated vertx-web server to master pom for testing
3c389fd

wing328 approved these changes Oct 28, 2019
View reviewed changes

wing328 added Enhancement: New generator Server: Java labels Oct 28, 2019

wing328 merged commit 0f2272d into OpenAPITools:masterOct 28, 2019

wing328 mentioned this pull request Oct 28, 2019
Adds OpenAPI generator vert-x3/vertx-awesome#157
Merged

wing328 changed the title ~~Implement Server Stub Code for Vert.x Web #115~~Implement Server Stub Code for Vert.x WebOct 31, 2019

Uh oh!

Uh oh!

Conversation

lwlee2608 commented Oct 26, 2019• edited by wing328 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Description of the PR

Uh oh!

wing328Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

lwlee2608Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

wing328Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

lwlee2608Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

wing328Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

lwlee2608Oct 27, 2019

Choose a reason for hiding this comment

Uh oh!

wing328 commented Oct 27, 2019

Uh oh!

wing328 commented Oct 27, 2019

Uh oh!

Uh oh!

Uh oh!

lwlee2608 commented Oct 27, 2019

Uh oh!

wing328 left a comment

Choose a reason for hiding this comment

Uh oh!

wing328 commented Oct 28, 2019

Uh oh!

wing328 commented Oct 31, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lwlee2608 commented Oct 26, 2019•
edited by wing328
Loading

wing328 commented Oct 31, 2019•
edited
Loading