csharp-netcore: Replace null literals with default - #4345

Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom
kimsey0:patch-1
Nov 3, 2019
Merged

csharp-netcore: Replace null literals with default#4345
wing328 merged 2 commits into
OpenAPITools:masterfrom
kimsey0:patch-1

Conversation

@kimsey0

@kimsey0kimsey0 commented Nov 1, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#4343
Same fix as applied to the csharp generator in #3537

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@kimsey0
csharp-netcore: Replace null literals with default
a3eaf58
Same fix as applied to the csharp generator in #3537
@wiruzman

wiruzman commented Nov 1, 2019

Copy link
Copy Markdown
Contributor

Maybe you should make the PR to 4.2.x branch.

@kimsey0

kimsey0 commented Nov 1, 2019

Copy link
Copy Markdown
ContributorAuthor

@wiruzman: As I understand the branch guidelines, changes to be included in the next patch release should be made to master.

@kimsey0

kimsey0 commented Nov 1, 2019

Copy link
Copy Markdown
ContributorAuthor

@mandrean, @jimschubert, @frankyjuang, any of you that can look at this?

@wing328wing328 added this to the 4.2.1 milestone Nov 3, 2019
@wing328
wing328 merged commit f352fa6 into OpenAPITools:masterNov 3, 2019
@kimsey0
kimsey0 deleted the patch-1 branch November 3, 2019 17:35
jimschubert added a commit that referenced this pull request Nov 3, 2019
@jimschubert
Merge branch 'master' of github.com:OpenAPITools/openapi-generator
2a2c5c5
* 'master' of github.com:OpenAPITools/openapi-generator: (88 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit that referenced this pull request Nov 3, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
381fe91
* master: (142 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Nov 3, 2019
@jimschubert
Merge branch 'master' into meta-codegen-improvements
2c41f8c
* master: (141 commits)
smaller tests, better code format (OpenAPITools#4355)
csharp-netcore: Replace null literals with default (OpenAPITools#4345)
[core] consider polymorphism when computing unused schemas (OpenAPITools#4335)
Fix issue 4326 forward throws for delegate to main method (OpenAPITools#4327)
[kotlin][client] annotate api exceptions (OpenAPITools#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (OpenAPITools#4353)
Remove deprecated API use of ObjectFactory.property() (OpenAPITools#2613) (OpenAPITools#4352)
[python][metadata]: Adding license and author fields (OpenAPITools#4318)
[Python] Avoid pep8 violation (OpenAPITools#4316)
[JS] Update package.json (OpenAPITools#4261)
Add slash-arun to Python technical committee (OpenAPITools#4354)
[typescript-fetch] Fix discriminator mapping name (OpenAPITools#4340)
fix security alerts reported by github (OpenAPITools#4344)
fix cpp-restbed-server json field serialization OpenAPITools#4320 (OpenAPITools#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (OpenAPITools#4341)
fix(typescript-angular): do not call .toISOString() on a string (OpenAPITools#4330) (OpenAPITools#4337)
update samples (OpenAPITools#4334)
Prepare 4.2.0 release (OpenAPITools#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (OpenAPITools#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (OpenAPITools#4056)
...
@jimschubert

jimschubert commented Nov 3, 2019

Copy link
Copy Markdown
Member

Thanks for the fix!

@kimsey0

kimsey0 commented Nov 3, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks for the quick merge. I'm looking forward to the release in a few weeks.

@wing328

wing328 commented Nov 15, 2019

Copy link
Copy Markdown
Member

@kimsey0 thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168

@kimsey0

kimsey0 commented Nov 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Thank you! We have already started using the new version.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Client: C-SharpIssue: Bug

Projects

None yet

Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

[BUG] [csharp-netcore] Generating invalid null default values for enum parameters in API

4 participants

@kimsey0@wiruzman@jimschubert@wing328
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
csharp-netcore: Replace null literals with default - #4345
Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Nov 3, 2019
Merged
csharp-netcore: Replace null literals with default#4345
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Conversation
@kimsey0
@kimsey0kimsey0
commented
Nov 1, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#4343

Same fix as applied to the csharp generator in #3537
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@kimsey0
csharp-netcore: Replace null literals with default
a3eaf58
Same fix as applied to the csharp generator in #3537
@wiruzman
wiruzman
commented
Nov 1, 2019

Copy link


Copy Markdown

Contributor
Maybe you should make the PR to 4.2.x branch.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@wiruzman: As I understand the branch guidelines, changes to be included in the next patch release should be made to master.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@mandrean, @jimschubert, @frankyjuang, any of you that can look at this?
@wing328wing328
added this to the 4.2.1 milestone
Nov 3, 2019
@wing328
wing328
merged commit f352fa6
into
OpenAPITools:masterNov 3, 2019
@kimsey0
kimsey0
deleted the

patch-1

branch
November 3, 2019 17:35
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' of github.com:OpenAPITools/openapi-generator
2a2c5c5
* 'master' of github.com:OpenAPITools/openapi-generator: (88 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
381fe91
* master: (142 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into meta-codegen-improvements
2c41f8c
* master: (141 commits)
smaller tests, better code format (OpenAPITools#4355)
csharp-netcore: Replace null literals with default (OpenAPITools#4345)
[core] consider polymorphism when computing unused schemas (OpenAPITools#4335)
Fix issue 4326 forward throws for delegate to main method (OpenAPITools#4327)
[kotlin][client] annotate api exceptions (OpenAPITools#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (OpenAPITools#4353)
Remove deprecated API use of ObjectFactory.property() (OpenAPITools#2613) (OpenAPITools#4352)
[python][metadata]: Adding license and author fields (OpenAPITools#4318)
[Python] Avoid pep8 violation (OpenAPITools#4316)
[JS] Update package.json (OpenAPITools#4261)
Add slash-arun to Python technical committee (OpenAPITools#4354)
[typescript-fetch] Fix discriminator mapping name (OpenAPITools#4340)
fix security alerts reported by github (OpenAPITools#4344)
fix cpp-restbed-server json field serialization OpenAPITools#4320 (OpenAPITools#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (OpenAPITools#4341)
fix(typescript-angular): do not call .toISOString() on a string (OpenAPITools#4330) (OpenAPITools#4337)
update samples (OpenAPITools#4334)
Prepare 4.2.0 release (OpenAPITools#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (OpenAPITools#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (OpenAPITools#4056)
...
@jimschubert
jimschubert
commented
Nov 3, 2019

Copy link


Copy Markdown

Member
Thanks for the fix!
@kimsey0
kimsey0
commented
Nov 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks for the quick merge. I'm looking forward to the release in a few weeks.
@wing328
wing328
commented
Nov 15, 2019

Copy link


Copy Markdown

Member
@kimsey0 thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168
@kimsey0
kimsey0
commented
Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you! We have already started using the new version.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: C-SharpIssue: Bug

Projects


None yet


Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

[BUG] [csharp-netcore] Generating invalid null default values for enum parameters in API


4 participants

@kimsey0@wiruzman@jimschubert@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
csharp-netcore: Replace null literals with default - #4345
Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Nov 3, 2019
Merged
csharp-netcore: Replace null literals with default#4345
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Conversation
@kimsey0
@kimsey0kimsey0
commented
Nov 1, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#4343

Same fix as applied to the csharp generator in #3537
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@kimsey0
csharp-netcore: Replace null literals with default
a3eaf58
Same fix as applied to the csharp generator in #3537
@wiruzman
wiruzman
commented
Nov 1, 2019

Copy link


Copy Markdown

Contributor
Maybe you should make the PR to 4.2.x branch.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@wiruzman: As I understand the branch guidelines, changes to be included in the next patch release should be made to master.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@mandrean, @jimschubert, @frankyjuang, any of you that can look at this?
@wing328wing328
added this to the 4.2.1 milestone
Nov 3, 2019
@wing328
wing328
merged commit f352fa6
into
OpenAPITools:masterNov 3, 2019
@kimsey0
kimsey0
deleted the

patch-1

branch
November 3, 2019 17:35
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' of github.com:OpenAPITools/openapi-generator
2a2c5c5
* 'master' of github.com:OpenAPITools/openapi-generator: (88 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
381fe91
* master: (142 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into meta-codegen-improvements
2c41f8c
* master: (141 commits)
smaller tests, better code format (OpenAPITools#4355)
csharp-netcore: Replace null literals with default (OpenAPITools#4345)
[core] consider polymorphism when computing unused schemas (OpenAPITools#4335)
Fix issue 4326 forward throws for delegate to main method (OpenAPITools#4327)
[kotlin][client] annotate api exceptions (OpenAPITools#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (OpenAPITools#4353)
Remove deprecated API use of ObjectFactory.property() (OpenAPITools#2613) (OpenAPITools#4352)
[python][metadata]: Adding license and author fields (OpenAPITools#4318)
[Python] Avoid pep8 violation (OpenAPITools#4316)
[JS] Update package.json (OpenAPITools#4261)
Add slash-arun to Python technical committee (OpenAPITools#4354)
[typescript-fetch] Fix discriminator mapping name (OpenAPITools#4340)
fix security alerts reported by github (OpenAPITools#4344)
fix cpp-restbed-server json field serialization OpenAPITools#4320 (OpenAPITools#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (OpenAPITools#4341)
fix(typescript-angular): do not call .toISOString() on a string (OpenAPITools#4330) (OpenAPITools#4337)
update samples (OpenAPITools#4334)
Prepare 4.2.0 release (OpenAPITools#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (OpenAPITools#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (OpenAPITools#4056)
...
@jimschubert
jimschubert
commented
Nov 3, 2019

Copy link


Copy Markdown

Member
Thanks for the fix!
@kimsey0
kimsey0
commented
Nov 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks for the quick merge. I'm looking forward to the release in a few weeks.
@wing328
wing328
commented
Nov 15, 2019

Copy link


Copy Markdown

Member
@kimsey0 thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168
@kimsey0
kimsey0
commented
Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you! We have already started using the new version.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: C-SharpIssue: Bug

Projects


None yet


Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

[BUG] [csharp-netcore] Generating invalid null default values for enum parameters in API


4 participants

@kimsey0@wiruzman@jimschubert@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
csharp-netcore: Replace null literals with default - #4345
Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Nov 3, 2019
Merged
csharp-netcore: Replace null literals with default#4345
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Conversation
@kimsey0
@kimsey0kimsey0
commented
Nov 1, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#4343

Same fix as applied to the csharp generator in #3537
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@kimsey0
csharp-netcore: Replace null literals with default
a3eaf58
Same fix as applied to the csharp generator in #3537
@wiruzman
wiruzman
commented
Nov 1, 2019

Copy link


Copy Markdown

Contributor
Maybe you should make the PR to 4.2.x branch.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@wiruzman: As I understand the branch guidelines, changes to be included in the next patch release should be made to master.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@mandrean, @jimschubert, @frankyjuang, any of you that can look at this?
@wing328wing328
added this to the 4.2.1 milestone
Nov 3, 2019
@wing328
wing328
merged commit f352fa6
into
OpenAPITools:masterNov 3, 2019
@kimsey0
kimsey0
deleted the

patch-1

branch
November 3, 2019 17:35
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' of github.com:OpenAPITools/openapi-generator
2a2c5c5
* 'master' of github.com:OpenAPITools/openapi-generator: (88 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
381fe91
* master: (142 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into meta-codegen-improvements
2c41f8c
* master: (141 commits)
smaller tests, better code format (OpenAPITools#4355)
csharp-netcore: Replace null literals with default (OpenAPITools#4345)
[core] consider polymorphism when computing unused schemas (OpenAPITools#4335)
Fix issue 4326 forward throws for delegate to main method (OpenAPITools#4327)
[kotlin][client] annotate api exceptions (OpenAPITools#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (OpenAPITools#4353)
Remove deprecated API use of ObjectFactory.property() (OpenAPITools#2613) (OpenAPITools#4352)
[python][metadata]: Adding license and author fields (OpenAPITools#4318)
[Python] Avoid pep8 violation (OpenAPITools#4316)
[JS] Update package.json (OpenAPITools#4261)
Add slash-arun to Python technical committee (OpenAPITools#4354)
[typescript-fetch] Fix discriminator mapping name (OpenAPITools#4340)
fix security alerts reported by github (OpenAPITools#4344)
fix cpp-restbed-server json field serialization OpenAPITools#4320 (OpenAPITools#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (OpenAPITools#4341)
fix(typescript-angular): do not call .toISOString() on a string (OpenAPITools#4330) (OpenAPITools#4337)
update samples (OpenAPITools#4334)
Prepare 4.2.0 release (OpenAPITools#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (OpenAPITools#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (OpenAPITools#4056)
...
@jimschubert
jimschubert
commented
Nov 3, 2019

Copy link


Copy Markdown

Member
Thanks for the fix!
@kimsey0
kimsey0
commented
Nov 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks for the quick merge. I'm looking forward to the release in a few weeks.
@wing328
wing328
commented
Nov 15, 2019

Copy link


Copy Markdown

Member
@kimsey0 thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168
@kimsey0
kimsey0
commented
Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you! We have already started using the new version.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: C-SharpIssue: Bug

Projects


None yet


Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

[BUG] [csharp-netcore] Generating invalid null default values for enum parameters in API


4 participants

@kimsey0@wiruzman@jimschubert@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
csharp-netcore: Replace null literals with default - #4345
Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Nov 3, 2019
Merged
csharp-netcore: Replace null literals with default#4345
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Conversation
@kimsey0
@kimsey0kimsey0
commented
Nov 1, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#4343

Same fix as applied to the csharp generator in #3537
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@kimsey0
csharp-netcore: Replace null literals with default
a3eaf58
Same fix as applied to the csharp generator in #3537
@wiruzman
wiruzman
commented
Nov 1, 2019

Copy link


Copy Markdown

Contributor
Maybe you should make the PR to 4.2.x branch.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@wiruzman: As I understand the branch guidelines, changes to be included in the next patch release should be made to master.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@mandrean, @jimschubert, @frankyjuang, any of you that can look at this?
@wing328wing328
added this to the 4.2.1 milestone
Nov 3, 2019
@wing328
wing328
merged commit f352fa6
into
OpenAPITools:masterNov 3, 2019
@kimsey0
kimsey0
deleted the

patch-1

branch
November 3, 2019 17:35
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' of github.com:OpenAPITools/openapi-generator
2a2c5c5
* 'master' of github.com:OpenAPITools/openapi-generator: (88 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
381fe91
* master: (142 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into meta-codegen-improvements
2c41f8c
* master: (141 commits)
smaller tests, better code format (OpenAPITools#4355)
csharp-netcore: Replace null literals with default (OpenAPITools#4345)
[core] consider polymorphism when computing unused schemas (OpenAPITools#4335)
Fix issue 4326 forward throws for delegate to main method (OpenAPITools#4327)
[kotlin][client] annotate api exceptions (OpenAPITools#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (OpenAPITools#4353)
Remove deprecated API use of ObjectFactory.property() (OpenAPITools#2613) (OpenAPITools#4352)
[python][metadata]: Adding license and author fields (OpenAPITools#4318)
[Python] Avoid pep8 violation (OpenAPITools#4316)
[JS] Update package.json (OpenAPITools#4261)
Add slash-arun to Python technical committee (OpenAPITools#4354)
[typescript-fetch] Fix discriminator mapping name (OpenAPITools#4340)
fix security alerts reported by github (OpenAPITools#4344)
fix cpp-restbed-server json field serialization OpenAPITools#4320 (OpenAPITools#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (OpenAPITools#4341)
fix(typescript-angular): do not call .toISOString() on a string (OpenAPITools#4330) (OpenAPITools#4337)
update samples (OpenAPITools#4334)
Prepare 4.2.0 release (OpenAPITools#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (OpenAPITools#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (OpenAPITools#4056)
...
@jimschubert
jimschubert
commented
Nov 3, 2019

Copy link


Copy Markdown

Member
Thanks for the fix!
@kimsey0
kimsey0
commented
Nov 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks for the quick merge. I'm looking forward to the release in a few weeks.
@wing328
wing328
commented
Nov 15, 2019

Copy link


Copy Markdown

Member
@kimsey0 thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168
@kimsey0
kimsey0
commented
Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you! We have already started using the new version.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: C-SharpIssue: Bug

Projects


None yet


Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

[BUG] [csharp-netcore] Generating invalid null default values for enum parameters in API


4 participants

@kimsey0@wiruzman@jimschubert@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
csharp-netcore: Replace null literals with default - #4345
Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Nov 3, 2019
Merged
csharp-netcore: Replace null literals with default#4345
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Conversation
@kimsey0
@kimsey0kimsey0
commented
Nov 1, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#4343

Same fix as applied to the csharp generator in #3537
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@kimsey0
csharp-netcore: Replace null literals with default
a3eaf58
Same fix as applied to the csharp generator in #3537
@wiruzman
wiruzman
commented
Nov 1, 2019

Copy link


Copy Markdown

Contributor
Maybe you should make the PR to 4.2.x branch.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@wiruzman: As I understand the branch guidelines, changes to be included in the next patch release should be made to master.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@mandrean, @jimschubert, @frankyjuang, any of you that can look at this?
@wing328wing328
added this to the 4.2.1 milestone
Nov 3, 2019
@wing328
wing328
merged commit f352fa6
into
OpenAPITools:masterNov 3, 2019
@kimsey0
kimsey0
deleted the

patch-1

branch
November 3, 2019 17:35
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' of github.com:OpenAPITools/openapi-generator
2a2c5c5
* 'master' of github.com:OpenAPITools/openapi-generator: (88 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
381fe91
* master: (142 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into meta-codegen-improvements
2c41f8c
* master: (141 commits)
smaller tests, better code format (OpenAPITools#4355)
csharp-netcore: Replace null literals with default (OpenAPITools#4345)
[core] consider polymorphism when computing unused schemas (OpenAPITools#4335)
Fix issue 4326 forward throws for delegate to main method (OpenAPITools#4327)
[kotlin][client] annotate api exceptions (OpenAPITools#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (OpenAPITools#4353)
Remove deprecated API use of ObjectFactory.property() (OpenAPITools#2613) (OpenAPITools#4352)
[python][metadata]: Adding license and author fields (OpenAPITools#4318)
[Python] Avoid pep8 violation (OpenAPITools#4316)
[JS] Update package.json (OpenAPITools#4261)
Add slash-arun to Python technical committee (OpenAPITools#4354)
[typescript-fetch] Fix discriminator mapping name (OpenAPITools#4340)
fix security alerts reported by github (OpenAPITools#4344)
fix cpp-restbed-server json field serialization OpenAPITools#4320 (OpenAPITools#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (OpenAPITools#4341)
fix(typescript-angular): do not call .toISOString() on a string (OpenAPITools#4330) (OpenAPITools#4337)
update samples (OpenAPITools#4334)
Prepare 4.2.0 release (OpenAPITools#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (OpenAPITools#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (OpenAPITools#4056)
...
@jimschubert
jimschubert
commented
Nov 3, 2019

Copy link


Copy Markdown

Member
Thanks for the fix!
@kimsey0
kimsey0
commented
Nov 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks for the quick merge. I'm looking forward to the release in a few weeks.
@wing328
wing328
commented
Nov 15, 2019

Copy link


Copy Markdown

Member
@kimsey0 thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168
@kimsey0
kimsey0
commented
Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you! We have already started using the new version.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: C-SharpIssue: Bug

Projects


None yet


Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

[BUG] [csharp-netcore] Generating invalid null default values for enum parameters in API


4 participants

@kimsey0@wiruzman@jimschubert@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
csharp-netcore: Replace null literals with default - #4345
Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Nov 3, 2019
Merged
csharp-netcore: Replace null literals with default#4345
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Conversation
@kimsey0
@kimsey0kimsey0
commented
Nov 1, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#4343

Same fix as applied to the csharp generator in #3537
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@kimsey0
csharp-netcore: Replace null literals with default
a3eaf58
Same fix as applied to the csharp generator in #3537
@wiruzman
wiruzman
commented
Nov 1, 2019

Copy link


Copy Markdown

Contributor
Maybe you should make the PR to 4.2.x branch.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@wiruzman: As I understand the branch guidelines, changes to be included in the next patch release should be made to master.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@mandrean, @jimschubert, @frankyjuang, any of you that can look at this?
@wing328wing328
added this to the 4.2.1 milestone
Nov 3, 2019
@wing328
wing328
merged commit f352fa6
into
OpenAPITools:masterNov 3, 2019
@kimsey0
kimsey0
deleted the

patch-1

branch
November 3, 2019 17:35
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' of github.com:OpenAPITools/openapi-generator
2a2c5c5
* 'master' of github.com:OpenAPITools/openapi-generator: (88 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
381fe91
* master: (142 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into meta-codegen-improvements
2c41f8c
* master: (141 commits)
smaller tests, better code format (OpenAPITools#4355)
csharp-netcore: Replace null literals with default (OpenAPITools#4345)
[core] consider polymorphism when computing unused schemas (OpenAPITools#4335)
Fix issue 4326 forward throws for delegate to main method (OpenAPITools#4327)
[kotlin][client] annotate api exceptions (OpenAPITools#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (OpenAPITools#4353)
Remove deprecated API use of ObjectFactory.property() (OpenAPITools#2613) (OpenAPITools#4352)
[python][metadata]: Adding license and author fields (OpenAPITools#4318)
[Python] Avoid pep8 violation (OpenAPITools#4316)
[JS] Update package.json (OpenAPITools#4261)
Add slash-arun to Python technical committee (OpenAPITools#4354)
[typescript-fetch] Fix discriminator mapping name (OpenAPITools#4340)
fix security alerts reported by github (OpenAPITools#4344)
fix cpp-restbed-server json field serialization OpenAPITools#4320 (OpenAPITools#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (OpenAPITools#4341)
fix(typescript-angular): do not call .toISOString() on a string (OpenAPITools#4330) (OpenAPITools#4337)
update samples (OpenAPITools#4334)
Prepare 4.2.0 release (OpenAPITools#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (OpenAPITools#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (OpenAPITools#4056)
...
@jimschubert
jimschubert
commented
Nov 3, 2019

Copy link


Copy Markdown

Member
Thanks for the fix!
@kimsey0
kimsey0
commented
Nov 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks for the quick merge. I'm looking forward to the release in a few weeks.
@wing328
wing328
commented
Nov 15, 2019

Copy link


Copy Markdown

Member
@kimsey0 thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168
@kimsey0
kimsey0
commented
Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you! We have already started using the new version.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: C-SharpIssue: Bug

Projects


None yet


Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

[BUG] [csharp-netcore] Generating invalid null default values for enum parameters in API


4 participants

@kimsey0@wiruzman@jimschubert@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
csharp-netcore: Replace null literals with default - #4345
Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Nov 3, 2019
Merged
csharp-netcore: Replace null literals with default#4345
wing328 merged 2 commits into
OpenAPITools:masterfrom 
kimsey0:patch-1
Conversation
@kimsey0
@kimsey0kimsey0
commented
Nov 1, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#4343

Same fix as applied to the csharp generator in #3537
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@kimsey0
csharp-netcore: Replace null literals with default
a3eaf58
Same fix as applied to the csharp generator in #3537
@wiruzman
wiruzman
commented
Nov 1, 2019

Copy link


Copy Markdown

Contributor
Maybe you should make the PR to 4.2.x branch.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@wiruzman: As I understand the branch guidelines, changes to be included in the next patch release should be made to master.
@kimsey0
kimsey0
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
@mandrean, @jimschubert, @frankyjuang, any of you that can look at this?
@wing328wing328
added this to the 4.2.1 milestone
Nov 3, 2019
@wing328
wing328
merged commit f352fa6
into
OpenAPITools:masterNov 3, 2019
@kimsey0
kimsey0
deleted the

patch-1

branch
November 3, 2019 17:35
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' of github.com:OpenAPITools/openapi-generator
2a2c5c5
* 'master' of github.com:OpenAPITools/openapi-generator: (88 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
381fe91
* master: (142 commits)
smaller tests, better code format (#4355)
csharp-netcore: Replace null literals with default (#4345)
[core] consider polymorphism when computing unused schemas (#4335)
Fix issue 4326 forward throws for delegate to main method (#4327)
[kotlin][client] annotate api exceptions (#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353)
Remove deprecated API use of ObjectFactory.property() (#2613) (#4352)
[python][metadata]: Adding license and author fields (#4318)
[Python] Avoid pep8 violation (#4316)
[JS] Update package.json (#4261)
Add slash-arun to Python technical committee (#4354)
[typescript-fetch] Fix discriminator mapping name (#4340)
fix security alerts reported by github (#4344)
fix cpp-restbed-server json field serialization #4320 (#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341)
fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337)
update samples (#4334)
Prepare 4.2.0 release (#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056)
...
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Nov 3, 2019
@jimschubert
Merge branch 'master' into meta-codegen-improvements
2c41f8c
* master: (141 commits)
smaller tests, better code format (OpenAPITools#4355)
csharp-netcore: Replace null literals with default (OpenAPITools#4345)
[core] consider polymorphism when computing unused schemas (OpenAPITools#4335)
Fix issue 4326 forward throws for delegate to main method (OpenAPITools#4327)
[kotlin][client] annotate api exceptions (OpenAPITools#4339)
refactor java-vertx-web parameters and bugfix on non primitive parameter (OpenAPITools#4353)
Remove deprecated API use of ObjectFactory.property() (OpenAPITools#2613) (OpenAPITools#4352)
[python][metadata]: Adding license and author fields (OpenAPITools#4318)
[Python] Avoid pep8 violation (OpenAPITools#4316)
[JS] Update package.json (OpenAPITools#4261)
Add slash-arun to Python technical committee (OpenAPITools#4354)
[typescript-fetch] Fix discriminator mapping name (OpenAPITools#4340)
fix security alerts reported by github (OpenAPITools#4344)
fix cpp-restbed-server json field serialization OpenAPITools#4320 (OpenAPITools#4323)
typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (OpenAPITools#4341)
fix(typescript-angular): do not call .toISOString() on a string (OpenAPITools#4330) (OpenAPITools#4337)
update samples (OpenAPITools#4334)
Prepare 4.2.0 release (OpenAPITools#4333)
[FEATURE][Haskell] Haskell-Servant serves static files (OpenAPITools#4058)
[FEATURE][Haskell] Add Middleware support for the haskell servant generator (OpenAPITools#4056)
...
@jimschubert
jimschubert
commented
Nov 3, 2019

Copy link


Copy Markdown

Member
Thanks for the fix!
@kimsey0
kimsey0
commented
Nov 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks for the quick merge. I'm looking forward to the release in a few weeks.
@wing328
wing328
commented
Nov 15, 2019

Copy link


Copy Markdown

Member
@kimsey0 thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168
@kimsey0
kimsey0
commented
Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you! We have already started using the new version.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: C-SharpIssue: Bug

Projects


None yet


Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

[BUG] [csharp-netcore] Generating invalid null default values for enum parameters in API


4 participants

@kimsey0@wiruzman@jimschubert@wing328