[dart-dio] correctly handle Map<String, Object>, List<Object> using JsonObject

[amondnet]

google/built_value.dart#134

dart-dio generator does not handle Map<String, dynamic> properly. This PR fixes this issue using JsonObject.

• Map<String, Object> should be BuiltMap<String,JsonObject>
• List<Object> should be BuiltList<JsonObject>

Test:
properties:
objectMap:
type: objectadditionalProperties:
type: objectobjectList:
type: arrayitems:
type: object

@nullable@BuiltValueField(wireName:'objectMap')
BuiltMap<String, JsonObject> get objectMap;
@nullable@BuiltValueField(wireName:'objectList')
BuiltList<JsonObject> get objectList;

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @ircecho @swipesight @jaumard@nickmeinhold @athornz

[nickmeinhold]

Sounds great to me (though I would defer to @athornz if he has any issue).

I'm fairly new to the project but trying to be helpful where I can. One thing I'd love to do is encourage adding tests to PRs, especially where a fix addresses a specific issue and can be checked with some straightforward tests.

Any interest in adding a test or two? The dart generator has tests that are run in CI - currently it's just an old set of e2e tests with stubbed out network calls, and needs lots of work but it's a working example. We could copy the tests over to dart-dio and add running them to the CI script if you want.

And if no time or interest, no worries!

[wing328]

@amondnet thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800

[amondnet]

google/built_value.dart#134

dart-dio generator does not handle Map<String, dynamic> properly. This PR fixes this issue using JsonObject.

• Map<String, Object> should be BuiltMap<String,JsonObject>
• List<Object> should be BuiltList<JsonObject>

Test:
properties:
objectMap:
type: objectadditionalProperties:
type: objectobjectList:
type: arrayitems:
type: object

@nullable@BuiltValueField(wireName:'objectMap')
BuiltMap<String, JsonObject> get objectMap;
@nullable@BuiltValueField(wireName:'objectList')
BuiltList<JsonObject> get objectList;

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @ircecho @swipesight @jaumard@nickmeinhold @athornz

[nickmeinhold]

Sounds great to me (though I would defer to @athornz if he has any issue).

I'm fairly new to the project but trying to be helpful where I can. One thing I'd love to do is encourage adding tests to PRs, especially where a fix addresses a specific issue and can be checked with some straightforward tests.

Any interest in adding a test or two? The dart generator has tests that are run in CI - currently it's just an old set of e2e tests with stubbed out network calls, and needs lots of work but it's a working example. We could copy the tests over to dart-dio and add running them to the CI script if you want.

And if no time or interest, no worries!

[wing328]

@amondnet thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800

[amondnet]

google/built_value.dart#134

dart-dio generator does not handle Map<String, dynamic> properly. This PR fixes this issue using JsonObject.

• Map<String, Object> should be BuiltMap<String,JsonObject>
• List<Object> should be BuiltList<JsonObject>

Test:
properties:
objectMap:
type: objectadditionalProperties:
type: objectobjectList:
type: arrayitems:
type: object

@nullable@BuiltValueField(wireName:'objectMap')
BuiltMap<String, JsonObject> get objectMap;
@nullable@BuiltValueField(wireName:'objectList')
BuiltList<JsonObject> get objectList;

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @ircecho @swipesight @jaumard@nickmeinhold @athornz

[nickmeinhold]

Sounds great to me (though I would defer to @athornz if he has any issue).

I'm fairly new to the project but trying to be helpful where I can. One thing I'd love to do is encourage adding tests to PRs, especially where a fix addresses a specific issue and can be checked with some straightforward tests.

Any interest in adding a test or two? The dart generator has tests that are run in CI - currently it's just an old set of e2e tests with stubbed out network calls, and needs lots of work but it's a working example. We could copy the tests over to dart-dio and add running them to the CI script if you want.

And if no time or interest, no worries!

[wing328]

@amondnet thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800

[amondnet]

google/built_value.dart#134

dart-dio generator does not handle Map<String, dynamic> properly. This PR fixes this issue using JsonObject.

• Map<String, Object> should be BuiltMap<String,JsonObject>
• List<Object> should be BuiltList<JsonObject>

Test:
properties:
objectMap:
type: objectadditionalProperties:
type: objectobjectList:
type: arrayitems:
type: object

@nullable@BuiltValueField(wireName:'objectMap')
BuiltMap<String, JsonObject> get objectMap;
@nullable@BuiltValueField(wireName:'objectList')
BuiltList<JsonObject> get objectList;

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @ircecho @swipesight @jaumard@nickmeinhold @athornz

[nickmeinhold]

Sounds great to me (though I would defer to @athornz if he has any issue).

I'm fairly new to the project but trying to be helpful where I can. One thing I'd love to do is encourage adding tests to PRs, especially where a fix addresses a specific issue and can be checked with some straightforward tests.

Any interest in adding a test or two? The dart generator has tests that are run in CI - currently it's just an old set of e2e tests with stubbed out network calls, and needs lots of work but it's a working example. We could copy the tests over to dart-dio and add running them to the CI script if you want.

And if no time or interest, no worries!

[wing328]

@amondnet thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800

[amondnet]

google/built_value.dart#134

dart-dio generator does not handle Map<String, dynamic> properly. This PR fixes this issue using JsonObject.

• Map<String, Object> should be BuiltMap<String,JsonObject>
• List<Object> should be BuiltList<JsonObject>

Test:
properties:
objectMap:
type: objectadditionalProperties:
type: objectobjectList:
type: arrayitems:
type: object

@nullable@BuiltValueField(wireName:'objectMap')
BuiltMap<String, JsonObject> get objectMap;
@nullable@BuiltValueField(wireName:'objectList')
BuiltList<JsonObject> get objectList;

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @ircecho @swipesight @jaumard@nickmeinhold @athornz

[nickmeinhold]

Sounds great to me (though I would defer to @athornz if he has any issue).

I'm fairly new to the project but trying to be helpful where I can. One thing I'd love to do is encourage adding tests to PRs, especially where a fix addresses a specific issue and can be checked with some straightforward tests.

Any interest in adding a test or two? The dart generator has tests that are run in CI - currently it's just an old set of e2e tests with stubbed out network calls, and needs lots of work but it's a working example. We could copy the tests over to dart-dio and add running them to the CI script if you want.

And if no time or interest, no worries!

[wing328]

@amondnet thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800

[amondnet]

google/built_value.dart#134

dart-dio generator does not handle Map<String, dynamic> properly. This PR fixes this issue using JsonObject.

• Map<String, Object> should be BuiltMap<String,JsonObject>
• List<Object> should be BuiltList<JsonObject>

Test:
properties:
objectMap:
type: objectadditionalProperties:
type: objectobjectList:
type: arrayitems:
type: object

@nullable@BuiltValueField(wireName:'objectMap')
BuiltMap<String, JsonObject> get objectMap;
@nullable@BuiltValueField(wireName:'objectList')
BuiltList<JsonObject> get objectList;

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @ircecho @swipesight @jaumard@nickmeinhold @athornz

[nickmeinhold]

Sounds great to me (though I would defer to @athornz if he has any issue).

I'm fairly new to the project but trying to be helpful where I can. One thing I'd love to do is encourage adding tests to PRs, especially where a fix addresses a specific issue and can be checked with some straightforward tests.

Any interest in adding a test or two? The dart generator has tests that are run in CI - currently it's just an old set of e2e tests with stubbed out network calls, and needs lots of work but it's a working example. We could copy the tests over to dart-dio and add running them to the CI script if you want.

And if no time or interest, no worries!

[wing328]

@amondnet thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800

[amondnet]

google/built_value.dart#134

dart-dio generator does not handle Map<String, dynamic> properly. This PR fixes this issue using JsonObject.

• Map<String, Object> should be BuiltMap<String,JsonObject>
• List<Object> should be BuiltList<JsonObject>

Test:
properties:
objectMap:
type: objectadditionalProperties:
type: objectobjectList:
type: arrayitems:
type: object

@nullable@BuiltValueField(wireName:'objectMap')
BuiltMap<String, JsonObject> get objectMap;
@nullable@BuiltValueField(wireName:'objectList')
BuiltList<JsonObject> get objectList;

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @ircecho @swipesight @jaumard@nickmeinhold @athornz

[nickmeinhold]

Sounds great to me (though I would defer to @athornz if he has any issue).

I'm fairly new to the project but trying to be helpful where I can. One thing I'd love to do is encourage adding tests to PRs, especially where a fix addresses a specific issue and can be checked with some straightforward tests.

Any interest in adding a test or two? The dart generator has tests that are run in CI - currently it's just an old set of e2e tests with stubbed out network calls, and needs lots of work but it's a working example. We could copy the tests over to dart-dio and add running them to the CI script if you want.

And if no time or interest, no worries!

[wing328]

@amondnet thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800

[amondnet]

google/built_value.dart#134

dart-dio generator does not handle Map<String, dynamic> properly. This PR fixes this issue using JsonObject.

• Map<String, Object> should be BuiltMap<String,JsonObject>
• List<Object> should be BuiltList<JsonObject>

Test:
properties:
objectMap:
type: objectadditionalProperties:
type: objectobjectList:
type: arrayitems:
type: object

@nullable@BuiltValueField(wireName:'objectMap')
BuiltMap<String, JsonObject> get objectMap;
@nullable@BuiltValueField(wireName:'objectList')
BuiltList<JsonObject> get objectList;

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @ircecho @swipesight @jaumard@nickmeinhold @athornz

[nickmeinhold]

Sounds great to me (though I would defer to @athornz if he has any issue).

I'm fairly new to the project but trying to be helpful where I can. One thing I'd love to do is encourage adding tests to PRs, especially where a fix addresses a specific issue and can be checked with some straightforward tests.

Any interest in adding a test or two? The dart generator has tests that are run in CI - currently it's just an old set of e2e tests with stubbed out network calls, and needs lots of work but it's a working example. We could copy the tests over to dart-dio and add running them to the CI script if you want.

And if no time or interest, no worries!

[wing328]

@amondnet thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800