[REQ][typescript-angular]: support for object as query parameters - #4407

Merged
macjohnny merged 10 commits into
OpenAPITools:masterfrom
aanno2:feature/aanno2-tsng-fix-query-params-master
Jan 27, 2020
Merged

[REQ][typescript-angular]: support for object as query parameters#4407
macjohnny merged 10 commits into
OpenAPITools:masterfrom
aanno2:feature/aanno2-tsng-fix-query-params-master

Conversation

@aanno2

@aanno2aanno2 commented Nov 7, 2019•
edited by macjohnny
Loading

Copy link
Copy Markdown
Contributor

fixes#4404

@macjohnny: Thank you for review

I've updated the PR and hope it will be more in-line with what is expected.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@nicokoenig@topce@akehir

issue by @aanno2

@auto-labeler

auto-labelerBot commented Nov 7, 2019

Copy link
Copy Markdown

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@macjohnny

macjohnny commented Nov 7, 2019

Copy link
Copy Markdown
Member

Thanks for your PR
Please follow the steps described in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md

macjohnny
macjohnny reviewed Nov 7, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/encoder.mustache Outdated
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache Outdated
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache Outdated
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache Outdated
@aanno2

aanno2 commented Nov 7, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

BTW, travis dies with 'A tuple type element list cannot be empty' but my local build with maven has not reported a problem. I'm not sure how to reproduce the error locally.

@aanno2
aanno2force-pushed the feature/aanno2-tsng-fix-query-params-master branch 2 times, most recently from 9df82cf to da8c203CompareNovember 13, 2019 15:17
@aanno2

aanno2 commented Nov 13, 2019

Copy link
Copy Markdown
ContributorAuthor

I have updated and merge-squashed my PR with an appropriate author email. No 'real' changes.

macjohnny
macjohnny reviewed Nov 13, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache Outdated
@aanno2
aanno2force-pushed the feature/aanno2-tsng-fix-query-params-master branch from da8c203 to 4a96e2dCompareNovember 13, 2019 15:46
@macjohnnymacjohnny added this to the 4.2.1 milestone Nov 14, 2019
@aanno2

aanno2 commented Nov 14, 2019

Copy link
Copy Markdown
ContributorAuthor

@macjohnny: Thank you for accepting my contribution.

macjohnny
macjohnny reviewed Nov 14, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache Outdated
macjohnny
macjohnny approved these changes Nov 14, 2019
View reviewed changes

@macjohnnymacjohnny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache Outdated
@macjohnny

macjohnny commented Nov 14, 2019•
edited
Loading

Copy link
Copy Markdown
Member

please merge the current master into your branch and update the samples again

@wing328wing328 modified the milestones: 4.2.1, 4.2.2Nov 15, 2019
@aanno2

aanno2 commented Nov 15, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Introduced a typo before I run out of time yesterday. All fixed now.

macjohnny
macjohnny reviewed Nov 15, 2019
View reviewed changes
Comment threadsamples/client/petstore/typescript-angular-v8-provided-in-root/builds/with-npm/package.json Outdated

@macjohnnymacjohnnyNov 15, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reverted

@aanno2aanno2Nov 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Not done on purpose. Sorry!

@wing328wing328 modified the milestones: 4.2.2, 4.2.3Dec 2, 2019
@macjohnny

macjohnny commented Dec 4, 2019

Copy link
Copy Markdown
Member

@aanno2 can you please merge the current master and update the samples?

@dougal83

dougal83 commented Dec 28, 2019

Copy link
Copy Markdown
Contributor

@aanno2 Thanks for this pull request. Just run into the issue myself. All set for next release?

@greghopkins

greghopkins commented Jan 14, 2020

Copy link
Copy Markdown

Would love for this to get merged soon... 🙏 😉

@wing328

wing328 commented Jan 14, 2020

Copy link
Copy Markdown
Member

@aanno2 please resolve the merge conflicts and merge the latest master into this branch. Let me know if you need help on this.

@aanno2
aanno2force-pushed the feature/aanno2-tsng-fix-query-params-master branch from 7102035 to e461319CompareJanuary 22, 2020 14:35
@aanno2

aanno2 commented Jan 22, 2020

Copy link
Copy Markdown
ContributorAuthor

@wing328: As requested, I have rebased the PR onto the current master branch.

@macjohnny

macjohnny commented Jan 22, 2020

Copy link
Copy Markdown
Member

@aanno2 can you please fix the build error:

ERROR in builds/default/api/pet.service.ts(78,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/store.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/user.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.

see https://travis-ci.org/OpenAPITools/openapi-generator/builds/640473532?utm_source=github_status&utm_medium=notification

macjohnny
macjohnny reviewed Jan 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache Outdated
private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
if (typeof value === "object") {
if (Array.isArray(value)) {
(value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));

@macjohnnymacjohnnyJan 22, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));

@aanno2aanno2Jan 22, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping out. I just applied your suggestion.

@macjohnny

macjohnny commented Jan 22, 2020

Copy link
Copy Markdown
Member

please re-generate the samples

@macjohnny
macjohnny merged commit d111e3a into OpenAPITools:masterJan 27, 2020
@daniel-frakdaniel-frak mentioned this pull request Jan 31, 2020
Closed
5 tasks
@kenisteward

kenisteward commented Mar 6, 2020

Copy link
Copy Markdown
Contributor

@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha

@dougal83

dougal83 commented Mar 7, 2020

Copy link
Copy Markdown
Contributor

@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha

Yes, it is in the latest version.

@spencerfontein

spencerfontein commented Mar 19, 2020

Copy link
Copy Markdown

looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?

@dougal83

dougal83 commented Mar 19, 2020

Copy link
Copy Markdown
Contributor

looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?

Are you sure? I thought that the milestone on the right was an at-a-glance indicator and it says 4.2.3. Also, if I recall correctly then I've used this feature from the current npm version. Where are you seeing 4.3.0?

@spencerfontein

spencerfontein commented Mar 19, 2020

Copy link
Copy Markdown

I clicked on this link #5174 that daniel-frank posted a few comments back and it mentioned 4.3.

I am currently using 4.2.3

I have the Pagination object in my Java code as a query param and this is the TS I get

import { Sort } from'./sort';
exportinterfacePageable {
offset?: number;
sort?: Sort;
pageSize?: number;
pageNumber?: number;
paged?: boolean;
unpaged?: boolean;
}

export interface Sort {
sorted?: boolean;
unsorted?: boolean;
empty?: boolean;
}

Maybe I'm missing something

This is the command I'm running

openapi-generator generate -g typescript-angular -i ../../backend/escalation-service/target/openapi.json -o swagger/escalation-api --additional-properties npmName=@mycustom/escalation-api,ngVersion=8.1.2,npmVersion=1.0.0

Thanks for the help

@dougal83

dougal83 commented Mar 19, 2020

Copy link
Copy Markdown
Contributor

I think it would be best to open a new issue to query this and include your 'openapi.json'. Hopefully, someone can point out the issue.

This was referenced Mar 30, 2020
Closed
Closed
@petitoutpetitout mentioned this pull request May 22, 2020
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macjohnnymacjohnnymacjohnny approved these changes

Assignees

No one assigned

Labels

Client: TypeScript

Projects

None yet

Milestone

4.2.3

Development

Successfully merging this pull request may close these issues.

[REQ] [typescript-angular]: support for object as query parameters

8 participants

@aanno2@macjohnny@dougal83@greghopkins@wing328@kenisteward@spencerfontein@aanno
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[REQ][typescript-angular]: support for object as query parameters - #4407
Merged
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Jan 27, 2020
Merged
[REQ][typescript-angular]: support for object as query parameters#4407
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Conversation
@aanno2
@aanno2aanno2
commented
Nov 7, 2019•

edited by macjohnny

Loading

Copy link


Copy Markdown

Contributor
fixes#4404
@macjohnny: Thank you for review
I've updated the PR and hope it will be more in-line with what is expected.
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@nicokoenig@topce@akehir
issue by @aanno2
@auto-labeler
auto-labelerBot
commented
Nov 7, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@macjohnny
macjohnny
commented
Nov 7, 2019

Copy link


Copy Markdown

Member
Thanks for your PR

Please follow the steps described in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md
macjohnny
macjohnny
reviewed
Nov 7, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/encoder.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2
commented
Nov 7, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
BTW, travis dies with 'A tuple type element list cannot be empty' but my local build with maven has not reported a problem. I'm not sure how to reproduce the error locally.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
2 times, most recently
from
9df82cf to
da8c203CompareNovember 13, 2019 15:17
@aanno2
aanno2
commented
Nov 13, 2019

Copy link


Copy Markdown

ContributorAuthor
I have updated and merge-squashed my PR with an appropriate author email. No 'real' changes.
macjohnny
macjohnny
reviewed
Nov 13, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
da8c203 to
4a96e2dCompareNovember 13, 2019 15:46
@macjohnnymacjohnny
added this to the 4.2.1 milestone
Nov 14, 2019
@aanno2
aanno2
commented
Nov 14, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny: Thank you for accepting my contribution.
macjohnny
macjohnny
reviewed
Nov 14, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

macjohnny
macjohnny
approved these changes
Nov 14, 2019
View reviewed changes
@macjohnnymacjohnny
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@macjohnny
macjohnny
commented
Nov 14, 2019•

edited

Loading

Copy link


Copy Markdown

Member
please merge the current master into your branch and update the samples again
@wing328wing328
modified the milestones:
4.2.1, 4.2.2Nov 15, 2019
@aanno2
aanno2
commented
Nov 15, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Introduced a typo before I run out of time yesterday. All fixed now.
macjohnny
macjohnny
reviewed
Nov 15, 2019
View reviewed changes
Comment threadsamples/client/petstore/typescript-angular-v8-provided-in-root/builds/with-npm/package.json
Outdated

@macjohnnymacjohnnyNov 15, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reverted
@aanno2aanno2Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Not done on purpose. Sorry!
@wing328wing328
modified the milestones:
4.2.2, 4.2.3Dec 2, 2019
@macjohnny
macjohnny
commented
Dec 4, 2019

Copy link


Copy Markdown

Member
@aanno2 can you please merge the current master and update the samples?
@dougal83
dougal83
commented
Dec 28, 2019

Copy link


Copy Markdown

Contributor
@aanno2 Thanks for this pull request. Just run into the issue myself. All set for next release?
@greghopkins
greghopkins
commented
Jan 14, 2020

Copy link


Copy Markdown

Would love for this to get merged soon... 🙏 😉
@wing328
wing328
commented
Jan 14, 2020

Copy link


Copy Markdown

Member
@aanno2 please resolve the merge conflicts and merge the latest master into this branch. Let me know if you need help on this.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
7102035 to
e461319CompareJanuary 22, 2020 14:35
@aanno2
aanno2
commented
Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
@wing328: As requested, I have rebased the PR onto the current master branch.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
@aanno2 can you please fix the build error:
ERROR in builds/default/api/pet.service.ts(78,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/store.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/user.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.

see https://travis-ci.org/OpenAPITools/openapi-generator/builds/640473532?utm_source=github_status&utm_medium=notification
macjohnny
macjohnny
reviewed
Jan 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

 private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
 if (typeof value === "object") {
 if (Array.isArray(value)) {
 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@macjohnnymacjohnnyJan 22, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
 (value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@aanno2aanno2Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping out. I just applied your suggestion.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
please re-generate the samples
@macjohnny
macjohnny
merged commit d111e3a
into
OpenAPITools:masterJan 27, 2020
@daniel-frakdaniel-frak
mentioned this pull request
Jan 31, 2020

Closed

5 tasks
@kenisteward
kenisteward
commented
Mar 6, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
@dougal83
dougal83
commented
Mar 7, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
Yes, it is in the latest version.
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
Are you sure? I thought that the milestone on the right was an at-a-glance indicator and it says 4.2.3. Also, if I recall correctly then I've used this feature from the current npm version. Where are you seeing 4.3.0?
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

I clicked on this link #5174 that daniel-frank posted a few comments back and it mentioned 4.3.
I am currently using 4.2.3
I have the Pagination object in my Java code as a query param and this is the TS I get
import { Sort } from'./sort';
exportinterfacePageable {
offset?: number;
sort?: Sort;
pageSize?: number;
pageNumber?: number;
paged?: boolean;
unpaged?: boolean;
}

export interface Sort {
sorted?: boolean;
unsorted?: boolean;
empty?: boolean;
}

Maybe I'm missing something
This is the command I'm running
openapi-generator generate -g typescript-angular -i ../../backend/escalation-service/target/openapi.json -o swagger/escalation-api --additional-properties npmName=@mycustom/escalation-api,ngVersion=8.1.2,npmVersion=1.0.0
Thanks for the help
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
I think it would be best to open a new issue to query this and include your 'openapi.json'. Hopefully, someone can point out the issue.

This was referenced Mar 30, 2020

Closed


Closed

@petitoutpetitout
mentioned this pull request
May 22, 2020

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macjohnnymacjohnnymacjohnny approved these changes

Assignees


No one assigned


Labels

Client: TypeScript

Projects


None yet


Milestone

4.2.3

Development

Successfully merging this pull request may close these issues.

[REQ] [typescript-angular]: support for object as query parameters


8 participants

@aanno2@macjohnny@dougal83@greghopkins@wing328@kenisteward@spencerfontein@aanno

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[REQ][typescript-angular]: support for object as query parameters - #4407
Merged
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Jan 27, 2020
Merged
[REQ][typescript-angular]: support for object as query parameters#4407
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Conversation
@aanno2
@aanno2aanno2
commented
Nov 7, 2019•

edited by macjohnny

Loading

Copy link


Copy Markdown

Contributor
fixes#4404
@macjohnny: Thank you for review
I've updated the PR and hope it will be more in-line with what is expected.
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@nicokoenig@topce@akehir
issue by @aanno2
@auto-labeler
auto-labelerBot
commented
Nov 7, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@macjohnny
macjohnny
commented
Nov 7, 2019

Copy link


Copy Markdown

Member
Thanks for your PR

Please follow the steps described in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md
macjohnny
macjohnny
reviewed
Nov 7, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/encoder.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2
commented
Nov 7, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
BTW, travis dies with 'A tuple type element list cannot be empty' but my local build with maven has not reported a problem. I'm not sure how to reproduce the error locally.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
2 times, most recently
from
9df82cf to
da8c203CompareNovember 13, 2019 15:17
@aanno2
aanno2
commented
Nov 13, 2019

Copy link


Copy Markdown

ContributorAuthor
I have updated and merge-squashed my PR with an appropriate author email. No 'real' changes.
macjohnny
macjohnny
reviewed
Nov 13, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
da8c203 to
4a96e2dCompareNovember 13, 2019 15:46
@macjohnnymacjohnny
added this to the 4.2.1 milestone
Nov 14, 2019
@aanno2
aanno2
commented
Nov 14, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny: Thank you for accepting my contribution.
macjohnny
macjohnny
reviewed
Nov 14, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

macjohnny
macjohnny
approved these changes
Nov 14, 2019
View reviewed changes
@macjohnnymacjohnny
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@macjohnny
macjohnny
commented
Nov 14, 2019•

edited

Loading

Copy link


Copy Markdown

Member
please merge the current master into your branch and update the samples again
@wing328wing328
modified the milestones:
4.2.1, 4.2.2Nov 15, 2019
@aanno2
aanno2
commented
Nov 15, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Introduced a typo before I run out of time yesterday. All fixed now.
macjohnny
macjohnny
reviewed
Nov 15, 2019
View reviewed changes
Comment threadsamples/client/petstore/typescript-angular-v8-provided-in-root/builds/with-npm/package.json
Outdated

@macjohnnymacjohnnyNov 15, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reverted
@aanno2aanno2Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Not done on purpose. Sorry!
@wing328wing328
modified the milestones:
4.2.2, 4.2.3Dec 2, 2019
@macjohnny
macjohnny
commented
Dec 4, 2019

Copy link


Copy Markdown

Member
@aanno2 can you please merge the current master and update the samples?
@dougal83
dougal83
commented
Dec 28, 2019

Copy link


Copy Markdown

Contributor
@aanno2 Thanks for this pull request. Just run into the issue myself. All set for next release?
@greghopkins
greghopkins
commented
Jan 14, 2020

Copy link


Copy Markdown

Would love for this to get merged soon... 🙏 😉
@wing328
wing328
commented
Jan 14, 2020

Copy link


Copy Markdown

Member
@aanno2 please resolve the merge conflicts and merge the latest master into this branch. Let me know if you need help on this.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
7102035 to
e461319CompareJanuary 22, 2020 14:35
@aanno2
aanno2
commented
Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
@wing328: As requested, I have rebased the PR onto the current master branch.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
@aanno2 can you please fix the build error:
ERROR in builds/default/api/pet.service.ts(78,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/store.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/user.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.

see https://travis-ci.org/OpenAPITools/openapi-generator/builds/640473532?utm_source=github_status&utm_medium=notification
macjohnny
macjohnny
reviewed
Jan 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

 private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
 if (typeof value === "object") {
 if (Array.isArray(value)) {
 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@macjohnnymacjohnnyJan 22, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
 (value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@aanno2aanno2Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping out. I just applied your suggestion.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
please re-generate the samples
@macjohnny
macjohnny
merged commit d111e3a
into
OpenAPITools:masterJan 27, 2020
@daniel-frakdaniel-frak
mentioned this pull request
Jan 31, 2020

Closed

5 tasks
@kenisteward
kenisteward
commented
Mar 6, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
@dougal83
dougal83
commented
Mar 7, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
Yes, it is in the latest version.
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
Are you sure? I thought that the milestone on the right was an at-a-glance indicator and it says 4.2.3. Also, if I recall correctly then I've used this feature from the current npm version. Where are you seeing 4.3.0?
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

I clicked on this link #5174 that daniel-frank posted a few comments back and it mentioned 4.3.
I am currently using 4.2.3
I have the Pagination object in my Java code as a query param and this is the TS I get
import { Sort } from'./sort';
exportinterfacePageable {
offset?: number;
sort?: Sort;
pageSize?: number;
pageNumber?: number;
paged?: boolean;
unpaged?: boolean;
}

export interface Sort {
sorted?: boolean;
unsorted?: boolean;
empty?: boolean;
}

Maybe I'm missing something
This is the command I'm running
openapi-generator generate -g typescript-angular -i ../../backend/escalation-service/target/openapi.json -o swagger/escalation-api --additional-properties npmName=@mycustom/escalation-api,ngVersion=8.1.2,npmVersion=1.0.0
Thanks for the help
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
I think it would be best to open a new issue to query this and include your 'openapi.json'. Hopefully, someone can point out the issue.

This was referenced Mar 30, 2020

Closed


Closed

@petitoutpetitout
mentioned this pull request
May 22, 2020

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macjohnnymacjohnnymacjohnny approved these changes

Assignees


No one assigned


Labels

Client: TypeScript

Projects


None yet


Milestone

4.2.3

Development

Successfully merging this pull request may close these issues.

[REQ] [typescript-angular]: support for object as query parameters


8 participants

@aanno2@macjohnny@dougal83@greghopkins@wing328@kenisteward@spencerfontein@aanno

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[REQ][typescript-angular]: support for object as query parameters - #4407
Merged
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Jan 27, 2020
Merged
[REQ][typescript-angular]: support for object as query parameters#4407
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Conversation
@aanno2
@aanno2aanno2
commented
Nov 7, 2019•

edited by macjohnny

Loading

Copy link


Copy Markdown

Contributor
fixes#4404
@macjohnny: Thank you for review
I've updated the PR and hope it will be more in-line with what is expected.
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@nicokoenig@topce@akehir
issue by @aanno2
@auto-labeler
auto-labelerBot
commented
Nov 7, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@macjohnny
macjohnny
commented
Nov 7, 2019

Copy link


Copy Markdown

Member
Thanks for your PR

Please follow the steps described in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md
macjohnny
macjohnny
reviewed
Nov 7, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/encoder.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2
commented
Nov 7, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
BTW, travis dies with 'A tuple type element list cannot be empty' but my local build with maven has not reported a problem. I'm not sure how to reproduce the error locally.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
2 times, most recently
from
9df82cf to
da8c203CompareNovember 13, 2019 15:17
@aanno2
aanno2
commented
Nov 13, 2019

Copy link


Copy Markdown

ContributorAuthor
I have updated and merge-squashed my PR with an appropriate author email. No 'real' changes.
macjohnny
macjohnny
reviewed
Nov 13, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
da8c203 to
4a96e2dCompareNovember 13, 2019 15:46
@macjohnnymacjohnny
added this to the 4.2.1 milestone
Nov 14, 2019
@aanno2
aanno2
commented
Nov 14, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny: Thank you for accepting my contribution.
macjohnny
macjohnny
reviewed
Nov 14, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

macjohnny
macjohnny
approved these changes
Nov 14, 2019
View reviewed changes
@macjohnnymacjohnny
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@macjohnny
macjohnny
commented
Nov 14, 2019•

edited

Loading

Copy link


Copy Markdown

Member
please merge the current master into your branch and update the samples again
@wing328wing328
modified the milestones:
4.2.1, 4.2.2Nov 15, 2019
@aanno2
aanno2
commented
Nov 15, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Introduced a typo before I run out of time yesterday. All fixed now.
macjohnny
macjohnny
reviewed
Nov 15, 2019
View reviewed changes
Comment threadsamples/client/petstore/typescript-angular-v8-provided-in-root/builds/with-npm/package.json
Outdated

@macjohnnymacjohnnyNov 15, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reverted
@aanno2aanno2Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Not done on purpose. Sorry!
@wing328wing328
modified the milestones:
4.2.2, 4.2.3Dec 2, 2019
@macjohnny
macjohnny
commented
Dec 4, 2019

Copy link


Copy Markdown

Member
@aanno2 can you please merge the current master and update the samples?
@dougal83
dougal83
commented
Dec 28, 2019

Copy link


Copy Markdown

Contributor
@aanno2 Thanks for this pull request. Just run into the issue myself. All set for next release?
@greghopkins
greghopkins
commented
Jan 14, 2020

Copy link


Copy Markdown

Would love for this to get merged soon... 🙏 😉
@wing328
wing328
commented
Jan 14, 2020

Copy link


Copy Markdown

Member
@aanno2 please resolve the merge conflicts and merge the latest master into this branch. Let me know if you need help on this.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
7102035 to
e461319CompareJanuary 22, 2020 14:35
@aanno2
aanno2
commented
Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
@wing328: As requested, I have rebased the PR onto the current master branch.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
@aanno2 can you please fix the build error:
ERROR in builds/default/api/pet.service.ts(78,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/store.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/user.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.

see https://travis-ci.org/OpenAPITools/openapi-generator/builds/640473532?utm_source=github_status&utm_medium=notification
macjohnny
macjohnny
reviewed
Jan 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

 private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
 if (typeof value === "object") {
 if (Array.isArray(value)) {
 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@macjohnnymacjohnnyJan 22, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
 (value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@aanno2aanno2Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping out. I just applied your suggestion.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
please re-generate the samples
@macjohnny
macjohnny
merged commit d111e3a
into
OpenAPITools:masterJan 27, 2020
@daniel-frakdaniel-frak
mentioned this pull request
Jan 31, 2020

Closed

5 tasks
@kenisteward
kenisteward
commented
Mar 6, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
@dougal83
dougal83
commented
Mar 7, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
Yes, it is in the latest version.
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
Are you sure? I thought that the milestone on the right was an at-a-glance indicator and it says 4.2.3. Also, if I recall correctly then I've used this feature from the current npm version. Where are you seeing 4.3.0?
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

I clicked on this link #5174 that daniel-frank posted a few comments back and it mentioned 4.3.
I am currently using 4.2.3
I have the Pagination object in my Java code as a query param and this is the TS I get
import { Sort } from'./sort';
exportinterfacePageable {
offset?: number;
sort?: Sort;
pageSize?: number;
pageNumber?: number;
paged?: boolean;
unpaged?: boolean;
}

export interface Sort {
sorted?: boolean;
unsorted?: boolean;
empty?: boolean;
}

Maybe I'm missing something
This is the command I'm running
openapi-generator generate -g typescript-angular -i ../../backend/escalation-service/target/openapi.json -o swagger/escalation-api --additional-properties npmName=@mycustom/escalation-api,ngVersion=8.1.2,npmVersion=1.0.0
Thanks for the help
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
I think it would be best to open a new issue to query this and include your 'openapi.json'. Hopefully, someone can point out the issue.

This was referenced Mar 30, 2020

Closed


Closed

@petitoutpetitout
mentioned this pull request
May 22, 2020

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macjohnnymacjohnnymacjohnny approved these changes

Assignees


No one assigned


Labels

Client: TypeScript

Projects


None yet


Milestone

4.2.3

Development

Successfully merging this pull request may close these issues.

[REQ] [typescript-angular]: support for object as query parameters


8 participants

@aanno2@macjohnny@dougal83@greghopkins@wing328@kenisteward@spencerfontein@aanno

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[REQ][typescript-angular]: support for object as query parameters - #4407
Merged
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Jan 27, 2020
Merged
[REQ][typescript-angular]: support for object as query parameters#4407
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Conversation
@aanno2
@aanno2aanno2
commented
Nov 7, 2019•

edited by macjohnny

Loading

Copy link


Copy Markdown

Contributor
fixes#4404
@macjohnny: Thank you for review
I've updated the PR and hope it will be more in-line with what is expected.
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@nicokoenig@topce@akehir
issue by @aanno2
@auto-labeler
auto-labelerBot
commented
Nov 7, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@macjohnny
macjohnny
commented
Nov 7, 2019

Copy link


Copy Markdown

Member
Thanks for your PR

Please follow the steps described in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md
macjohnny
macjohnny
reviewed
Nov 7, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/encoder.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2
commented
Nov 7, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
BTW, travis dies with 'A tuple type element list cannot be empty' but my local build with maven has not reported a problem. I'm not sure how to reproduce the error locally.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
2 times, most recently
from
9df82cf to
da8c203CompareNovember 13, 2019 15:17
@aanno2
aanno2
commented
Nov 13, 2019

Copy link


Copy Markdown

ContributorAuthor
I have updated and merge-squashed my PR with an appropriate author email. No 'real' changes.
macjohnny
macjohnny
reviewed
Nov 13, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
da8c203 to
4a96e2dCompareNovember 13, 2019 15:46
@macjohnnymacjohnny
added this to the 4.2.1 milestone
Nov 14, 2019
@aanno2
aanno2
commented
Nov 14, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny: Thank you for accepting my contribution.
macjohnny
macjohnny
reviewed
Nov 14, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

macjohnny
macjohnny
approved these changes
Nov 14, 2019
View reviewed changes
@macjohnnymacjohnny
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@macjohnny
macjohnny
commented
Nov 14, 2019•

edited

Loading

Copy link


Copy Markdown

Member
please merge the current master into your branch and update the samples again
@wing328wing328
modified the milestones:
4.2.1, 4.2.2Nov 15, 2019
@aanno2
aanno2
commented
Nov 15, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Introduced a typo before I run out of time yesterday. All fixed now.
macjohnny
macjohnny
reviewed
Nov 15, 2019
View reviewed changes
Comment threadsamples/client/petstore/typescript-angular-v8-provided-in-root/builds/with-npm/package.json
Outdated

@macjohnnymacjohnnyNov 15, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reverted
@aanno2aanno2Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Not done on purpose. Sorry!
@wing328wing328
modified the milestones:
4.2.2, 4.2.3Dec 2, 2019
@macjohnny
macjohnny
commented
Dec 4, 2019

Copy link


Copy Markdown

Member
@aanno2 can you please merge the current master and update the samples?
@dougal83
dougal83
commented
Dec 28, 2019

Copy link


Copy Markdown

Contributor
@aanno2 Thanks for this pull request. Just run into the issue myself. All set for next release?
@greghopkins
greghopkins
commented
Jan 14, 2020

Copy link


Copy Markdown

Would love for this to get merged soon... 🙏 😉
@wing328
wing328
commented
Jan 14, 2020

Copy link


Copy Markdown

Member
@aanno2 please resolve the merge conflicts and merge the latest master into this branch. Let me know if you need help on this.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
7102035 to
e461319CompareJanuary 22, 2020 14:35
@aanno2
aanno2
commented
Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
@wing328: As requested, I have rebased the PR onto the current master branch.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
@aanno2 can you please fix the build error:
ERROR in builds/default/api/pet.service.ts(78,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/store.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/user.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.

see https://travis-ci.org/OpenAPITools/openapi-generator/builds/640473532?utm_source=github_status&utm_medium=notification
macjohnny
macjohnny
reviewed
Jan 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

 private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
 if (typeof value === "object") {
 if (Array.isArray(value)) {
 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@macjohnnymacjohnnyJan 22, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
 (value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@aanno2aanno2Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping out. I just applied your suggestion.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
please re-generate the samples
@macjohnny
macjohnny
merged commit d111e3a
into
OpenAPITools:masterJan 27, 2020
@daniel-frakdaniel-frak
mentioned this pull request
Jan 31, 2020

Closed

5 tasks
@kenisteward
kenisteward
commented
Mar 6, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
@dougal83
dougal83
commented
Mar 7, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
Yes, it is in the latest version.
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
Are you sure? I thought that the milestone on the right was an at-a-glance indicator and it says 4.2.3. Also, if I recall correctly then I've used this feature from the current npm version. Where are you seeing 4.3.0?
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

I clicked on this link #5174 that daniel-frank posted a few comments back and it mentioned 4.3.
I am currently using 4.2.3
I have the Pagination object in my Java code as a query param and this is the TS I get
import { Sort } from'./sort';
exportinterfacePageable {
offset?: number;
sort?: Sort;
pageSize?: number;
pageNumber?: number;
paged?: boolean;
unpaged?: boolean;
}

export interface Sort {
sorted?: boolean;
unsorted?: boolean;
empty?: boolean;
}

Maybe I'm missing something
This is the command I'm running
openapi-generator generate -g typescript-angular -i ../../backend/escalation-service/target/openapi.json -o swagger/escalation-api --additional-properties npmName=@mycustom/escalation-api,ngVersion=8.1.2,npmVersion=1.0.0
Thanks for the help
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
I think it would be best to open a new issue to query this and include your 'openapi.json'. Hopefully, someone can point out the issue.

This was referenced Mar 30, 2020

Closed


Closed

@petitoutpetitout
mentioned this pull request
May 22, 2020

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macjohnnymacjohnnymacjohnny approved these changes

Assignees


No one assigned


Labels

Client: TypeScript

Projects


None yet


Milestone

4.2.3

Development

Successfully merging this pull request may close these issues.

[REQ] [typescript-angular]: support for object as query parameters


8 participants

@aanno2@macjohnny@dougal83@greghopkins@wing328@kenisteward@spencerfontein@aanno

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[REQ][typescript-angular]: support for object as query parameters - #4407
Merged
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Jan 27, 2020
Merged
[REQ][typescript-angular]: support for object as query parameters#4407
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Conversation
@aanno2
@aanno2aanno2
commented
Nov 7, 2019•

edited by macjohnny

Loading

Copy link


Copy Markdown

Contributor
fixes#4404
@macjohnny: Thank you for review
I've updated the PR and hope it will be more in-line with what is expected.
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@nicokoenig@topce@akehir
issue by @aanno2
@auto-labeler
auto-labelerBot
commented
Nov 7, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@macjohnny
macjohnny
commented
Nov 7, 2019

Copy link


Copy Markdown

Member
Thanks for your PR

Please follow the steps described in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md
macjohnny
macjohnny
reviewed
Nov 7, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/encoder.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2
commented
Nov 7, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
BTW, travis dies with 'A tuple type element list cannot be empty' but my local build with maven has not reported a problem. I'm not sure how to reproduce the error locally.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
2 times, most recently
from
9df82cf to
da8c203CompareNovember 13, 2019 15:17
@aanno2
aanno2
commented
Nov 13, 2019

Copy link


Copy Markdown

ContributorAuthor
I have updated and merge-squashed my PR with an appropriate author email. No 'real' changes.
macjohnny
macjohnny
reviewed
Nov 13, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
da8c203 to
4a96e2dCompareNovember 13, 2019 15:46
@macjohnnymacjohnny
added this to the 4.2.1 milestone
Nov 14, 2019
@aanno2
aanno2
commented
Nov 14, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny: Thank you for accepting my contribution.
macjohnny
macjohnny
reviewed
Nov 14, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

macjohnny
macjohnny
approved these changes
Nov 14, 2019
View reviewed changes
@macjohnnymacjohnny
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@macjohnny
macjohnny
commented
Nov 14, 2019•

edited

Loading

Copy link


Copy Markdown

Member
please merge the current master into your branch and update the samples again
@wing328wing328
modified the milestones:
4.2.1, 4.2.2Nov 15, 2019
@aanno2
aanno2
commented
Nov 15, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Introduced a typo before I run out of time yesterday. All fixed now.
macjohnny
macjohnny
reviewed
Nov 15, 2019
View reviewed changes
Comment threadsamples/client/petstore/typescript-angular-v8-provided-in-root/builds/with-npm/package.json
Outdated

@macjohnnymacjohnnyNov 15, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reverted
@aanno2aanno2Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Not done on purpose. Sorry!
@wing328wing328
modified the milestones:
4.2.2, 4.2.3Dec 2, 2019
@macjohnny
macjohnny
commented
Dec 4, 2019

Copy link


Copy Markdown

Member
@aanno2 can you please merge the current master and update the samples?
@dougal83
dougal83
commented
Dec 28, 2019

Copy link


Copy Markdown

Contributor
@aanno2 Thanks for this pull request. Just run into the issue myself. All set for next release?
@greghopkins
greghopkins
commented
Jan 14, 2020

Copy link


Copy Markdown

Would love for this to get merged soon... 🙏 😉
@wing328
wing328
commented
Jan 14, 2020

Copy link


Copy Markdown

Member
@aanno2 please resolve the merge conflicts and merge the latest master into this branch. Let me know if you need help on this.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
7102035 to
e461319CompareJanuary 22, 2020 14:35
@aanno2
aanno2
commented
Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
@wing328: As requested, I have rebased the PR onto the current master branch.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
@aanno2 can you please fix the build error:
ERROR in builds/default/api/pet.service.ts(78,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/store.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/user.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.

see https://travis-ci.org/OpenAPITools/openapi-generator/builds/640473532?utm_source=github_status&utm_medium=notification
macjohnny
macjohnny
reviewed
Jan 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

 private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
 if (typeof value === "object") {
 if (Array.isArray(value)) {
 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@macjohnnymacjohnnyJan 22, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
 (value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@aanno2aanno2Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping out. I just applied your suggestion.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
please re-generate the samples
@macjohnny
macjohnny
merged commit d111e3a
into
OpenAPITools:masterJan 27, 2020
@daniel-frakdaniel-frak
mentioned this pull request
Jan 31, 2020

Closed

5 tasks
@kenisteward
kenisteward
commented
Mar 6, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
@dougal83
dougal83
commented
Mar 7, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
Yes, it is in the latest version.
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
Are you sure? I thought that the milestone on the right was an at-a-glance indicator and it says 4.2.3. Also, if I recall correctly then I've used this feature from the current npm version. Where are you seeing 4.3.0?
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

I clicked on this link #5174 that daniel-frank posted a few comments back and it mentioned 4.3.
I am currently using 4.2.3
I have the Pagination object in my Java code as a query param and this is the TS I get
import { Sort } from'./sort';
exportinterfacePageable {
offset?: number;
sort?: Sort;
pageSize?: number;
pageNumber?: number;
paged?: boolean;
unpaged?: boolean;
}

export interface Sort {
sorted?: boolean;
unsorted?: boolean;
empty?: boolean;
}

Maybe I'm missing something
This is the command I'm running
openapi-generator generate -g typescript-angular -i ../../backend/escalation-service/target/openapi.json -o swagger/escalation-api --additional-properties npmName=@mycustom/escalation-api,ngVersion=8.1.2,npmVersion=1.0.0
Thanks for the help
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
I think it would be best to open a new issue to query this and include your 'openapi.json'. Hopefully, someone can point out the issue.

This was referenced Mar 30, 2020

Closed


Closed

@petitoutpetitout
mentioned this pull request
May 22, 2020

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macjohnnymacjohnnymacjohnny approved these changes

Assignees


No one assigned


Labels

Client: TypeScript

Projects


None yet


Milestone

4.2.3

Development

Successfully merging this pull request may close these issues.

[REQ] [typescript-angular]: support for object as query parameters


8 participants

@aanno2@macjohnny@dougal83@greghopkins@wing328@kenisteward@spencerfontein@aanno

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[REQ][typescript-angular]: support for object as query parameters - #4407
Merged
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Jan 27, 2020
Merged
[REQ][typescript-angular]: support for object as query parameters#4407
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Conversation
@aanno2
@aanno2aanno2
commented
Nov 7, 2019•

edited by macjohnny

Loading

Copy link


Copy Markdown

Contributor
fixes#4404
@macjohnny: Thank you for review
I've updated the PR and hope it will be more in-line with what is expected.
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@nicokoenig@topce@akehir
issue by @aanno2
@auto-labeler
auto-labelerBot
commented
Nov 7, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@macjohnny
macjohnny
commented
Nov 7, 2019

Copy link


Copy Markdown

Member
Thanks for your PR

Please follow the steps described in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md
macjohnny
macjohnny
reviewed
Nov 7, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/encoder.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2
commented
Nov 7, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
BTW, travis dies with 'A tuple type element list cannot be empty' but my local build with maven has not reported a problem. I'm not sure how to reproduce the error locally.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
2 times, most recently
from
9df82cf to
da8c203CompareNovember 13, 2019 15:17
@aanno2
aanno2
commented
Nov 13, 2019

Copy link


Copy Markdown

ContributorAuthor
I have updated and merge-squashed my PR with an appropriate author email. No 'real' changes.
macjohnny
macjohnny
reviewed
Nov 13, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
da8c203 to
4a96e2dCompareNovember 13, 2019 15:46
@macjohnnymacjohnny
added this to the 4.2.1 milestone
Nov 14, 2019
@aanno2
aanno2
commented
Nov 14, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny: Thank you for accepting my contribution.
macjohnny
macjohnny
reviewed
Nov 14, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

macjohnny
macjohnny
approved these changes
Nov 14, 2019
View reviewed changes
@macjohnnymacjohnny
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@macjohnny
macjohnny
commented
Nov 14, 2019•

edited

Loading

Copy link


Copy Markdown

Member
please merge the current master into your branch and update the samples again
@wing328wing328
modified the milestones:
4.2.1, 4.2.2Nov 15, 2019
@aanno2
aanno2
commented
Nov 15, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Introduced a typo before I run out of time yesterday. All fixed now.
macjohnny
macjohnny
reviewed
Nov 15, 2019
View reviewed changes
Comment threadsamples/client/petstore/typescript-angular-v8-provided-in-root/builds/with-npm/package.json
Outdated

@macjohnnymacjohnnyNov 15, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reverted
@aanno2aanno2Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Not done on purpose. Sorry!
@wing328wing328
modified the milestones:
4.2.2, 4.2.3Dec 2, 2019
@macjohnny
macjohnny
commented
Dec 4, 2019

Copy link


Copy Markdown

Member
@aanno2 can you please merge the current master and update the samples?
@dougal83
dougal83
commented
Dec 28, 2019

Copy link


Copy Markdown

Contributor
@aanno2 Thanks for this pull request. Just run into the issue myself. All set for next release?
@greghopkins
greghopkins
commented
Jan 14, 2020

Copy link


Copy Markdown

Would love for this to get merged soon... 🙏 😉
@wing328
wing328
commented
Jan 14, 2020

Copy link


Copy Markdown

Member
@aanno2 please resolve the merge conflicts and merge the latest master into this branch. Let me know if you need help on this.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
7102035 to
e461319CompareJanuary 22, 2020 14:35
@aanno2
aanno2
commented
Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
@wing328: As requested, I have rebased the PR onto the current master branch.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
@aanno2 can you please fix the build error:
ERROR in builds/default/api/pet.service.ts(78,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/store.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/user.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.

see https://travis-ci.org/OpenAPITools/openapi-generator/builds/640473532?utm_source=github_status&utm_medium=notification
macjohnny
macjohnny
reviewed
Jan 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

 private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
 if (typeof value === "object") {
 if (Array.isArray(value)) {
 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@macjohnnymacjohnnyJan 22, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
 (value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@aanno2aanno2Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping out. I just applied your suggestion.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
please re-generate the samples
@macjohnny
macjohnny
merged commit d111e3a
into
OpenAPITools:masterJan 27, 2020
@daniel-frakdaniel-frak
mentioned this pull request
Jan 31, 2020

Closed

5 tasks
@kenisteward
kenisteward
commented
Mar 6, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
@dougal83
dougal83
commented
Mar 7, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
Yes, it is in the latest version.
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
Are you sure? I thought that the milestone on the right was an at-a-glance indicator and it says 4.2.3. Also, if I recall correctly then I've used this feature from the current npm version. Where are you seeing 4.3.0?
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

I clicked on this link #5174 that daniel-frank posted a few comments back and it mentioned 4.3.
I am currently using 4.2.3
I have the Pagination object in my Java code as a query param and this is the TS I get
import { Sort } from'./sort';
exportinterfacePageable {
offset?: number;
sort?: Sort;
pageSize?: number;
pageNumber?: number;
paged?: boolean;
unpaged?: boolean;
}

export interface Sort {
sorted?: boolean;
unsorted?: boolean;
empty?: boolean;
}

Maybe I'm missing something
This is the command I'm running
openapi-generator generate -g typescript-angular -i ../../backend/escalation-service/target/openapi.json -o swagger/escalation-api --additional-properties npmName=@mycustom/escalation-api,ngVersion=8.1.2,npmVersion=1.0.0
Thanks for the help
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
I think it would be best to open a new issue to query this and include your 'openapi.json'. Hopefully, someone can point out the issue.

This was referenced Mar 30, 2020

Closed


Closed

@petitoutpetitout
mentioned this pull request
May 22, 2020

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macjohnnymacjohnnymacjohnny approved these changes

Assignees


No one assigned


Labels

Client: TypeScript

Projects


None yet


Milestone

4.2.3

Development

Successfully merging this pull request may close these issues.

[REQ] [typescript-angular]: support for object as query parameters


8 participants

@aanno2@macjohnny@dougal83@greghopkins@wing328@kenisteward@spencerfontein@aanno

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[REQ][typescript-angular]: support for object as query parameters - #4407
Merged
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Jan 27, 2020
Merged
[REQ][typescript-angular]: support for object as query parameters#4407
macjohnny merged 10 commits into
OpenAPITools:masterfrom 
aanno2:feature/aanno2-tsng-fix-query-params-master
Conversation
@aanno2
@aanno2aanno2
commented
Nov 7, 2019•

edited by macjohnny

Loading

Copy link


Copy Markdown

Contributor
fixes#4404
@macjohnny: Thank you for review
I've updated the PR and hope it will be more in-line with what is expected.
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@nicokoenig@topce@akehir
issue by @aanno2
@auto-labeler
auto-labelerBot
commented
Nov 7, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@macjohnny
macjohnny
commented
Nov 7, 2019

Copy link


Copy Markdown

Member
Thanks for your PR

Please follow the steps described in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md
macjohnny
macjohnny
reviewed
Nov 7, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/encoder.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2
commented
Nov 7, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
BTW, travis dies with 'A tuple type element list cannot be empty' but my local build with maven has not reported a problem. I'm not sure how to reproduce the error locally.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
2 times, most recently
from
9df82cf to
da8c203CompareNovember 13, 2019 15:17
@aanno2
aanno2
commented
Nov 13, 2019

Copy link


Copy Markdown

ContributorAuthor
I have updated and merge-squashed my PR with an appropriate author email. No 'real' changes.
macjohnny
macjohnny
reviewed
Nov 13, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
da8c203 to
4a96e2dCompareNovember 13, 2019 15:46
@macjohnnymacjohnny
added this to the 4.2.1 milestone
Nov 14, 2019
@aanno2
aanno2
commented
Nov 14, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny: Thank you for accepting my contribution.
macjohnny
macjohnny
reviewed
Nov 14, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

macjohnny
macjohnny
approved these changes
Nov 14, 2019
View reviewed changes
@macjohnnymacjohnny
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

@macjohnny
macjohnny
commented
Nov 14, 2019•

edited

Loading

Copy link


Copy Markdown

Member
please merge the current master into your branch and update the samples again
@wing328wing328
modified the milestones:
4.2.1, 4.2.2Nov 15, 2019
@aanno2
aanno2
commented
Nov 15, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Introduced a typo before I run out of time yesterday. All fixed now.
macjohnny
macjohnny
reviewed
Nov 15, 2019
View reviewed changes
Comment threadsamples/client/petstore/typescript-angular-v8-provided-in-root/builds/with-npm/package.json
Outdated

@macjohnnymacjohnnyNov 15, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reverted
@aanno2aanno2Nov 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Not done on purpose. Sorry!
@wing328wing328
modified the milestones:
4.2.2, 4.2.3Dec 2, 2019
@macjohnny
macjohnny
commented
Dec 4, 2019

Copy link


Copy Markdown

Member
@aanno2 can you please merge the current master and update the samples?
@dougal83
dougal83
commented
Dec 28, 2019

Copy link


Copy Markdown

Contributor
@aanno2 Thanks for this pull request. Just run into the issue myself. All set for next release?
@greghopkins
greghopkins
commented
Jan 14, 2020

Copy link


Copy Markdown

Would love for this to get merged soon... 🙏 😉
@wing328
wing328
commented
Jan 14, 2020

Copy link


Copy Markdown

Member
@aanno2 please resolve the merge conflicts and merge the latest master into this branch. Let me know if you need help on this.
@aanno2
aanno2force-pushed
the
feature/aanno2-tsng-fix-query-params-master
branch
from
7102035 to
e461319CompareJanuary 22, 2020 14:35
@aanno2
aanno2
commented
Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
@wing328: As requested, I have rebased the PR onto the current master branch.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
@aanno2 can you please fix the build error:
ERROR in builds/default/api/pet.service.ts(78,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/store.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.
builds/default/api/user.service.ts(64,27): error TS1122: A tuple type element list cannot be empty.

see https://travis-ci.org/OpenAPITools/openapi-generator/builds/640473532?utm_source=github_status&utm_medium=notification
macjohnny
macjohnny
reviewed
Jan 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache
Outdated

 private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
 if (typeof value === "object") {
 if (Array.isArray(value)) {
 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@macjohnnymacjohnnyJan 22, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 (value as []).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
 (value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
@aanno2aanno2Jan 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping out. I just applied your suggestion.
@macjohnny
macjohnny
commented
Jan 22, 2020

Copy link


Copy Markdown

Member
please re-generate the samples
@macjohnny
macjohnny
merged commit d111e3a
into
OpenAPITools:masterJan 27, 2020
@daniel-frakdaniel-frak
mentioned this pull request
Jan 31, 2020

Closed

5 tasks
@kenisteward
kenisteward
commented
Mar 6, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
@dougal83
dougal83
commented
Mar 7, 2020

Copy link


Copy Markdown

Contributor
@macjohnny. Has this been released in a version yet? I was legit looking into fixing this but found this or and am super happy haha
Yes, it is in the latest version.
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
looks like this was merged to 4.3.0, but the latest available on npm is 4.2.3 https://www.npmjs.com/package/@openapitools/openapi-generator-cli. Is there a way I can use the fix ?
Are you sure? I thought that the milestone on the right was an at-a-glance indicator and it says 4.2.3. Also, if I recall correctly then I've used this feature from the current npm version. Where are you seeing 4.3.0?
@spencerfontein
spencerfontein
commented
Mar 19, 2020

Copy link


Copy Markdown

I clicked on this link #5174 that daniel-frank posted a few comments back and it mentioned 4.3.
I am currently using 4.2.3
I have the Pagination object in my Java code as a query param and this is the TS I get
import { Sort } from'./sort';
exportinterfacePageable {
offset?: number;
sort?: Sort;
pageSize?: number;
pageNumber?: number;
paged?: boolean;
unpaged?: boolean;
}

export interface Sort {
sorted?: boolean;
unsorted?: boolean;
empty?: boolean;
}

Maybe I'm missing something
This is the command I'm running
openapi-generator generate -g typescript-angular -i ../../backend/escalation-service/target/openapi.json -o swagger/escalation-api --additional-properties npmName=@mycustom/escalation-api,ngVersion=8.1.2,npmVersion=1.0.0
Thanks for the help
@dougal83
dougal83
commented
Mar 19, 2020

Copy link


Copy Markdown

Contributor
I think it would be best to open a new issue to query this and include your 'openapi.json'. Hopefully, someone can point out the issue.

This was referenced Mar 30, 2020

Closed


Closed

@petitoutpetitout
mentioned this pull request
May 22, 2020

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macjohnnymacjohnnymacjohnny approved these changes

Assignees


No one assigned


Labels

Client: TypeScript

Projects


None yet


Milestone

4.2.3

Development

Successfully merging this pull request may close these issues.

[REQ] [typescript-angular]: support for object as query parameters


8 participants

@aanno2@macjohnny@dougal83@greghopkins@wing328@kenisteward@spencerfontein@aanno