Uh oh!
There was an error while loading. Please reload this page.
[core] Fix system properties being immutable - #4447
Merged
Merged
Conversation
When WorkflowSettings was constructed from an existing instance, as is the case when we deserialize from an external configuration file, it would result in an error: Caused by: java.lang.UnsupportedOperationException at com.google.common.collect.ImmutableMap.put(ImmutableMap.java:450) at org.openapitools.codegen.config.WorkflowSettings$Builder.withSystemProperty(WorkflowSettings.java:465) This was due to an error in `newBuilder(WorkflowSettings copy)` which assigned builder.systemProperties with an immutable map. This is incorrect because everything in the builder should be mutable until .build() is invoked.
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
1 task
jimschubert added a commit
that referenced
this pull request
Nov 13, 2019
* master: [csharp-netcore] Propagate raw content to the ApiException error content. (#4381) Remove path relative to my home dir. (#4470) Avoid generating uncompilable response body in Spring's API template (#2903) cpp-qt5-client: remove host since it is not well handled (#4429) [Java] Refactor webClient generator to use URI templates to capture correct metrics (#4314) [Java]: Client resttemplate and webclient: array parameters of type integer in path badly generated (#4379) Dart generate keywords (#4449) [core] Fix system properties being immutable (#4447) [Kotlin][Client] minor improvements (#4419) [typescript-rxjs]: Add support for nullable (#4438) [asciidoc] fix names of parameters (#4440)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When WorkflowSettings was constructed from an existing instance, as is
the case when we deserialize from an external configuration file, it
would result in an error:
This was due to an error in
newBuilder(WorkflowSettings copy)whichassigned builder.systemProperties with an immutable map. This is
incorrect because everything in the builder should be mutable until
.build() is invoked.
see #3815
I'm tagging with Gradle Plugin because this is where it was noticed. This likely affects CLI/Maven plugin as well for version 4.1.1 through 4.2.0.
cc @OpenAPITools/generator-core-team
To test, build locally, then:
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.