[Swift 4] add nullable support

[4brunu]

This PR is a continuation of #3783

Add nullable (or x-nullable in OAS2) support to swift4

This will replace the unwrapRequired option.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

[wing328]

As this is a breaking change with fallbacks, I've updated this PR to target 4.3.x instead.

[4brunu]

Since the Swift 5 generator is a new generator #4086 when it land on master, can it have this change already? Or it must go to 4.3.x also?

[wing328]

If it's a new generator. then it's perfectly fine to have all kinds of change (breaking, non-breaking)

[wing328]

Please resolve the merge conflicts when you've time. Thanks for this PR to fully support the nullable attribute in the spec.

[4brunu]

@wing328 I have fixed the merge conflicts.

[wing328]

Looks like rebase failed and this PR now includes commits in the master as well: https://github.com/OpenAPITools/openapi-generator/pull/4754/commits

I would suggest you open a new one instead. Let me know if you need help on that.

[4brunu]

@wing328 I have created #4825 👍

[4brunu]

This PR is a continuation of #3783

Add nullable (or x-nullable in OAS2) support to swift4

This will replace the unwrapRequired option.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

[wing328]

As this is a breaking change with fallbacks, I've updated this PR to target 4.3.x instead.

[4brunu]

Since the Swift 5 generator is a new generator #4086 when it land on master, can it have this change already? Or it must go to 4.3.x also?

[wing328]

If it's a new generator. then it's perfectly fine to have all kinds of change (breaking, non-breaking)

[wing328]

Please resolve the merge conflicts when you've time. Thanks for this PR to fully support the nullable attribute in the spec.

[4brunu]

@wing328 I have fixed the merge conflicts.

[wing328]

Looks like rebase failed and this PR now includes commits in the master as well: https://github.com/OpenAPITools/openapi-generator/pull/4754/commits

I would suggest you open a new one instead. Let me know if you need help on that.

[4brunu]

@wing328 I have created #4825 👍

[4brunu]

This PR is a continuation of #3783

Add nullable (or x-nullable in OAS2) support to swift4

This will replace the unwrapRequired option.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

[wing328]

As this is a breaking change with fallbacks, I've updated this PR to target 4.3.x instead.

[4brunu]

Since the Swift 5 generator is a new generator #4086 when it land on master, can it have this change already? Or it must go to 4.3.x also?

[wing328]

If it's a new generator. then it's perfectly fine to have all kinds of change (breaking, non-breaking)

[wing328]

Please resolve the merge conflicts when you've time. Thanks for this PR to fully support the nullable attribute in the spec.

[4brunu]

@wing328 I have fixed the merge conflicts.

[wing328]

Looks like rebase failed and this PR now includes commits in the master as well: https://github.com/OpenAPITools/openapi-generator/pull/4754/commits

I would suggest you open a new one instead. Let me know if you need help on that.

[4brunu]

@wing328 I have created #4825 👍

[4brunu]

This PR is a continuation of #3783

Add nullable (or x-nullable in OAS2) support to swift4

This will replace the unwrapRequired option.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

[wing328]

As this is a breaking change with fallbacks, I've updated this PR to target 4.3.x instead.

[4brunu]

Since the Swift 5 generator is a new generator #4086 when it land on master, can it have this change already? Or it must go to 4.3.x also?

[wing328]

If it's a new generator. then it's perfectly fine to have all kinds of change (breaking, non-breaking)

[wing328]

Please resolve the merge conflicts when you've time. Thanks for this PR to fully support the nullable attribute in the spec.

[4brunu]

@wing328 I have fixed the merge conflicts.

[wing328]

Looks like rebase failed and this PR now includes commits in the master as well: https://github.com/OpenAPITools/openapi-generator/pull/4754/commits

I would suggest you open a new one instead. Let me know if you need help on that.

[4brunu]

@wing328 I have created #4825 👍

[4brunu]

This PR is a continuation of #3783

Add nullable (or x-nullable in OAS2) support to swift4

This will replace the unwrapRequired option.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

[wing328]

As this is a breaking change with fallbacks, I've updated this PR to target 4.3.x instead.

[4brunu]

Since the Swift 5 generator is a new generator #4086 when it land on master, can it have this change already? Or it must go to 4.3.x also?

[wing328]

If it's a new generator. then it's perfectly fine to have all kinds of change (breaking, non-breaking)

[wing328]

Please resolve the merge conflicts when you've time. Thanks for this PR to fully support the nullable attribute in the spec.

[4brunu]

@wing328 I have fixed the merge conflicts.

[wing328]

Looks like rebase failed and this PR now includes commits in the master as well: https://github.com/OpenAPITools/openapi-generator/pull/4754/commits

I would suggest you open a new one instead. Let me know if you need help on that.

[4brunu]

@wing328 I have created #4825 👍

[4brunu]

This PR is a continuation of #3783

Add nullable (or x-nullable in OAS2) support to swift4

This will replace the unwrapRequired option.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

[wing328]

As this is a breaking change with fallbacks, I've updated this PR to target 4.3.x instead.

[4brunu]

Since the Swift 5 generator is a new generator #4086 when it land on master, can it have this change already? Or it must go to 4.3.x also?

[wing328]

If it's a new generator. then it's perfectly fine to have all kinds of change (breaking, non-breaking)

[wing328]

Please resolve the merge conflicts when you've time. Thanks for this PR to fully support the nullable attribute in the spec.

[4brunu]

@wing328 I have fixed the merge conflicts.

[wing328]

Looks like rebase failed and this PR now includes commits in the master as well: https://github.com/OpenAPITools/openapi-generator/pull/4754/commits

I would suggest you open a new one instead. Let me know if you need help on that.

[4brunu]

@wing328 I have created #4825 👍

[4brunu]

This PR is a continuation of #3783

Add nullable (or x-nullable in OAS2) support to swift4

This will replace the unwrapRequired option.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

[wing328]

As this is a breaking change with fallbacks, I've updated this PR to target 4.3.x instead.

[4brunu]

Since the Swift 5 generator is a new generator #4086 when it land on master, can it have this change already? Or it must go to 4.3.x also?

[wing328]

If it's a new generator. then it's perfectly fine to have all kinds of change (breaking, non-breaking)

[wing328]

Please resolve the merge conflicts when you've time. Thanks for this PR to fully support the nullable attribute in the spec.

[4brunu]

@wing328 I have fixed the merge conflicts.

[wing328]

Looks like rebase failed and this PR now includes commits in the master as well: https://github.com/OpenAPITools/openapi-generator/pull/4754/commits

I would suggest you open a new one instead. Let me know if you need help on that.

[4brunu]

@wing328 I have created #4825 👍

[4brunu]

This PR is a continuation of #3783

Add nullable (or x-nullable in OAS2) support to swift4

This will replace the unwrapRequired option.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

[wing328]

As this is a breaking change with fallbacks, I've updated this PR to target 4.3.x instead.

[4brunu]

Since the Swift 5 generator is a new generator #4086 when it land on master, can it have this change already? Or it must go to 4.3.x also?

[wing328]

If it's a new generator. then it's perfectly fine to have all kinds of change (breaking, non-breaking)

[wing328]

Please resolve the merge conflicts when you've time. Thanks for this PR to fully support the nullable attribute in the spec.

[4brunu]

@wing328 I have fixed the merge conflicts.

[wing328]

Looks like rebase failed and this PR now includes commits in the master as well: https://github.com/OpenAPITools/openapi-generator/pull/4754/commits

I would suggest you open a new one instead. Let me know if you need help on that.

[4brunu]

@wing328 I have created #4825 👍