Uh oh!
There was an error while loading. Please reload this page.
[go-experimental] Support selection and formatting of endpoint servers - #4755
Conversation
e01a59b to
0ec2f5fCompareUh oh!
There was an error while loading. Please reload this page.
jirikuncar
commented
Dec 11, 2019
Should I create the same patch also for |
jirikuncar
commented
Dec 13, 2019
d6205a0 to
d7ff24bComparezippolyte
commented
Dec 16, 2019
This looks good to me ! thanks @jirikuncar |
bkabrda
left a comment
There was a problem hiding this comment.
This looks really great overall. I left couple minor comments to fix, mostly improving error messages. We will also need to document this properly so that users know how to use all this functionality from the autogenerated docs.
As for including this in the stable go templates, I don't think we should do that. It breaks API of the generated clients (e.g. it removes Configuration.BasePath), so that's a no-go.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
fc8ea67 to
22bc388Compare
bkabrda
left a comment
There was a problem hiding this comment.
LGTM now (assuming CI run passes :)). Thanks!
jirikuncar
commented
Dec 16, 2019
All green 🎉 @wing328 🙏 |
jimschubert
commented
Dec 18, 2019
Thanks! This looks awesome and I'm looking forward to seeing positive use cases in the wild. |
Support selection and formatting of endpoint servers using context.
Addresses #590
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.cc @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)