Uh oh!
There was an error while loading. Please reload this page.
[Core] Added members for circular refs and container of models - #4758
Open
AIexG wants to merge 14 commits into
Open
[Core] Added members for circular refs and container of models#4758AIexG wants to merge 14 commits into
AIexG wants to merge 14 commits into
Conversation
* added model utility to handle circular dependencies (e.g. for forward declaration) * added property isModelContainer if a container contains more models
5 tasks
ContributorAuthor
I noticed that #4553 just got merged, which adds a similar functionality for a different purpose. |
getCircularReferencess to getCircularReferences
Description clarity.
…generator into improve_model_gen
wing328
commented
Dec 26, 2019
Member
When you've time, can you please add some tests similar to those added in #4553 ? |
AIexG
commented
Jan 2, 2020
ContributorAuthor
Will do when I got some time on my hands again! |
AIexG
commented
Jan 22, 2020
ContributorAuthor
Added some simple test cases, should hopefully be enough! |
AIexG
commented
Feb 6, 2020
ContributorAuthor
There was a problem hiding this comment.
I've noticed multiple times now that this list continuously causes conflicts when only separated by spaces. Changing it to line breaks again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a member
circularReferencesto CodegenModel which stores all circular referenced schemas. Created ModelUtils methodgetCircularReferencedSchemaNames()to call recursivedetectCircularReferences()to store all found circular references in a Set of strings. Set gets stored incircularReferences.Add a member flag to CodegenProperty which is true if an array schema consists of object schema items.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.Related feature request
closes#4757
Additional context
First pull request(s), hopefully doing everything right!
technical committee
cc @OpenAPITools/generator-core-team