') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [swift] date formatter add support for ISO8601 with and without milliseconds by 4brunu · Pull Request #4826 · OpenAPITools/openapi-generator · GitHub
Skip to content

[swift] date formatter add support for ISO8601 with and without milliseconds - #4826

Closed
4brunu wants to merge 28 commits into
OpenAPITools:4.3.xfrom
4brunu:feature/swift-support-date-and-date-time
Closed

[swift] date formatter add support for ISO8601 with and without milliseconds#4826
4brunu wants to merge 28 commits into
OpenAPITools:4.3.xfrom
4brunu:feature/swift-support-date-and-date-time

Conversation

@4brunu

@4brunu4brunu commented Dec 18, 2019

Copy link
Copy Markdown
Contributor

This PR allows the Swift4 generator to parse dates with the format ISO8601 with and without milliseconds.

It introduced a breaking change, by deprecating Configuration.dateFormat which is replaced by CodableHelper.dateFormatter, which means that now when someone want's a custom date formatter, instead of providing a string, they will have to provide a DateFormatter which gives more flexibility.
If someone is changing Configuration.dateFormat they will receive a compilation error that informs that they should now use CodableHelper.dateFormatter instead.
If someone is using the default Configuration.dateFormat value, this will be transparent.

This PR fixes#699 and it's a continuation of #1454.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

wing328and others added 26 commits December 12, 2019 21:21
@wing328
fix package name in tox.ini (OpenAPITools#4776)
7e75cea
@amondnet@wing328
fix(dart-dio): update gitignore according to the guide dart guide (Op…
6ed2b0d
…enAPITools#4734)
Signed-off-by: Minsu Lee <amond@amond.net>
@josh-burton@wing328
[dart-dio] Fixes enum by setting the wireName to the correct value (O…
f784667
…penAPITools#4708)
@ityuhui@wing328
[C-libcurl] Change "complexType" to "name" in "isMapContainer" to fix…
1e995ca
… building error when complexType is empty. (OpenAPITools#4768)
@petejohansonxo@macjohnny
[typescript-redux-query] Add proper modelling of allOf usage. (OpenAP…
db2c8e8
…ITools#4780)
@djnalluri@macjohnny
[typescript-angular] Control Accept header via param (OpenAPITools#4774)
3754679
* [typescript-angular] Control response mime type via param
* [typescript-angular] Update samples.
* [typescript-angular] Wrap httpHeaderAccept in an options object.
* [typescript-angular] Updated samples.
@ro0NL@wing328
[PHP] Preserve JSON accept header (OpenAPITools#4684)
0ffb99a
* [PHP] Preserve JSON accept header
* recompile php client
* revise
* recompile
@Mordag@wing328
[Kotlin][Client] Added new option to enable moshi code generator (Ope…
02f5cb1
…nAPITools#4781)
* Added new option to enable moshi code generator
* Tweaking Serializer template
@spacether@jimschubert
[Python] Adds allOf/oneOf/anyOf composed models (OpenAPITools#4446)
789f1a0
* Adds composed model support for allOf oneOf anyOf
* Moves discriminator into discriminator() class method, adds test_deserialize_lizard, adds setting discriminator using allOf schema
@javils@wing328
Feature/kotlin/library/retrofit (OpenAPITools#4518)
bb4af91
* Some clean code.
* Add support for retrofit2 in models and apis. Need work in ApiClient, but it's not urgent.
* Add ApiClient with retrofit2 support.
* Remove unnecessary package.
* Add scripts to generate samples.
* Generate sample of retrofit2
* Change toUpperCase to toUpperCase(Locale.ROOT) to fix compile.
* Added GSON library when it's needed
* Fix typo.
* Add some missing common files.
* Execute bin script.
* Remove copy&paste error in script.
* [kotlin] update outdated files
* Fix apis with no params.
* Add missing import in ApiClient
* Add support for CSV, SSV, TSV, PIPES, SPACES in retrofit 2 library.
* Fix package name.
* Execute kotlin-client-retrofit2.sh script.
* force rebuild.
* execute script again.
* Add missing imports from okhttp3.
@deprecated has a message param that java not. Add it with a default message.
* Execute retrofit2 script.
* Rerun script.
@wing328
CI improvements (OpenAPITools#4791)
adbed05
* run all script in circleci
* test kotlin clients
* add new files
* undo chanages to circleci script
* update samples
* update bitwise config
* fix typo
@ybelenko@wing328
[Slim4] Data mocker for scalar types (OpenAPITools#4751)
7bd378c
* [Slim4] Add OpenApiDataMocker interface template
* [Slim4] Implement scalar types in data mocker
* [Slim4] Cleanup, remove unused variables
I've rejected the idea to keep Composer dependencies in Java/codegen
variables at some point of time. It seems that after Git rebase I forgot
to delete them.
* [Slim4] Refresh samples
* [Slim4] Add pattern option to mockString method
[ref] https://tools.ietf.org/html/draft-wright-json-schema-validation-00#section-5.8
* [Slim4] Add enum option to mockString method
[ref] https://tools.ietf.org/html/draft-wright-json-schema-validation-00#section-5.20
* [Slim4] Refactor mockInteger and mockNumber tests
* [Slim4] Refactor mockString tests
* [Slim4] Use null coalescing operator
* [Slim4] Implement enum option in mockString method
* [Slim4] Add tests for enum option of mockString
@ahrytsiuk@wing328
fix template for RequestBody, added 'required' attribute (OpenAPITool…
a9cc96b
…s#3134) (OpenAPITools#4756)
* fix template for RequestBody, added 'required' attribute (OpenAPITools#3134)
* update Spring samples (OpenAPITools#3134)
@wing328
Add @athornz,@amondnetto Dart technical committee (OpenAPITools#4800)
49022d7
@amondnet@wing328
[dart][dio] add dateLibrary options ( core, timemachine ) (OpenAPIToo…
c98644a
…ls#4716)
* feat(dart-dio): add datelibrary options
Signed-off-by: Minsu Lee <amond@amond.net>
* fix: missing semicolon
Signed-off-by: Minsu Lee <amond@amond.net>
* enum name
* fix test
* fix test
@wing328
Add Oracle as the OpenAPI Generator user (OpenAPITools#4809)
8d37641
* add oracel as the user
* add oracle to the user list
@jirikuncar@wing328
[Python] Remove mutable default argument (OpenAPITools#4665)
45eb87c
@e-jigsaw@wing328
Fix typo (OpenAPITools#4813)
67de4c4
@AIexG@wing328
breaking allModels indexing from updateAllModels apart into its own m…
1f8383a
…ethod getAllModels (OpenAPITools#4753)
@jimschubert@wing328
[samples] Fix --batch option for slim4/feign and regenerate (OpenAPIT…
399e73e
…ools#4810)
@wing328
comment out python (2.x) flask test
62e5d1f
@zippolyte@jimschubert
[go-experimental] Fix issue with nullable marshalling comparing to em…
7ea4dcd
…pty string no matter the enum type (OpenAPITools#4712)
@zippolyte@jimschubert
[go-experimental] Remove duplicated line (OpenAPITools#4410)
83cb420
* Remove duplicated line
@4brunu
[swift] date formatter add support for ISO8601 with and without milis…
f29f59e
…econds
@4brunu
Merge branch 'master' into feature/swift-support-date-and-date-time
c37a0aa
# Conflicts:
#	samples/client/petstore/dart2/openapi/.openapi-generator/VERSION
@4brunu
Revert "Merge branch 'master' into feature/swift-support-date-and-dat…
8e1e58e
…e-time"
This reverts commit c37a0aa, reversing
changes made to f29f59e.
@4brunu4brunu changed the title [swift] date formatter add support for ISO8601 with and without miliseconds[swift] date formatter add support for ISO8601 with and without millisecondsDec 18, 2019
@4brunu

4brunu commented Jan 2, 2020

Copy link
Copy Markdown
ContributorAuthor

Close in favor of #4086

@4brunu4brunu closed this Jan 2, 2020
@4brunu
4brunu deleted the feature/swift-support-date-and-date-time branch May 18, 2020 09:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

18 participants

@4brunu@wing328@amondnet@josh-burton@ityuhui@petejohansonxo@djnalluri@ro0NL@Mordag@spacether@javils@ybelenko@ahrytsiuk@jirikuncar@e-jigsaw@AIexG@jimschubert@zippolyte